From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BD3AC46CCD for ; Tue, 19 Dec 2023 12:31:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XvkHlHQnZU1Hy1ZwkDCiUKOn4DdoTmWQ3iGghJ3XcNk=; b=NQmXYDwDLLqx1q Z7JZnUDnjS4aSVoMeLI28hfzBlzAGZfZxwoz0XkAhtC6TGKKUju+AmhKJyE9HGIUQ/dtxCCQK6pq1 84LVdL2oeSm5+GWQ69fWDAHiJ+SKoW2p4zsz/PS+7BPpUs4NqsDZ6RFP2X2eaPkD9QwVHz10wVj2x 9zOqTJ9mY4wkGUEIYU9k8HaNpcZHbDJy8P+pBzn3nskxE8fMCihYTx0PwH6ZuOP1f+K5os+BvZvsi f8SD+5WhlYHQ7Mey2s6jKQuWX98/Ut52d1GC4QuTdL/JPJEK7B+tO0qMUwQQIkrGOirBBUNDxQ+PZ nOj4CpAhUKpWOB56mvTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFZEz-00E1fh-2a; Tue, 19 Dec 2023 12:30:29 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFZEs-00E1cN-0V for linux-arm-kernel@lists.infradead.org; Tue, 19 Dec 2023 12:30:23 +0000 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a2331e7058aso375953666b.2 for ; Tue, 19 Dec 2023 04:30:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702989019; x=1703593819; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=uAE5oZxuQF7vsLFo157rr7pOuH+fIC0h765Im6IICOg=; b=KA8lgClboNWEzBMxpGxiFo5h0a2H1uAk61bW6xA5bRflmnKv7qlQiBZpf83V+viNCj +Hw09KN8uCRGwFJ+kokA15GMQ+OI08vXo6WFYqtHrZHQEe2kf993HouFpvbph0xhwy6g 6PsUw0fR0REEyAa7r/Inf0LEBcJfRp4nItHnIPFwAmWhQq3bPhsXiRwM1eECHXjzSpTg 93naIXUnh68Y1ma+zAWL80gCOYs3Wv6rAEgI5DPgUIVzzN8zKl7bgaAPsWSnnh6W5WIH Ht3RnPjPDtlEKyinIbjT5l4p4HaebJNpPvCHmoCq43RA7zHA8kVubE+FQJe6+rSGvis2 tFig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702989019; x=1703593819; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uAE5oZxuQF7vsLFo157rr7pOuH+fIC0h765Im6IICOg=; b=qUvN4xFP/nPD6sx9UZ9lOzQziQQf/eg+BvR2rt7r5bgUcZeUx2SIvAz14BNM2BIZxb V5cl2Di75mZxK5oTqBGnujN8wKGrLRPmlqb1LZOUitrwl/bBNZ7oGVXCo7byZm19IgXh rPKmGrDcUgrjIzqLlWnxNxhutW0cScrpKYAKPzRebznNQp4RE2aiyLkFhbBFU3VaNATv xahym3XRjN1jcPCQRWTUgfHa9a6vj4f3S2GDCCJkNzgWYk816NGka9Aq76pAbyXF6KR/ 1kpZ/PC6GQ5LLwooJZUF2OxqoOQ8mabFBd91yHCzNdmHoWi7kRgdoy9JpHOz+oqgLwLm KTdw== X-Gm-Message-State: AOJu0YxgJu+yWpg4teFGxSpV1jsQ+MbO2apZYcaV/oKgzw77gQ1bue6E ZGdhk1niFA0MibK29AuTnn0= X-Google-Smtp-Source: AGHT+IFc5N71mVk34rjjafqWNqN0PdEd8VSeSvwch2jdpbByer+h2AyqIB/ZBY2FIKsYDc2IkcIZIQ== X-Received: by 2002:a17:906:493:b0:a23:5f76:3467 with SMTP id f19-20020a170906049300b00a235f763467mr639744eja.100.1702989018649; Tue, 19 Dec 2023 04:30:18 -0800 (PST) Received: from skbuf ([188.27.185.68]) by smtp.gmail.com with ESMTPSA id x24-20020a170906135800b00a25501f4160sm492406ejb.1.2023.12.19.04.30.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 04:30:18 -0800 (PST) Date: Tue, 19 Dec 2023 14:30:16 +0200 From: Vladimir Oltean To: Romain Gantois Cc: Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Miquel Raynal , Maxime Chevallier , Sylvain Girard , Pascal EBERHARD , Richard Tresidder , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net 0/1] Prevent DSA tags from breaking COE Message-ID: <20231219123016.6xy3gamz4lkr5fdz@skbuf> References: <20231218162326.173127-1-romain.gantois@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231218162326.173127-1-romain.gantois@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231219_043022_192760_97D884F5 X-CRM114-Status: GOOD ( 12.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 18, 2023 at 05:23:22PM +0100, Romain Gantois wrote: > I've run some iperf3 tests and the TX hotpath performance doesn't seem > to be degraded by the field added to dma_features. I don't know what CPU cores you are using, but if the iperf3 performance was line rate at gigabit before and is line rate at gigabit now, you haven't effectively measured the impact of the change (and "doesn't seem to be degraded" is a false conclusion). You need something more CPU intensive to see the difference, like IP forwarding of 64 byte packets. A very simplistic way to set up IP forwarding between 2 DSA user ports is to do this on the router board (DUT): echo 1 > /proc/sys/net/ipv4/ip_forward ip link set swp0 up && ip addr add 192.168.100.2/24 dev swp0 ip link set swp1 up && ip addr add 192.168.101.2/24 dev swp1 and this on the system with 2 endpoints: ip netns add ns0 ip link set $ETH1 netns ns0 ip link set $ETH0 up && ip addr add 192.168.100.1/24 dev $ETH0 ip -n ns0 link set $ETH1 up && ip -n ns0 addr add 192.168.101.1/24 dev $ETH1 ip route add 192.168.101.0/24 via 192.168.100.2 ip -n ns0 route add 192.168.100.0/24 via 192.168.101.2 ./net-next/samples/pktgen/pktgen_sample03_burst_single_flow.sh -i $ETH0 -s 64 -m 00:04:9f:05:de:0a -d 192.168.101.1 -t 2 -f 13 -c 0 -p 400 -n 0 -b 4 I compiled the commands from some notes I had lying around, I didn't retest them. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel