From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F4BFC3DA6E for ; Wed, 20 Dec 2023 15:04:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1qvDvfbvaxntlZ9+pB9kgL6Gn2HVCn5sC3Cs58rKflM=; b=hD9Yy83MFfr1zl 2XhW5gz4Jsbx1UIg+8V9yXIsKSmwFkRTWVlGZVpUUqtEcJ7DZDNlH6X8+9itdzOuph7LRx5/bYxvh IpdH/jTTdU3m4/0jQXbXn1d2NvY4IYJfAdCqERdZF2vi5SEggayy9xGyThiGRl1SjqnTFPLKNw/Lw ljWF2ObZLDS1OcnF82Cz24S6jQJF0V+1z8UBllFTJaUUB+Es2p6TgnTks3B2KtTETFj5OvFMRaAU5 xy3ffQT/chSDj9fBEvhPLy4j83Y2hb/FHUN/WMedmKxrhuXwB03iFYnkQp21t+llY4rj+fcMpLyoJ PGFlGVDxrRs9WYk/J6+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFy7M-000AbI-1q; Wed, 20 Dec 2023 15:04:16 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFy7J-000Aa0-2D for linux-arm-kernel@lists.infradead.org; Wed, 20 Dec 2023 15:04:15 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5900D1FB; Wed, 20 Dec 2023 07:04:50 -0800 (PST) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AF96D3F64C; Wed, 20 Dec 2023 07:04:03 -0800 (PST) Date: Wed, 20 Dec 2023 15:04:00 +0000 From: Andre Przywara To: fuyao Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Alexandre TORGUE , Enric Balletbo i Serra , Baruch Siach , Paul Barker , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] ARM: dts: sun8i: r40: open the regulator aldo1 Message-ID: <20231220150400.0f32e2a5@donnerap.manchester.arm.com> In-Reply-To: References: Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231220_070413_772893_907AD06B X-CRM114-Status: GOOD ( 20.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 20 Dec 2023 16:18:43 +0800 fuyao wrote: Hi, > the aldo1 is connect regulator pin which power the TV. What do you mean with that? That ALDO1 is connected to VCC-TVOUT and/or VCC-TVIN on the R40 SoC? > The USB core use TV ref as reference Voltage. The USB core in the SoC? So pin VCC-USB, which requires 3.3V, the same voltage as the TV pins? Which means this doesn't really have much to do with TV, it's just that USB and also "TV" are supplied by ALDO1? > Signed-off-by: fuyao > --- > arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi b/arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi > index 9f39b5a2bb35..8906170461df 100644 > --- a/arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi > +++ b/arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi > @@ -42,6 +42,13 @@ &pio { > vcc-pg-supply = <®_dldo1>; > }; > > +®_aldo1 { > + regulator-always-on; So did USB never work before, with the DT as in mainline? For always-on regulators it would be good to see some rationale why this cannot be referenced by its consumer. If it is really supplying the USB core, that would be a reason, because we don't have a good way of describing this. > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-name = "vcc-aldo1"; Regulators should be named after their users, so use something like: regulator-name = "vcc-3v3-tv-usb"; That then also serves as documentation of why this is always on. Cheers, Andre > +}; > + > ®_aldo2 { > regulator-always-on; > regulator-min-microvolt = <1800000>; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel