From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1263C3DA6E for ; Wed, 20 Dec 2023 07:24:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Hi6b38YcaQxXyH69kJCZrRO5HYibadhqwbiCLY5kUNc=; b=bduxTQAbgEIqwP Y7MEPwH7soaG3F9d9wrFaAbaC0E/6gpZBI+eAmtpQnaZvLE0sDeSqBQEORSXLAYDXWV2kGq7pavJ6 ERhd7MEiNKWEHUnfGesmCilHm6AsVVnq+MWpW12zzdbZVtm7mNnJxF1hNSddoq5qZ1CgO4Dfk8iQR jEdLiBVTPYNUAVxTCusKlHgKnY6EfhydatvMAf8chpo88fLRMlb349ivED97ZwvIC9jt+wVZQKBqW 8RuEanGtsY+kz+ieV+jrTyiINGNfxUn3Nd/5FC9UGXygKmJg246ShqDP+sZRhUItpaKhX+suApzQE Lt7y/rDgjwJcAbjN6BZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFqwM-00GPDh-02; Wed, 20 Dec 2023 07:24:26 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFqwJ-00GPCt-0C for linux-arm-kernel@lists.infradead.org; Wed, 20 Dec 2023 07:24:24 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id DF2F1CE1B1F; Wed, 20 Dec 2023 07:24:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE96CC433C7; Wed, 20 Dec 2023 07:24:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1703057060; bh=02WAEjZxXiuUFxvRqN4ekwAW7zo4t9NtuU0rypyWqEU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=J9tY0CrL0Lvo95rvkS5dFBhk3h8JDQQ6FyWUQRF0N+O3Kw8Qjt2f478BcDrRfhNZ0 nPsA6Wgsv0F0KRbciMlWNpY2haw/IhLg+ffR2eUdJolMYdA4lI/ttLn69bKcRs1bSO NqoKwPlSVsMJ4+swsHeV/7T4MY0RGeSJw4BzFVFc= Date: Wed, 20 Dec 2023 08:24:17 +0100 From: Greg Kroah-Hartman To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Russell King , Arnd Bergmann , Randy Dunlap Subject: Re: [PATCH] [ARM] locomo: make locomo_bus_type constant and static Message-ID: <2023122020-tastiness-counting-788f@gregkh> References: <2023121905-idiom-opossum-1ba3@gregkh> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231219_232423_323233_218D70DC X-CRM114-Status: GOOD ( 24.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 19, 2023 at 10:21:20PM +0100, Uwe Kleine-K=F6nig wrote: > On Tue, Dec 19, 2023 at 07:33:06PM +0100, Greg Kroah-Hartman wrote: > > Now that the driver core can properly handle constant struct bus_type, > > move the locomo_bus_type variable to be a constant structure as well, > > placing it into read-only memory which can not be modified at runtime. > > = > > It's also never used outside of arch/arm/common/locomo.c so make it > > static and don't export it as no one is using it. > > = > > Cc: Russell King > > Cc: Arnd Bergmann > > Cc: "Uwe Kleine-K=F6nig" > > Cc: Randy Dunlap > > Cc: linux-arm-kernel@lists.infradead.org > > Signed-off-by: Greg Kroah-Hartman > > --- > > arch/arm/common/locomo.c | 4 +++- > > arch/arm/include/asm/hardware/locomo.h | 2 -- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > = > > diff --git a/arch/arm/common/locomo.c b/arch/arm/common/locomo.c > > index 70480dd9e96d..6d0c9f7268ba 100644 > > --- a/arch/arm/common/locomo.c > > +++ b/arch/arm/common/locomo.c > > @@ -68,6 +68,8 @@ struct locomo { > > #endif > > }; > > = > > +static const struct bus_type locomo_bus_type; > > + > = > If you move up locomo_bus_type together with its three callbacks before > locomo_init_one_child, you don't need the extra declaration here. I was trying to go for "least intrusive and most obvious change possible" here, given that this file hasn't been touched in over a decade by anyone else for anything other than api changes. And even then, it was just a tiny fix, this is a very old driver, what's the odds that it's even used anymore? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel