From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02A01C35274 for ; Thu, 21 Dec 2023 08:55:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QVUsZrRwSe/YzP64rqVNIgeMCwWcRX87HCWnlH1mTsA=; b=rFCwXOGdr55FCe 481Qhk53piMbskaBZv41j/gAbs8njhOHmmWkE1fCvAtRNzitnYw24YmEGlzj80hiFVfDI9XVq206b 0hs7Lia3W2QTWLfZoz++K1hkxDzEPPKuJmKjQKdYxg4mfNZmUV2WlCN1qAkSUWwE3xhc9EtvZiAGy t5XmAxIAwa2+9s3cqmtyH23USvWukv9+nAyKp2Nq508MCGTEqSJEOyGwSivoSlK25sUqsBYkudAFD dmP1s8qdS7pq49pOP/wOyfW/aUBUpWwG/rN+ky0NaPM28sp/VJZyaBeCdR8WOHLpgz/358RXWtlON 1uxL3NfxN6U/kfizMNsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rGEpS-0026Hw-2j; Thu, 21 Dec 2023 08:54:54 +0000 Received: from mgamail.intel.com ([192.198.163.9]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rGEpL-0026E6-1F for linux-arm-kernel@lists.infradead.org; Thu, 21 Dec 2023 08:54:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703148887; x=1734684887; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1JsXbGf0ei8NX9i8T+iRqjYzH4+nfdAl4Vq6Pu5B8C0=; b=ZU2HpbcO0dWrNsntSkHSDuFMfJQo0nP6MzehUyLff2CfuSAfvrqwnJIK sD15Ir/o1AJxs1AyjGwN5QCdRIfPkp1mnr9LfccDDqeoOPYR03bonfRUK SlYKX/6n9Hs7sqNItVCL+AuH8FsJmGJ3EnRngzo33P7Cwhi9R1cboh/kP Sd2hZzfFud/HWSVkeX+IAPQTVp9nSf+Rdm0CMbtYRLJFZ/mTRyg79yMaS IYLMsIwMQbciXxiplhjCIWHdv3F50zvSiO9JD2g4E4IiL42KDAXdZDt9g sn6d9gZrFreAzKl5hwiZ/I5yklz3FrRPPHhNyzq+D8ivO5lLT0GyXPdIn A==; X-IronPort-AV: E=McAfee;i="6600,9927,10930"; a="2793719" X-IronPort-AV: E=Sophos;i="6.04,293,1695711600"; d="scan'208";a="2793719" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2023 00:54:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10930"; a="842568348" X-IronPort-AV: E=Sophos;i="6.04,293,1695711600"; d="scan'208";a="842568348" Received: from ssid-ilbpg3-teeminta.png.intel.com (HELO localhost.localdomain) ([10.88.227.74]) by fmsmga008.fm.intel.com with ESMTP; 21 Dec 2023 00:54:41 -0800 From: "Gan, Yi Fang" To: Greg Kroah-Hartman , Andrew Halaney , Javier Martinez Canillas , John Stultz , "Rafael J . Wysocki" , Gan Yi Fang , Jens Axboe , Russell King , Andrew Lunn , Heiner Kallweit , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?UTF-8?q?Marek=20Beh=C3=BAn?= , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Looi Hong Aun , Voon Weifeng , Song Yoong Siang , Lai Peter Jun Ann , Choong Yong Liang Subject: [PATCH net v2 2/2] net: phylink: Add module_exit_stub() Date: Thu, 21 Dec 2023 16:51:09 +0800 Message-Id: <20231221085109.2830794-3-yi.fang.gan@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231221085109.2830794-1-yi.fang.gan@intel.com> References: <20231221085109.2830794-1-yi.fang.gan@intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231221_005447_436046_6AD1149E X-CRM114-Status: GOOD ( 10.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In delete_module(), if mod->init callback is defined but mod->exit callback is not defined, it will assume the module cannot be removed and return EBUSY. The module_exit() is missing from current phylink module drive causing failure while unloading it. Add module_exit_stub() in phylink for the module to be unloadable. Fixes: eca68a3c7d05 ("net: phylink: pass supported host PHY interface modes to phylib for SFP's PHYs") Cc: # 6.1+ Signed-off-by: Gan, Yi Fang --- drivers/net/phy/phylink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 25c19496a336..823c9b43cd92 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -3725,6 +3725,7 @@ static int __init phylink_init(void) } module_init(phylink_init); +module_exit_stub(phylink); MODULE_LICENSE("GPL v2"); MODULE_DESCRIPTION("phylink models the MAC to optional PHY connection"); -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel