Re: [PATCH v2 3/8] dt-bindings: marvell: a38x: add solidrun armada 388 clearfog boards

From: Conor Dooley <conor@kernel.org>
To: Josua Mayer <josua@solid-run.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v2 3/8] dt-bindings: marvell: a38x: add solidrun armada 388 clearfog boards
Date: Sun, 24 Dec 2023 14:42:42 +0000	[thread overview]
Message-ID: <20231224-tibia-thursday-bea9dde2fbf1@spud> (raw)
In-Reply-To: <20231224143850.5671-4-josua@solid-run.com>

[-- Attachment #1.1: Type: text/plain, Size: 2571 bytes --]

On Sun, Dec 24, 2023 at 03:38:45PM +0100, Josua Mayer wrote:
> Add DT compatible for SolidRun Armada-388 based Clearfog Base and Pro
> boards.
> 
> While they are just two variants, we have 3 device-tree:
> - armada-388-clearfog.dts
> - armada-388-clearfog-base.dts
> - armada-388-clearfog-pro.dts
> 
> While the first one is identical to the pro variant, the filename is
> not, and neither are the compatible strings.
> 
> The first is compatible to armada-380, 385, 388 and
> solidrun,clearfog-a1.
> The other two are compatible to the same, plus an additional string
> including the pro/base as suffix.
> 
> Add two bindings, one for the explicit pro and base variants using a
> total of 5 compatibles, and one for the generic name using just 4.
> 
> Signed-off-by: Josua Mayer <josua@solid-run.com>

There's nothing here that explains to me _why_ there are three sets of
compatibles for only two boards. Why is this the case?

Also, binding patches need to be sent to the devicetree mailing list.
get_maintainer.pl should have told you that, no?

> ---
>  .../bindings/arm/marvell/armada-38x.yaml      | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
> index 5bc69c4fe34d..25c29b466094 100644
> --- a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
> +++ b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
> @@ -38,4 +38,24 @@ properties:
>            - const: marvell,armada385
>            - const: marvell,armada380
>  
> +      - description: |

This isn't needed, there's no formatting to preserve.

Cheers,
Conor.

> +          SolidRun Armada 388 SoM based clearfog board. This is
> +          equivalent to clearfog pro, but lacks the "pro" label
> +          in dtb filename and compatible strings.
> +        items:
> +          - const: solidrun,clearfog-a1
> +          - const: marvell,armada388
> +          - const: marvell,armada385
> +          - const: marvell,armada380
> +
> +      - description: SolidRun Armada 388 SoM based clearfog board variants
> +        items:
> +          - enum:
> +             - solidrun,clearfog-base-a1
> +             - solidrun,clearfog-pro-a1
> +          - const: solidrun,clearfog-a1
> +          - const: marvell,armada388
> +          - const: marvell,armada385
> +          - const: marvell,armada380
> +
>  additionalProperties: true
> -- 
> 2.35.3
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel