From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCAAEC46CD2 for ; Sun, 24 Dec 2023 14:43:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9Bv12hLfyIuPuuxtsilhedkIKG2MfjN8D3jrZEcHiv8=; b=LcaiPjNf6aIELQctPMy3YtjTwN mSj5TZmcLNPiaQLlQ7AiDEZy79I32Kzdf7GkEzvVmAPF2oixIPduau3IlYntoZ5/8ctGe57GYIRtH svub3miTf6dP6c4dpXxEqbsMVtBSIRmHooBtcdYN9z6UFMJ1WjHP2SiMd3R5gGEjaXmtKGqaOx0dJ L6w5xt1DqF/OW8gxPkpLLCzs/O/B0nknloyFlNebvemij5Yfv4vubN9JAAe9vuyRdXVKOI6Ostddv +xnrA9DSQnWiCvT1DWq+Guzz1G9+BV5eFIBiw4VGWA3jaFpYGg7ufJuydAtFKpZ/d4a8r2jAHLM37 DXI919gw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rHPgt-009Ve3-31; Sun, 24 Dec 2023 14:42:55 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rHPgq-009Vd5-20 for linux-arm-kernel@lists.infradead.org; Sun, 24 Dec 2023 14:42:54 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id C622BB80687; Sun, 24 Dec 2023 14:42:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9418C433C8; Sun, 24 Dec 2023 14:42:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703428966; bh=MvrtUsr3Zm/Syz0vJ6mnAnrnKlJdZIwsYBhZE/zEymo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XjRSwpsX25B5kJ72yoFqtoJEv5Zdqeeqvhb+YKLYm426yLmg6sZAGNUXQi1tUQPsn V+C4CEf4EDT9YvJb2WWBbszG2TgQwm8/H6891HCGQaB+3nOzRHWozBTm91lCJKDXXL o5NeJm3E31g0YaDoeuOCEMudZD2QOwfr2mKzo7ykfy73dWZcJWr8sb6VIr4ssj//Ev gL2RMQBCgporrpfcHVUYSzqbFvZTzURhvXPFUma0pTknPY9dUCr+O60LWpCe8kGEBF pEzJVyzJT3vt0KaJQSMSe0/GqD2l7A4xss/48wCqjqMBVZpvGJWn/vCg947lmdzNcj Ford4LCbFe4Xg== Date: Sun, 24 Dec 2023 14:42:42 +0000 From: Conor Dooley To: Josua Mayer Cc: linux-arm-kernel@lists.infradead.org, Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley Subject: Re: [PATCH v2 3/8] dt-bindings: marvell: a38x: add solidrun armada 388 clearfog boards Message-ID: <20231224-tibia-thursday-bea9dde2fbf1@spud> References: <20231224143850.5671-3-josua@solid-run.com> <20231224143850.5671-4-josua@solid-run.com> MIME-Version: 1.0 In-Reply-To: <20231224143850.5671-4-josua@solid-run.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231224_064252_954093_CA2C772F X-CRM114-Status: GOOD ( 20.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3192719383774602935==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3192719383774602935== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gjTdUxEZOhAREbcS" Content-Disposition: inline --gjTdUxEZOhAREbcS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 24, 2023 at 03:38:45PM +0100, Josua Mayer wrote: > Add DT compatible for SolidRun Armada-388 based Clearfog Base and Pro > boards. >=20 > While they are just two variants, we have 3 device-tree: > - armada-388-clearfog.dts > - armada-388-clearfog-base.dts > - armada-388-clearfog-pro.dts >=20 > While the first one is identical to the pro variant, the filename is > not, and neither are the compatible strings. >=20 > The first is compatible to armada-380, 385, 388 and > solidrun,clearfog-a1. > The other two are compatible to the same, plus an additional string > including the pro/base as suffix. >=20 > Add two bindings, one for the explicit pro and base variants using a > total of 5 compatibles, and one for the generic name using just 4. >=20 > Signed-off-by: Josua Mayer There's nothing here that explains to me _why_ there are three sets of compatibles for only two boards. Why is this the case? Also, binding patches need to be sent to the devicetree mailing list. get_maintainer.pl should have told you that, no? > --- > .../bindings/arm/marvell/armada-38x.yaml | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yam= l b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml > index 5bc69c4fe34d..25c29b466094 100644 > --- a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml > @@ -38,4 +38,24 @@ properties: > - const: marvell,armada385 > - const: marvell,armada380 > =20 > + - description: | This isn't needed, there's no formatting to preserve. Cheers, Conor. > + SolidRun Armada 388 SoM based clearfog board. This is > + equivalent to clearfog pro, but lacks the "pro" label > + in dtb filename and compatible strings. > + items: > + - const: solidrun,clearfog-a1 > + - const: marvell,armada388 > + - const: marvell,armada385 > + - const: marvell,armada380 > + > + - description: SolidRun Armada 388 SoM based clearfog board varian= ts > + items: > + - enum: > + - solidrun,clearfog-base-a1 > + - solidrun,clearfog-pro-a1 > + - const: solidrun,clearfog-a1 > + - const: marvell,armada388 > + - const: marvell,armada385 > + - const: marvell,armada380 > + > additionalProperties: true > --=20 > 2.35.3 >=20 --gjTdUxEZOhAREbcS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZYhDYgAKCRB4tDGHoIJi 0swqAQD7XCxYJ/+0Q6yRZeXlxA8O5z/z+jfhN6za0zlN4uH6YQEAtxyH0aHFO4+q zYRW5jpW8ZYiFdEBDHfG+LRfrEvXRwM= =c4Ap -----END PGP SIGNATURE----- --gjTdUxEZOhAREbcS-- --===============3192719383774602935== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3192719383774602935==--