From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED04EC46CD3 for ; Tue, 26 Dec 2023 10:41:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2U1SqMIxbKOqM9hNfjzEjBM31SXTeu1RJ3FUyKnEm6w=; b=ic2cm1SJTEx+Lt uWK5xAGeDcL808kozvKlrIgB3GCe/RPaLnvI+titLWUSWFjZWO6oomgPafjFSvGpRWfaaFEWR1Nsd oZtAgyvxbmnnHB9mnOJXyElnmRbJ3YkS1HFbtIR5zyMNl0zOQ3Cb7iLOwbysdcdb8ROhqcpYjjUTq fSdA00MqLSN+qBbdzslbmumrhaPdkQfcRDabtj0AjZcHIfKi+lSPIPQyVgJ34FAT5JOOl5nJ3I11I QMgQDs0lV/VTAnvMDbfoPs/6tW1D7dU6a7MEuxQLvgSqm9UVAptGnz+LE6BdW7gB0pWXcZWIx22Sw B8ZDTxtAUmmCoVuuHWbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rI4rR-00C5Hi-3C; Tue, 26 Dec 2023 10:40:34 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rI4rO-00C5Gi-1W for linux-arm-kernel@lists.infradead.org; Tue, 26 Dec 2023 10:40:32 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 301652F4; Tue, 26 Dec 2023 02:41:10 -0800 (PST) Received: from minigeek.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D2C5E3F5A1; Tue, 26 Dec 2023 02:40:22 -0800 (PST) Date: Tue, 26 Dec 2023 10:40:04 +0000 From: Andre Przywara To: Fuyao Kashizuku Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Florian Fainelli , Wei Xu , Gregory CLEMENT , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, =?UTF-8?B?6bqm5YGl5bu6?= Subject: Re: [PATCH v2] ARM: dts: sun8i: Open FETA40i-C regulator aldo1 Message-ID: <20231226104004.0cec26a9@minigeek.lan> In-Reply-To: References: Organization: Arm Ltd. X-Mailer: Claws Mail 4.2.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231226_024030_644589_C358C48E X-CRM114-Status: GOOD ( 19.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 26 Dec 2023 16:40:05 +0800 Fuyao Kashizuku wrote: Hi, many thanks for the quick turnaround! > The USB PHY in the Allwinner R40 SoC seems to rely on voltage on the > VCC-TVIN/OUT supply pins for proper operation, on top of its own supply > voltage on VCC-USB. Without a 3.3V voltage supplied to VCC-TV*, USB > operation becomes unstable and can result in disconnects. > > The Forlinx FETA40i-C SoM connects both the VCC-TVOUT and VCC-TVIN pins > to the ALDO1 rail of the PMIC, so we need to enable that rail for USB > operation. Since there is no supply property in the DT bindings for > the USB core, we need to always enable the regulator. > > This fixes unstable USB operation on boards using the Forlinx FETA40i-C > module. > > Signed-off-by: Fuyao Kashizuku Perfect, looks good to me now! Reviewed-by: Andre Przywara Thanks! Andre > --- > Changes in v2: > - Subject include board name. > - regulator name changed to vcc-3v3-tv-usb. > - explain why we need to enable the regulator. > - use full name of the commiter > - Link to v1: https://lore.kernel.org/lkml/ZYKjYypuAx7gNuam@debian.cyg/ > > arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi b/arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi > index 9f39b5a2bb35..c12361d0317f 100644 > --- a/arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi > +++ b/arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi > @@ -42,6 +42,13 @@ &pio { > vcc-pg-supply = <®_dldo1>; > }; > > +®_aldo1 { > + regulator-always-on; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-name = "vcc-3v3-tv-usb"; > +}; > + > ®_aldo2 { > regulator-always-on; > regulator-min-microvolt = <1800000>; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel