From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBBE4C46CD3 for ; Tue, 26 Dec 2023 17:05:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1Br0Ay0nefsrCxLFss3fXFu4GBHLSqOhHvvQBus3JYI=; b=n3oqTbUiLcOk9X QszkcT5GwRbOyXHLQH/I6ghM9+FVjakIK+8GwDRyWKXinHkjzF25rosuICi1GiTenpmvNOH3ZRNSq +4dS8joQ2RkTdRzJzZzHA6GsgCJqsVck7v+kan1q9Ai6nMndKXt6XYXfyWMKDhlIs6aH2VN9pD36O SLx6iw62fDmUA07U+e+5LVw4B6qeTZ/+638W5O7pShDiGwYTUIYk9qh12khFxzbmQK6gNCy9n+KmY A0cp8VA2zKXmgI8Ll80TlP0wHeZXYHwoMlcWUMmbksDhj2JGxh1JRbbEe0+28KbMehvUzb30fM872 iCyCrgCvQYHZDiemu9WA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rIArm-00DIEI-01; Tue, 26 Dec 2023 17:05:18 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rIAri-00DIDh-2R for linux-arm-kernel@lists.infradead.org; Tue, 26 Dec 2023 17:05:16 +0000 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-5553cc31f1cso462061a12.1 for ; Tue, 26 Dec 2023 09:05:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703610312; x=1704215112; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=COhuaSnIAGJCtWBOds7qZex5HBBn0HSMvsViTbnhv0E=; b=T2JwBaJ9GD+IfGz8mFRzohVJ3UluUStbOoXXNSqZRArvXyyigvxcEpvCdzJ1bqcxrk 4Q0JkWR/LK+DPOBcftyBKGMmpCJtJmEieqTfJOE8Q69oKF+W5b6AhvAcEABxnw3SvZdE 7Ur2k8WmeMpvBCvNpXfZtoV7KCf+CHKB6HYf2dSSL0hwmHnj7Q+mvtNH/5zSJqVpT31O lqiLGseWBaF8Rm5/WjJTJDWEU7imBniOkeRpyyX+UN5U4e6G+pkIGC3VNtERO28vFqjL wWG4huXAERrVN72JV8GMUqTIaBS463ZlPGRBt4ii0Vk3iuorGgP/iqqH0AiJ2QwF/Lrz B1Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703610312; x=1704215112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=COhuaSnIAGJCtWBOds7qZex5HBBn0HSMvsViTbnhv0E=; b=h3scNVurKvpXXGeeiwh5uKqBWtSCRgWqbUBcIU2Ag08IbUP77yJ6xHz/UWC2KuVBua 607bPSYSQmDDGS31Txwa3PTJON17dT4v7q3MQEhBxEAJ7+KL+lXkk/1g2vxLgiTNWyLe cm8G97chFMCpZ3SC2QqfLhEULM6jc3UxfovfJ27kuvc+z/iMMZu4jIgGzg1LjNkV+ywu hF3VL8GZQLDW2u/J00aIFGOHjg7REzHItGpVR07JOL958trAY3dP0K+pw1F9GY88EC1I +9RpJrajIgpu9cpayikpl0DhIcZibUJlJKhk1xBqGO7aWq3h3MOmFJXgEDbYvLEAVQr3 KXEQ== X-Gm-Message-State: AOJu0YxCPbbA1g5OQ1rTV8aeXdg6NN3eR8eFu0JLtvACsQ/BD4VYmY4j u0nmagKznQHCjM6N6vCylF8= X-Google-Smtp-Source: AGHT+IHCnYr/oKelM3fbBjtgXRroiTOhdkKQ01PSERrVoviHPoOEbYtCDr/ucndouUf4+I9wIPLXwA== X-Received: by 2002:a17:906:57c1:b0:a23:54aa:311b with SMTP id u1-20020a17090657c100b00a2354aa311bmr8174950ejr.34.1703610312230; Tue, 26 Dec 2023 09:05:12 -0800 (PST) Received: from skbuf ([188.25.255.53]) by smtp.gmail.com with ESMTPSA id h22-20020a17090791d600b00a22fb8901c4sm5950374ejz.12.2023.12.26.09.05.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 09:05:12 -0800 (PST) Date: Tue, 26 Dec 2023 19:05:09 +0200 From: Vladimir Oltean To: Andrew Lunn Cc: Jagan Teki , Heiner Kallweit , "Andrew F. Davis" , Florian Fainelli , linux-kernel , netdev@vger.kernel.org, Michael Nazzareno Trimarchi , Ioana Ciornei , Shawn Guo , linux-arm-kernel , Fabio Estevam Subject: Re: PHY issue with SJA1105Q/DP84849I Design Message-ID: <20231226170509.vysmvg6soz54xekb@skbuf> References: <20231222145100.sfcuux7ayxtxgogo@skbuf> <20231226153055.4yihsmu6kiak6hkf@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231226_090514_800791_FD5142FD X-CRM114-Status: GOOD ( 17.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 26, 2023 at 06:00:17PM +0100, Andrew Lunn wrote: > > The code which should have prevented this from happening is in > > phy_attach_direct(): > > > > if (phydev->attached_dev) { > > dev_err(&dev->dev, "PHY already attached\n"); > > err = -EBUSY; > > goto error; > > } > > The problem might be dsa_shared_port_phylink_register(): > > err = phylink_of_phy_connect(dp->pl, port_dn, 0); > if (err && err != -ENODEV) { > pr_err("could not attach to PHY: %d\n", err); > goto err_phy_connect; > } > > return 0; > > Since it is not -ENODEV, it just keep going. > > Andrew "Shared" ports are DSA and CPU ports, the report is on a user port. There, if phylink_of_phy_connect() fails, we try dsa_user_phy_connect(), but only if the driver provides a ds->user_mii_bus, which sja1105 does not. So the failure should be nice and clean. It might be worth posting a full boot log though, since this is really strange. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel