From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9ED5C46CD4 for ; Fri, 29 Dec 2023 23:57:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nw9pnv7SI3O642GojCh4CYZTtkm81Gh84on0acyRSfU=; b=DZLu4/Z9k4gyko tY76ai+Q8iN4HYQpjona7whShvMTUCAqMdQ7O1oQBc8EfOBTUuezfVJMvNkfZ7rICyG46xf+fN6T9 ApDWrcgNRmgk4DNkaRlsF8q4qXacs1ZlQvYNMwvk6TMQFqHUdWSMnqUilZLHgUEBIPqxc59pDykqt xNtCSlaO3XmQ8MRVa1Z/yHIhlOLmSjd4GVBrMYJYcY1PUrRgjG5z+Q3NqS8iEMvtocu+AoBtS5QF2 9cN0YxPUgVu3CaenQn89WYtPDz/O+92HaY0T147ULBGOgC3LzpBh3earzbRhaNqOq11A5Ovg7O5oN RjSb5v0mmZ/6vR5kTKWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rJMiV-001oDz-1u; Fri, 29 Dec 2023 23:56:39 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rJMiT-001oDT-0L for linux-arm-kernel@lists.infradead.org; Fri, 29 Dec 2023 23:56:38 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1F632FEC; Fri, 29 Dec 2023 15:57:23 -0800 (PST) Received: from minigeek.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BDA0E3F641; Fri, 29 Dec 2023 15:56:34 -0800 (PST) Date: Fri, 29 Dec 2023 23:56:12 +0000 From: Andre Przywara To: Jisheng Zhang Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Icenowy Zheng , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: arm: sunxi: Add Sipeed Longan Module 3H and Longan Pi 3H Message-ID: <20231229235612.2c37e1fa@minigeek.lan> In-Reply-To: <20231228145647.1470-2-jszhang@kernel.org> References: <20231228145647.1470-1-jszhang@kernel.org> <20231228145647.1470-2-jszhang@kernel.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.2.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231229_155637_193574_56BEECB6 X-CRM114-Status: GOOD ( 15.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 28 Dec 2023 22:56:46 +0800 Jisheng Zhang wrote: Hi Jisheng, thanks for sending this, seems to be on time with the release of the hardware. Don't see that very often! > Add name & compatible for the Sipeed Longan Module 3H and Longan PI 3H > board. > > Signed-off-by: Jisheng Zhang > --- > Documentation/devicetree/bindings/arm/sunxi.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml > index 11c5ce941dd7..34d8ae484e01 100644 > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml > @@ -835,6 +835,13 @@ properties: > - const: sinlinx,sina33 > - const: allwinner,sun8i-a33 > > + - description: Sipeed Longan Pi 3H board for the Sipeed Longan Module 3H > + items: > + - enum: > + - sipeed,longan-pi-3h The picture of the SoM suggests that it cannot be used on its own, so for anything usable we will always need both the SoM and some board. Definitely we do for this board. So please follow the example for the SoPine (or other SoM based boards), and just name all three names as "const" items. Cheers, Andre > + - const: sipeed,longan-module-3h > + - const: allwinner,sun50i-h618 > + > - description: SourceParts PopStick v1.1 > items: > - const: sourceparts,popstick-v1.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel