From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10D6DC47077 for ; Tue, 2 Jan 2024 15:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tIcAR4wBeWUAhlMPiDjH17jibcLS6LFz3uzlTC1YXLs=; b=mU5PD20NsTouEL NAdi4iYLQQcxXDaHyMRu8rEJjqm5AGWzDWf4eq5UYWtTERIfmDzaHIyZf45kCKH2NT+IUC8ZhhwVe O3Cd0QIU3PMKPCtGavg96CgDPOZmTJqCS33aITYY5NVny1+dRdNHaUwZ6k7uSGp20Aieo1rCN1u1B 5ppDWxEJtvg8brL/QQHtAtJ1wUoQ2FXK2aKSsAFediymr/X+4Fcx1f4nmq7orLLGYHU7+NPwpWvWC zd/NnIk/jhKnfZRFUwmOL9g03i/fFj/VU5OM0CQUThzD34qoLnysU2kP46bQ5YuRc+HzYrtmf6ogm +yAhY2B/JvQsNPPgAQBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rKh9h-008QUi-1W; Tue, 02 Jan 2024 15:58:13 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rKh9e-008QTz-2N for linux-arm-kernel@lists.infradead.org; Tue, 02 Jan 2024 15:58:12 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6B4366118C; Tue, 2 Jan 2024 15:58:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59CF8C433C7; Tue, 2 Jan 2024 15:58:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704211089; bh=gsBgM/SJ5swumfn/cuVueJtKXK9nInmvCfn1DD55G2Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hjRyV52srkWcrFMd9p6aHkxAvUkzcYMa2RWZPQEwAxmGtHyGaxQfbs/v+npGYXCIT 6nX2lufBMDX4XoQhsQIv3YMo83DPc7XTW6iQxSMAtrHgte2dIP9cs8JqwUgLlfs3GI jWftuUfNohpebYe4v9tCOTdbHFT68XR6Py2mOIOe4nvsGeCrnBy0LNTaZkYHuSOxR4 6m+BzIMKiNgZjYj5yIR2bhYJEiPR4TAFyxM4iCtkctS/vsmGAHD9Y3UujEG4K9Xe7g XKAc+BDP9yNbZSWpiaiCX4tyELCk89f/wvAvpjyazjxFg0jj+n1BaftTt/JPatw0pn kte5fS0oDAw2g== Date: Tue, 2 Jan 2024 07:58:07 -0800 From: Jakub Kicinski To: fuyao Cc: Jernej =?UTF-8?B?xaBrcmFiZWM=?= , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Paolo Abeni , Chen-Yu Tsai , Samuel Holland , Maxime Coquelin , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, =?UTF-8?B?6bqm5YGl5bu6?= Subject: Re: [PATCH] gmac: sun8i: r40: add gmac tx_delay support Message-ID: <20240102075807.1a4cac92@kernel.org> In-Reply-To: References: <2370947.NG923GbCHz@jernej-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240102_075810_871256_BB802BDD X-CRM114-Status: GOOD ( 14.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 21 Dec 2023 15:16:54 +0800 fuyao wrote: > I don't see it in the user manual also. > > it works fine in 100M, but it doesn't work good in 1G without tx_delay > in my board. > > Read the sdk from allwinner I found in: > > https://sourcegraph.com/github.com/tinalinux/linux-3.10/-/blob/arch/arm/boot/dts/sun8iw11p1.dtsi?L1826 > https://sourcegraph.com/github.com/tinalinux/linux-3.10@r40-v1.y/-/blob/drivers/net/ethernet/allwinner/sunxi-gmac.c?L877 > > And I add it to my board, it works fine. > > So, I think it may be exist register but not documented. Unless Allwinner can chime in we should at least document the situation clearly in the commit message (incl. what HW+config was tested, exactly) and add a comment in the code? -- pw-bot: cr _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel