From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F40BCC47079 for ; Tue, 2 Jan 2024 08:14:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QVndRwMxzS0GlWZ7Wl0+47Snnd3jJ2qY/UQ6bFz52P0=; b=AMCX1iQxl1LTKS Bw+HeW47k/RQNkuiBJTwy8NihOPXX3b1gkl0IOa+ir3ThSyWnR2I/yaYiyWvKZrHlsR1/b6UNLupw 7hN9nJ2+RYtjenQuHWJhkspUvtFjkgZQnJgUSi8NeYg3/pIK4Qa/n7LJCT9inFXRFV/kDvFI8nr7E CtoRONNXOMUvnM/5q8EL7fQ/1GDX1XZS7VrQNmbbbhtPwP/TX0lrLc3sS3zsT2kUdxEW5sPM/3L82 7sO22WB7jelOC+O60ZRxJ1AKkhT5DHVgNB3wipCqoS8lFMdz1Xct+WRQ33uDn98r7hOtH/9+juUD7 ubBERmYhAyNTkKVno4WA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rKZun-007Jiq-3B; Tue, 02 Jan 2024 08:14:21 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rKZui-007Jfr-1h for linux-arm-kernel@lists.infradead.org; Tue, 02 Jan 2024 08:14:18 +0000 Received: by mail-pj1-x1036.google.com with SMTP id 98e67ed59e1d1-28cb3bc3fe7so1520295a91.1 for ; Tue, 02 Jan 2024 00:14:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1704183254; x=1704788054; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PajgPkTBW3iluxw6UIGchSAnGs+6/xnB8PBfDDEr3ic=; b=PSAUG20//ffekE0e9P12QDxnCFND3DS9e98hfaZqR2HpKzl64tSnDLcjtpzml2OSdN UVKdie/VkRk35YMMc/NKB6mTurZYJovwmdKfo9nVgJSYYTqLo7lVai/sT0vecrYmVQYx dIKKbzzsPby+yOR74H6rP/CD3JYbbFAdL3ln0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704183254; x=1704788054; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PajgPkTBW3iluxw6UIGchSAnGs+6/xnB8PBfDDEr3ic=; b=Xxwj/GpB59ECLbnW14GN7SXoPRzjqAPTSy75s+4pdb2qVhkFt/PbeqPIf9gMFt/HFL JsQW/QXXZzqYmvINc9fg9R/SWbr5Ap56CceWrrQmGR76Xb78wLS68dl0jy96ygH8zZDD FL+qwsM7HQATvE1fOHSMCfPWdefVuO0bwQ/P5wgWY4r3+f4pcBEuQ0LmdXvrAVJtuEN5 4SpW4mwVDul+4dquR6w5lbSkWkmMSKxgQH8rPk9LvKaUK1rQunh6JIjE3+3cQ4D9Hc3Q jDTclPi/rzt0q3/acxpZINA14sr3aEQLx99vgYiXr9/O+WlMeqa8Zyw5QALhOQmsqnQp fdrg== X-Gm-Message-State: AOJu0YxToVHJ8Rmis3rlqWW+pV2ne8fAQu6LdwDBvKSwZg8S5P3kKPSa VKjYMJKHT4SQFgV2nm4/L+gw1sTOpaI1w2fouXJ15FQVQw== X-Google-Smtp-Source: AGHT+IHM8m/BePVX0/O3CWysvzAhUtnB/CIoZmU5nwbrD+ulhjtycO32Co8Ei+LLUe/a9ppmi+uE8A== X-Received: by 2002:a17:90a:1506:b0:28b:efda:98da with SMTP id l6-20020a17090a150600b0028befda98damr20446795pja.17.1704183254545; Tue, 02 Jan 2024 00:14:14 -0800 (PST) Received: from treapking.tpe.corp.google.com ([2401:fa00:1:10:232c:f04:85bb:a34c]) by smtp.gmail.com with ESMTPSA id f3-20020a17090a638300b0028c8149ac6esm12640074pjj.42.2024.01.02.00.14.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 00:14:14 -0800 (PST) From: Pin-yen Lin To: Michael Turquette , Stephen Boyd , Matthias Brugger , AngeloGioacchino Del Regno Cc: Pin-yen Lin , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Weiyi Lu , linux-mediatek@lists.infradead.org Subject: [PATCH v2 2/2] clk: mediatek: mt8183: Enable need_runtime_pm on mt8183-mfgcfg Date: Tue, 2 Jan 2024 16:12:53 +0800 Message-ID: <20240102081402.1226795-2-treapking@chromium.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240102081402.1226795-1-treapking@chromium.org> References: <20240102081402.1226795-1-treapking@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240102_001416_563329_E55BC7BE X-CRM114-Status: GOOD ( 12.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org mt8183-mfgcfg has a mutual dependency with genpd during the probing stage, so enable need_runtim_pm to prevent a deadlock in the following call stack: CPU0: genpd_lock --> clk_prepare_lock genpd_power_off_work_fn() genpd_lock() generic_pm_domain::power_off() clk_unprepare() clk_prepare_lock() CPU1: clk_prepare_lock --> genpd_lock clk_register() __clk_core_init() clk_prepare_lock() clk_pm_runtime_get() genpd_lock() Do a runtime PM get at the probe function to make sure clk_register() won't acquire the genpd lock. Fixes: acddfc2c261b ("clk: mediatek: Add MT8183 clock support") Signed-off-by: Pin-yen Lin --- (no changes since v1) drivers/clk/mediatek/clk-mt8183-mfgcfg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/mediatek/clk-mt8183-mfgcfg.c b/drivers/clk/mediatek/clk-mt8183-mfgcfg.c index ba504e19d420..62d876e150e1 100644 --- a/drivers/clk/mediatek/clk-mt8183-mfgcfg.c +++ b/drivers/clk/mediatek/clk-mt8183-mfgcfg.c @@ -29,6 +29,7 @@ static const struct mtk_gate mfg_clks[] = { static const struct mtk_clk_desc mfg_desc = { .clks = mfg_clks, .num_clks = ARRAY_SIZE(mfg_clks), + .need_runtime_pm = true, }; static const struct of_device_id of_match_clk_mt8183_mfg[] = { -- 2.43.0.472.g3155946c3a-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel