From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2196C47074 for ; Fri, 5 Jan 2024 00:16:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=27pGzCvKZQKCyy4P/qX0ngEWN5IhpYz3bdRd6Gi5JSk=; b=ObV55cssd6/UOu Vd91tIVmZplirs1XdZnE/rbCqzZzX31vO29HKO/PP+Afl8yH7WJnNCcV63C0IHFZ5UBY3aB5byyMx pQkQSUn7bfPB/yFI4CJxHJT/F/4NPzewbIEqs7efCtjjedFWTbQAAYY9R5WLiW6OIu+IsNd7pqFvE +kLKQfV3Sw0EdmiUC9OuCnYZEZ9wGiyANMcxf1KnJ7bNyu3v8czNp0UhQF8e33Saey/1fbv2ZoHnO PzBfGxdl96ajx1+iz9IUAFZ2pozTFIP2fhMjPD++Jgt4WX5RD3bH132Je1gwgDdDCh8wsPVXsLvf9 3068l1KukbPDgRzkPiww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rLXsR-00FdMn-2Y; Fri, 05 Jan 2024 00:15:55 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rLWvs-00FRnw-1w for linux-arm-kernel@bombadil.infradead.org; Thu, 04 Jan 2024 23:15:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=eiE2TKfmykx81/foxCGLJoWMsu28AsRQpu/mBCPsgws=; b=OtN/S/EUITwGUEGMHMtG6X9iOt 4p+tNbXHKDizC5yxLLJGXNcDWcA4FsPNTpywazW5sJWsdSreb7ew80lBMJKJJJVtcDFH+xW8fZtU2 fgRQRBtiOOiHIILZ66hkaXRHZC/zZkNSZuaItdWDAUTd1zMQA11JQCsZKnANLEQbj8e6beywEKSzs hAvTr70nSQOj6Z4xWXW8CHYGhcPJCwD9PK8U5r7xQhs5t902MVcsSEmVo89++4UruY9oaGKrxRbxI szkF2409fZQmC+yu2MjXnid/ursDZYgCwG+81IXGHDJasUMTbKUiSP4EpqNzVzz5p6sw/xLkU+kDA SzpJ8jTA==; Received: from ams.source.kernel.org ([145.40.68.75]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rLWvp-0069VR-17 for linux-arm-kernel@lists.infradead.org; Thu, 04 Jan 2024 23:15:23 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id B12B6B81B9D; Thu, 4 Jan 2024 23:15:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31AD6C433C8; Thu, 4 Jan 2024 23:15:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704410118; bh=8+oSXyf0wqRRdg8sq1ozcCxD/jtiSJlDv+ZMldve9G0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sEZCQLn0iqKE1N3rT6Ql9/kVD9IKcrDzs7hCYNntqjHx8Cw4zDpFyFborzSnwlJhS fMHuPa1qp+wBYUKHPyz/Sm1df6gyfxra24auI87wCtfYET39jH2gHnLOZD6qNWIuh9 yuRPsROw2t+iejPRZukvyeoWWaN0RYsXer41olwjd0F9NfugfzPEoPSgzPaEv8+0V2 maBj7V4QJCx0Dy2Of+MUAjkfdiUPKsps1HoqZal0HgXqkmKTVOPppUDD0/ROpUjmKV /DoOfp9MuCEYyIhjKflgJ5CU+xZA6dNQTyLFyMguSykA4z5/3zJf9usnCyEItGf26Y hx3lWBBqE5C0g== Date: Thu, 4 Jan 2024 15:15:16 -0800 From: Jakub Kicinski To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Jesse Brandeburg , Jonathan Corbet , Marek =?UTF-8?B?QmVow7pu?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman Subject: Re: [PATCH net-next v5 05/13] net: ethtool: Allow passing a phy index for some commands Message-ID: <20240104151516.5f424dbf@kernel.org> In-Reply-To: <20231221180047.1924733-6-maxime.chevallier@bootlin.com> References: <20231221180047.1924733-1-maxime.chevallier@bootlin.com> <20231221180047.1924733-6-maxime.chevallier@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240104_231521_525604_651F655D X-CRM114-Status: UNSURE ( 9.24 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 21 Dec 2023 19:00:38 +0100 Maxime Chevallier wrote: > @@ -20,6 +21,7 @@ const struct nla_policy ethnl_header_policy[] = { > .len = ALTIFNAMSIZ - 1 }, > [ETHTOOL_A_HEADER_FLAGS] = NLA_POLICY_MASK(NLA_U32, > ETHTOOL_FLAGS_BASIC), > + [ETHTOOL_A_HEADER_PHY_INDEX] = NLA_POLICY_MIN(NLA_U32, 1), > }; > > const struct nla_policy ethnl_header_policy_stats[] = { > @@ -28,6 +30,7 @@ const struct nla_policy ethnl_header_policy_stats[] = { > .len = ALTIFNAMSIZ - 1 }, > [ETHTOOL_A_HEADER_FLAGS] = NLA_POLICY_MASK(NLA_U32, > ETHTOOL_FLAGS_STATS), > + [ETHTOOL_A_HEADER_PHY_INDEX] = NLA_POLICY_MIN(NLA_U32, 1), > }; You should define (copy/paste) a new header policy and use it only for commands which actually make use of the PHY index. That's why we have separate copies already for stats. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel