From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D70DEC47074 for ; Thu, 4 Jan 2024 23:47:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1gPbtOc52ktaNBZ5jYHkiOHTvyKYUUp6JVc47qLW8Zc=; b=TFpfrGZxO5/sCO cUkQogEEX6lKjrKBQX5GEpaRKAYTTEUnBlcQqWz48YV1ycchNCw15B2u35R7It27zCEc1vMoqQn6T pT6TeoOfJ+psXYLTWo2VD2a9Aa2MVRoo7uS6xKfPhv8swS/Xe4ecfUo2MwmZmfk2RvbNGVLtIwKQl nVR387glaM8tyGV8/IcrERZRSjGplgv1MM0byH0I3waKbzQmuGZYnwMPnwKyxQ22HROsiqKX9gPR9 bG9xIOvGi5WW6DuYQ1FvM0U7zPxyExlnCk9IrW2DuM0SJxqAtJ1l2wC8iAJG0H+ZJWbuY73BygrY8 f/sJCJWiPCG6HThHyDog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rLXQw-00Fb3n-1q; Thu, 04 Jan 2024 23:47:30 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rLXQt-00Fb2t-1Q for linux-arm-kernel@lists.infradead.org; Thu, 04 Jan 2024 23:47:28 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 2E9E6CE1D20; Thu, 4 Jan 2024 23:47:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A670C433C8; Thu, 4 Jan 2024 23:47:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704412043; bh=PKIw7BcJSaypMdJBg4Njrm2KDvBf+rMCYg3A6sDiTso=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ETsWmnpXUD3YDF1/knK0iVgwfDEAd+0bbjKyhZVngHgIUVmY6Sn/gKd9Ywe14MFbD A4DMvgtg0jCAWwjYBsUDw3xz84vHRASIuvKF7+Nv+LTuOeBKEoPKWv05UGFrH653FH bRsHNqUExinSE4AjKApcCoYe2TbFPnfhQ1lv+KKowy8iPpqrWve2vqcBl29Tt8qtlw //G5vz7unSwEuIQlN7u9sdd9xCCLWPoHHYMgqsvrEoORUVomx80cViMgy41VGDkXNo VPiYxkCSVxdoGRNRkt3KLIFCR4SP8nRGVmzne8NO+U2QkVACLx3IOs1hTcKqUfac+W Uh3BK0vAKQjdw== Date: Thu, 4 Jan 2024 15:47:21 -0800 From: Jakub Kicinski To: Maxime Chevallier Cc: "Russell King (Oracle)" , patchwork-bot+netdevbpf@kernel.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, andrew@lunn.ch, edumazet@google.com, pabeni@redhat.com, linux-arm-kernel@lists.infradead.org, christophe.leroy@csgroup.eu, herve.codina@bootlin.com, f.fainelli@gmail.com, hkallweit1@gmail.com, vladimir.oltean@nxp.com, kory.maincent@bootlin.com, jesse.brandeburg@intel.com, corbet@lwn.net, kabel@kernel.org, piergiorgio.beruto@gmail.com, o.rempel@pengutronix.de, nicveronese@gmail.com, horms@kernel.org Subject: Re: [PATCH net-next v5 00/13] Introduce PHY listing and link_topology tracking Message-ID: <20240104154721.192694a8@kernel.org> In-Reply-To: <20240103153336.424dcfe3@device-28.home> References: <20231221180047.1924733-1-maxime.chevallier@bootlin.com> <170413442779.30948.3175948839165575294.git-patchwork-notify@kernel.org> <20240102105125.77751812@kernel.org> <20240103153336.424dcfe3@device-28.home> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240104_154727_659472_AF5F0936 X-CRM114-Status: UNSURE ( 7.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 3 Jan 2024 15:33:36 +0100 Maxime Chevallier wrote: > I think this could help in reviewing the overall design and identifying > any glaring issue with this. The netlink handling looks a bit wobbly to me. I commented best I could in the 20min I had to look at this code :( I think it'd be best to revert, if you don't mind, because reviewing incremental fixes will get even harder. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel