From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59D77C47073 for ; Thu, 4 Jan 2024 15:32:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Iuw8l2yuLb/EussOKai8UEK0b4AOQM8ZbPB0f3lD8gw=; b=MA+r0ygFeEndo1 vpfiIrRPqHmJD1Jgx+1OU82V3lPWSv/g15uqnht5Aau9DWbrEsgUOSihTWVwVnqDBwx93Ee+rbMRW IVN6Th3SgFP1p4qgF55w5apw4+5Gi5y5fUKqUWuMYdV1kAWrq3qDef2zWExUxCq7ArSfQTqQAd6Uk 3bi2p3wOyL4MYb4UdKNFxkIMiSmSIrzhQbTGw23YTONMcQDOF72rlxDZrBCslYQP0bViwl/dgIOKK C6+i10EV64Ceyb6COJbDqwlwUA4RwacHiLudHr4hHclph5WQL4N21m4AZEkF68xfboLIYJjC+zBbe XeeeSkZXHkHrB9idgZAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rLPhz-00EVY6-0t; Thu, 04 Jan 2024 15:32:35 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rLPhw-00EVXk-32 for linux-arm-kernel@lists.infradead.org; Thu, 04 Jan 2024 15:32:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 81695B819F7; Thu, 4 Jan 2024 15:32:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F40FC433C8; Thu, 4 Jan 2024 15:32:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1704382349; bh=iRcnDzw86EyKYKY1HoAEg7+jfRyhxW/8AJdQHVxMfJQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=krvH+vf8alA3OYa9PQUG7prv2rIPcjCZ5kuHMdK+c3PwsxStQqpFCYmx5FNFsyai3 2i/0ruoxpd1QKA7a2mNiz8Q/gPGO9rhfdj9HEFN1mP+HmO/IAN7ocfDmJVt4+nGnZw zWZobXaYovtT3amQgB9QV2L45gttEzKA9QzuBn+0= Date: Thu, 4 Jan 2024 16:32:27 +0100 From: Greg KH To: Tudor Ambarus Cc: peter.griffin@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, conor+dt@kernel.org, andi.shyti@kernel.org, alim.akhtar@samsung.com, jirislaby@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, arnd@arndb.de, semen.protsenko@linaro.org, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v2 04/12] tty: serial: samsung: prepare for different IO types Message-ID: <2024010432-taco-moneyless-53e2@gregkh> References: <20231228125805.661725-1-tudor.ambarus@linaro.org> <20231228125805.661725-5-tudor.ambarus@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231228125805.661725-5-tudor.ambarus@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240104_073233_155481_57A7A25C X-CRM114-Status: GOOD ( 20.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 28, 2023 at 12:57:57PM +0000, Tudor Ambarus wrote: > GS101's Connectivity Peripheral blocks (peric0/1 blocks) which > include the I3C and USI (I2C, SPI, UART) only allow 32-bit > register accesses. If using 8-bit register accesses, a SError > Interrupt is raised causing the system unusable. > > Instead of specifying the reg-io-width = 4 everywhere, for each node, > the requirement should be deduced from the compatible. > > Prepare the samsung tty driver to allow IO types different than > UPIO_MEM. ``struct uart_port::iotype`` is an unsigned char where all > its 8 bits are exposed to uapi. We can't make NULL checks on it to > verify if it's set, thus always set it from the driver's data. > > Signed-off-by: Tudor Ambarus > --- > v2: new patch > > drivers/tty/serial/samsung_tty.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c > index 66bd6c090ace..97ce4b2424af 100644 > --- a/drivers/tty/serial/samsung_tty.c > +++ b/drivers/tty/serial/samsung_tty.c > @@ -72,6 +72,7 @@ struct s3c24xx_uart_info { > const char *name; > enum s3c24xx_port_type type; > unsigned int port_type; > + unsigned char iotype; > unsigned int fifosize; > unsigned long rx_fifomask; > unsigned long rx_fifoshift; Is there a reason you are trying to add unused memory spaces to this structure for no valid reason? I don't think you could have picked a more incorrect place in there to add this :) Please fix. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel