From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF93CC46CD2 for ; Sat, 6 Jan 2024 13:45:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TzI31/VQUww2wnT4jv7nlLhwX7CEEmF4wcojPjkmMIg=; b=S28V60bZytsEnp zg/+Zj79toRLQ1wcwJPqOTekJBquBHj3OhstvR6l916PLiz4V+iHF7cRalBHy7hNO+DPFjfudI4hR 7d9ITJNYTlpyuR21TuLd9gYx4vSlYkES/cMaT7EqrLJUz6IZyR8uzIyvtaxf/LuArzlk4IiaMhoAp V0SkUt5wOw0LaAh/OPZqzJsU5Gda9WJhKO06kCApFAVYuWc5TOMsWsY4WjdO3vGpTvIeW5/cg4/fL oDCSv0bxIsAJCkZ4SvulNnBjjhHY0FdWYQ1YPeVdh+/EZmo2vD4n/VEc1RnWrCufOd7CnTrHfIgvM GGhRyEk7wGxNeWXi+EPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rM6zB-001Mwb-0J; Sat, 06 Jan 2024 13:45:13 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rM6z7-001Mw9-2H for linux-arm-kernel@lists.infradead.org; Sat, 06 Jan 2024 13:45:11 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 28C42CE009E; Sat, 6 Jan 2024 13:44:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E25DC433C8; Sat, 6 Jan 2024 13:44:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704548692; bh=LGTgxqxOygh5aZyaHTVaAXCaHAb1TgYqmHjpgTu+vxE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cAPouwFlk2AbtAYvTqNWM0ye8BbaDcT7xGzym7PBoOLzwOY01g0dbHaOfyl5U/BNR YXSzMXUKnqOvEGTN+x5lXvyX/lomuZ70V7HTwONzIXivr058OTvzcQ4a4s8B2loMjO scyethOCVcql1VB6e7hnjRNtdD7t6+pMun9zSY2iDjlul5dDd7ibTyqTV+TC+gRxsp fLLMYwxpLWti6fImpFnWstKl7PKokfMc0lTujk8SbKx0zhO+BDmRVGMMppps7YXf/b AfQNSJRqi/n6/VMk8anE6dG5uSBdmKEvDjkjKVed661CiW40B2LIJRp1bMxKBcOXbq iqNDmV8KwOxFw== Date: Sat, 6 Jan 2024 22:44:50 +0900 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Bjorn Helgaas , Thippeswamy Havalige , Bharat Kumar Gogada Cc: Michal Simek , Lorenzo Pieralisi , Rob Herring , Dan Carpenter , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] PCI: xilinx-xdma: Fix uninitialized symbols in xilinx_pl_dma_pcie_setup_irq() Message-ID: <20240106134450.GB3450972@rocinante> References: <20240106133433.41130-1-kwilczynski@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240106133433.41130-1-kwilczynski@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240106_054509_934204_DA3C3705 X-CRM114-Status: GOOD ( 10.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, > The error paths that follow calls to the devm_request_irq() functions > within the xilinx_pl_dma_pcie_setup_irq() reference an uninitialized > symbol each that also so happens to be incorrect. > > Thus, fix this omission and reference the correct variable when invoking > a given dev_err() function following an error. > > This problem was found using smatch via the 0-DAY CI Kernel Test service: > > drivers/pci/controller/pcie-xilinx-dma-pl.c:638 xilinx_pl_dma_pcie_setup_irq() error: uninitialized symbol 'irq'. > drivers/pci/controller/pcie-xilinx-dma-pl.c:645 xilinx_pl_dma_pcie_setup_irq() error: uninitialized symbol 'irq'. We need to get this fixed, so I applied this change to controller/xilinx, as I would like to ensure that it will be included with the rest of the changes for the 6.8 release [1/1] PCI: xilinx-xdma: Fix uninitialized symbols in xilinx_pl_dma_pcie_setup_irq() https://git.kernel.org/pci/pci/c/7aa5f8fcd6d9 Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel