From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90F22C47077 for ; Sun, 7 Jan 2024 03:04:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8q7EHvk7oM4cRy3jIQXEgBUYDYQqwGa+UYFWgKXfPqM=; b=uEqALpkeWoqv5r iiwVKlsIu3t3kl4+ZGSN0QT0LuPmSAiNI+X7x8vmYE8+RTGaPiUtx3FlrysY97K5sPm3UzRVlpNyC ouOUcS7+TaG8tQDkLdwWS+OGsfivUQf/E0RWYWpPpZayYrvbQwkRWuDGdp+Tn+P8dgg05aLY9iJcu JafOw6IDdHXuL8S6xWlirWdFEHm+nq/rlEZjnqwXHkzK8Yqu6CLDgPhRc0hh5iTyilmRLQgwX9oPO LTQIRojmHQV0RhRyHplQCsJHUTCdQBk4dVuUmsNwUsyEoYPSIBpY16lGA/MkDclFjd759RCMIL+y1 tTraJ0+OHKnoaEOZ7Hnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rMJSh-002G74-14; Sun, 07 Jan 2024 03:04:31 +0000 Received: from mail-io1-xd33.google.com ([2607:f8b0:4864:20::d33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rMJSe-002G6S-0s for linux-arm-kernel@lists.infradead.org; Sun, 07 Jan 2024 03:04:29 +0000 Received: by mail-io1-xd33.google.com with SMTP id ca18e2360f4ac-7ba9f24acf8so57396339f.2 for ; Sat, 06 Jan 2024 19:04:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704596665; x=1705201465; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=7sp8lR8fVruy7aXHQIvUQeGshhQgsSFVGSZnezGwNmY=; b=h1fKjLeHtSyeUoZkTCKX6MK9/S1VTHTJvNcFf7O/hDzcDMrNDVr/giSRQbQYFSTP2c 5aqnrX3rTwvwnKnTv7ilqP5UfEGgXLNFmD1XCtsraP4euW1pIimgFkr2t7v73JkiXuls 1wL9noCyDGRFI3eqtv7Jn/9P1AsSwxdqVzQGXE5JF3JBJi2LDNq1sAekllfYiJcRfrmt xA9RDePwGe8nXRlvT8hTJOI9aCSVgDnozbIgN8Dth8yiRrd7x+7VVwFrV1NrDdfEUVBl D2roAioM3JJJxO+Itpuzhvnl3z68yuhPPP10yxHNrRQdncB0Kxt6fmL68mtxzr2HlalM sPDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704596665; x=1705201465; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7sp8lR8fVruy7aXHQIvUQeGshhQgsSFVGSZnezGwNmY=; b=jZ4PgY+0T2PE/nnuFryoPCv/V4D9pKl4hyByW7uhOebirgP39Cv6PJC68Wp4nBrHu8 y6c1MuuMoxz1AYoLR2B7l2w62PmOiVNgZgvycnwou4SUP8/NlclLJJxbgzM+FgBMa7dP 1FBNmpRGS6hAEa2UQ7v3F7fB07MhSwBX+0AoxP5s/qXrg7jL3oi8S67/43HHVAWGaOin MqMAD0IXhJcm6g6aXiK4JyjOcBIpDdqJU+OZzLFqoEJXJ8ZT6BHozmyYSYi4hK2z5idi a79fsdBkLaUEDRIMlyWjX+GaJ2Ugo1XkyjDHm5sFW8x9W/f6TPQ/aaMRavFzhqzMdYxB heXw== X-Gm-Message-State: AOJu0YyLprw8l6yAz9H0xcP79z+M9NJVbAy3+miorIEb7a29ZS6HxuBR E9x3nLncTn5/FXhANBtV8IUiG1ayoBxo X-Google-Smtp-Source: AGHT+IHsUozNDbBUGhK/kPkGuJeGxcsOSl6NPAeIm7KmHBeMpMshWboxNlelX33jnj6MU0MpT+m+kg== X-Received: by 2002:a05:6e02:32c3:b0:35f:ff8c:7a31 with SMTP id bl3-20020a056e0232c300b0035fff8c7a31mr3406835ilb.65.1704596665631; Sat, 06 Jan 2024 19:04:25 -0800 (PST) Received: from thinkpad ([103.197.115.97]) by smtp.gmail.com with ESMTPSA id w22-20020a1709029a9600b001d35223d0besm3675636plp.251.2024.01.06.19.04.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jan 2024 19:04:25 -0800 (PST) Date: Sun, 7 Jan 2024 08:34:18 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: krzysztof.kozlowski@linaro.org, bhelgaas@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com, helgaas@kernel.org, hongxing.zhu@nxp.com, imx@lists.linux.dev, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, kw@linux.com, l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, robh@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org Subject: Re: [PATCH v7 02/16] PCI: imx6: Simplify phy handling by using by using IMX6_PCIE_FLAG_HAS_PHY Message-ID: <20240107030418.GB3416@thinkpad> References: <20231227182727.1747435-1-Frank.Li@nxp.com> <20231227182727.1747435-3-Frank.Li@nxp.com> <20240106153323.GE2512@thinkpad> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240106_190428_321875_69AE1E99 X-CRM114-Status: GOOD ( 28.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCBKYW4gMDYsIDIwMjQgYXQgMTE6NTA6MjhBTSAtMDUwMCwgRnJhbmsgTGkgd3JvdGU6 Cj4gT24gU2F0LCBKYW4gMDYsIDIwMjQgYXQgMDk6MDM6MjNQTSArMDUzMCwgTWFuaXZhbm5hbiBT YWRoYXNpdmFtIHdyb3RlOgo+ID4gT24gV2VkLCBEZWMgMjcsIDIwMjMgYXQgMDE6Mjc6MTNQTSAt MDUwMCwgRnJhbmsgTGkgd3JvdGU6Cj4gPiA+IFJlZmFjdG9ycyB0aGUgcGh5IGhhbmRsaW5nIGxv Z2ljIGluIHRoZSBpbXg2IFBDSSBkcml2ZXIgYnkgYWRkaW5nCj4gPiA+IElNWDZfUENJRV9GTEFH X0hBU19QSFkgYml0bWFzayBkZWZpbmUgZm9yIGRydmRhdGE6OmZsYWdzLgo+ID4gPiAKPiA+ID4g VGhlIGRydmRhdGE6OmZsYWdzIGFuZCBhIGJpdG1hc2sgZW5zdXJlcyBhIGNsZWFuZXIgYW5kIG1v cmUgc2NhbGFibGUKPiA+ID4gc3dpdGNoLWNhc2Ugc3RydWN0dXJlIGZvciBoYW5kbGluZyBwaHku Cj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBGcmFuayBMaSA8RnJhbmsuTGlAbnhwLmNvbT4K PiA+ID4gLS0tCj4gPiA+IAo+ID4gPiBOb3RlczoKPiA+ID4gICAgIENoYW5nZSBmcm9tIHY0IHRv IHY1Ogo+ID4gPiAgICAgLSBub25lLCBLZWVwIElNWDZfUENJRV9GTEFHX0hBU19QSFkgdG8gaW5k aWNhdGUgZHRzIG1pc21hdGNoIHdoZW4gcGxhdGZvcm0KPiA+ID4gICAgIHJlcXVpcmUgcGh5IHN1 cHBwb3J0Lgo+ID4gPiAgICAgCj4gPiA+ICAgICBDaGFuZ2UgZnJvbSB2MSB0byB2MzoKPiA+ID4g ICAgIC0gbm9uZQo+ID4gPiAKPiA+ID4gIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1p bXg2LmMgfCAyMyArKysrKysrKysrKysrKysrLS0tLS0tLQo+ID4gPiAgMSBmaWxlIGNoYW5nZWQs IDE2IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpLWlteDYuYyBiL2RyaXZlcnMvcGNpL2Nv bnRyb2xsZXIvZHdjL3BjaS1pbXg2LmMKPiA+ID4gaW5kZXggNTBkOWZhYWExN2Y3MS4uNGQ2MjAy NDlmM2Q1MiAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNp LWlteDYuYwo+ID4gPiArKysgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktaW14Ni5j Cj4gPiA+IEBAIC02MCw2ICs2MCw5IEBAIGVudW0gaW14Nl9wY2llX3ZhcmlhbnRzIHsKPiA+ID4g ICNkZWZpbmUgSU1YNl9QQ0lFX0ZMQUdfSU1YNl9QSFkJCQlCSVQoMCkKPiA+ID4gICNkZWZpbmUg SU1YNl9QQ0lFX0ZMQUdfSU1YNl9TUEVFRF9DSEFOR0UJQklUKDEpCj4gPiA+ICAjZGVmaW5lIElN WDZfUENJRV9GTEFHX1NVUFBPUlRTX1NVU1BFTkQJCUJJVCgyKQo+ID4gPiArI2RlZmluZSBJTVg2 X1BDSUVfRkxBR19IQVNfUEhZCQkJQklUKDMpCj4gPiAKPiA+IEV2ZXJ5IFBDSWUgc2V0dXAgcmVx dWlyZXMgUEhZIGZvciBpdHMgb3BlcmF0aW9uLiBQZXJoYXBzIHlvdSBhcmUgcmVmZXJyaW5nIHRv Cj4gPiBleHRlcm5hbCBQSFk/IElmIHNvLCBwbGVhc2UgcmVuYW1lIHRoaXMgdG8gSU1YNl9QQ0lF X0ZMQUdfSEFTX0VYVF9QSFkuCj4gCj4gQWN0dWFsbHksIGl0IG1lYW5zIHVzZSBwaHkgZHJpdmVy LiBIb3cgYWJvdXQgdXNpbmcgSU1YNl9QQ0lFX0hBU19QSFlEUlY/Cj4gCgpBaCwgb2suIFllcywg dGhpcyBtYWtlcyBzZW5zZS4KCi0gTWFuaQoKPiA+IAo+ID4gPiArCj4gPiA+ICsjZGVmaW5lIGlt eDZfY2hlY2tfZmxhZyhwY2ksIHZhbCkgICAgIChwY2ktPmRydmRhdGEtPmZsYWdzICYgdmFsKQo+ ID4gPiAgCj4gPiA+ICAjZGVmaW5lIElNWDZfUENJRV9NQVhfQ0xLUyAgICAgICA2Cj4gPiA+ICAK PiA+ID4gQEAgLTEyNzcsNiArMTI4MCwxMyBAQCBzdGF0aWMgaW50IGlteDZfcGNpZV9wcm9iZShz dHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ID4gPiAgCWlmIChyZXQpCj4gPiA+ICAJCXJl dHVybiByZXQ7Cj4gPiA+ICAKPiA+ID4gKwlpZiAoaW14Nl9jaGVja19mbGFnKGlteDZfcGNpZSwg SU1YNl9QQ0lFX0ZMQUdfSEFTX1BIWSkpIHsKPiA+IAo+ID4gSU1PLCB3ZSB3b3VsZCBub3QgbmVl ZCB0aGVzZSBraW5kIG9mIGNoZWNrcyBpbiB0aGUgZHJpdmVyIGlmIHRoZSBEVCBiaW5kaW5nIGlz Cj4gPiBwcm9wZXJseSB2YWxpZGF0ZWQgdXNpbmcgc2NoZW1hLiBCdXQgZm9sa3MgYWx3YXlzIHdh bnQgdG8gdmFsaWRhdGUgImJyb2tlbiBEVCIKPiA+IGluIHRoZSBkcml2ZXJzIDooCj4gPiAKPiA+ IEJ1dCBJJ20gZmluZSB3aXRoIHRoaXMgY2hlY2sgZm9yIG5vdyBzaW5jZSBub3QgZXZlcnlvbmUg YWdyZWUgd2l0aCBhYm92ZS4KPiA+IAo+ID4gLSBNYW5pCj4gPiAKPiA+ID4gKwkJaW14Nl9wY2ll LT5waHkgPSBkZXZtX3BoeV9nZXQoZGV2LCAicGNpZS1waHkiKTsKPiA+ID4gKwkJaWYgKElTX0VS UihpbXg2X3BjaWUtPnBoeSkpCj4gPiA+ICsJCQlyZXR1cm4gZGV2X2Vycl9wcm9iZShkZXYsIFBU Ul9FUlIoaW14Nl9wY2llLT5waHkpLAo+ID4gPiArCQkJCQkgICAgICJmYWlsZWQgdG8gZ2V0IHBj aWUgcGh5XG4iKTsKPiA+ID4gKwl9Cj4gPiA+ICsKPiA+ID4gIAlzd2l0Y2ggKGlteDZfcGNpZS0+ ZHJ2ZGF0YS0+dmFyaWFudCkgewo+ID4gPiAgCWNhc2UgSU1YN0Q6Cj4gPiA+ICAJCWlmIChkYmlf YmFzZS0+c3RhcnQgPT0gSU1YOE1RX1BDSUUyX0JBU0VfQUREUikKPiA+ID4gQEAgLTEzMDYsMTEg KzEzMTYsNiBAQCBzdGF0aWMgaW50IGlteDZfcGNpZV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2 aWNlICpwZGV2KQo+ID4gPiAgCQkJcmV0dXJuIGRldl9lcnJfcHJvYmUoZGV2LCBQVFJfRVJSKGlt eDZfcGNpZS0+YXBwc19yZXNldCksCj4gPiA+ICAJCQkJCSAgICAgImZhaWxlZCB0byBnZXQgcGNp ZSBhcHBzIHJlc2V0IGNvbnRyb2xcbiIpOwo+ID4gPiAgCj4gPiA+IC0JCWlteDZfcGNpZS0+cGh5 ID0gZGV2bV9waHlfZ2V0KGRldiwgInBjaWUtcGh5Iik7Cj4gPiA+IC0JCWlmIChJU19FUlIoaW14 Nl9wY2llLT5waHkpKQo+ID4gPiAtCQkJcmV0dXJuIGRldl9lcnJfcHJvYmUoZGV2LCBQVFJfRVJS KGlteDZfcGNpZS0+cGh5KSwKPiA+ID4gLQkJCQkJICAgICAiZmFpbGVkIHRvIGdldCBwY2llIHBo eVxuIik7Cj4gPiA+IC0KPiA+ID4gIAkJYnJlYWs7Cj4gPiA+ICAJZGVmYXVsdDoKPiA+ID4gIAkJ YnJlYWs7Cj4gPiA+IEBAIC0xNDQ0LDEzICsxNDQ5LDE1IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qg aW14Nl9wY2llX2RydmRhdGEgZHJ2ZGF0YVtdID0gewo+ID4gPiAgCX0sCj4gPiA+ICAJW0lNWDhN TV0gPSB7Cj4gPiA+ICAJCS52YXJpYW50ID0gSU1YOE1NLAo+ID4gPiAtCQkuZmxhZ3MgPSBJTVg2 X1BDSUVfRkxBR19TVVBQT1JUU19TVVNQRU5ELAo+ID4gPiArCQkuZmxhZ3MgPSBJTVg2X1BDSUVf RkxBR19TVVBQT1JUU19TVVNQRU5EIHwKPiA+ID4gKwkJCSBJTVg2X1BDSUVfRkxBR19IQVNfUEhZ LAo+ID4gPiAgCQkuZ3ByID0gImZzbCxpbXg4bW0taW9tdXhjLWdwciIsCj4gPiA+ICAJCS5jbGtf bmFtZXMgPSB7InBjaWVfYnVzIiwgInBjaWUiLCAicGNpZV9hdXgifSwKPiA+ID4gIAl9LAo+ID4g PiAgCVtJTVg4TVBdID0gewo+ID4gPiAgCQkudmFyaWFudCA9IElNWDhNUCwKPiA+ID4gLQkJLmZs YWdzID0gSU1YNl9QQ0lFX0ZMQUdfU1VQUE9SVFNfU1VTUEVORCwKPiA+ID4gKwkJLmZsYWdzID0g SU1YNl9QQ0lFX0ZMQUdfU1VQUE9SVFNfU1VTUEVORCB8Cj4gPiA+ICsJCQkgSU1YNl9QQ0lFX0ZM QUdfSEFTX1BIWSwKPiA+ID4gIAkJLmdwciA9ICJmc2wsaW14OG1wLWlvbXV4Yy1ncHIiLAo+ID4g PiAgCQkuY2xrX25hbWVzID0geyJwY2llX2J1cyIsICJwY2llIiwgInBjaWVfYXV4In0sCj4gPiA+ ICAJfSwKPiA+ID4gQEAgLTE0NjIsMTIgKzE0NjksMTQgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBp bXg2X3BjaWVfZHJ2ZGF0YSBkcnZkYXRhW10gPSB7Cj4gPiA+ICAJfSwKPiA+ID4gIAlbSU1YOE1N X0VQXSA9IHsKPiA+ID4gIAkJLnZhcmlhbnQgPSBJTVg4TU1fRVAsCj4gPiA+ICsJCS5mbGFncyA9 IElNWDZfUENJRV9GTEFHX0hBU19QSFksCj4gPiA+ICAJCS5tb2RlID0gRFdfUENJRV9FUF9UWVBF LAo+ID4gPiAgCQkuZ3ByID0gImZzbCxpbXg4bW0taW9tdXhjLWdwciIsCj4gPiA+ICAJCS5jbGtf bmFtZXMgPSB7InBjaWVfYnVzIiwgInBjaWUiLCAicGNpZV9hdXgifSwKPiA+ID4gIAl9LAo+ID4g PiAgCVtJTVg4TVBfRVBdID0gewo+ID4gPiAgCQkudmFyaWFudCA9IElNWDhNUF9FUCwKPiA+ID4g KwkJLmZsYWdzID0gSU1YNl9QQ0lFX0ZMQUdfSEFTX1BIWSwKPiA+ID4gIAkJLm1vZGUgPSBEV19Q Q0lFX0VQX1RZUEUsCj4gPiA+ICAJCS5ncHIgPSAiZnNsLGlteDhtcC1pb211eGMtZ3ByIiwKPiA+ ID4gIAkJLmNsa19uYW1lcyA9IHsicGNpZV9idXMiLCAicGNpZSIsICJwY2llX2F1eCJ9LAo+ID4g PiAtLSAKPiA+ID4gMi4zNC4xCj4gPiA+IAo+ID4gCj4gPiAtLSAKPiA+IOCuruCuo+Cuv+CuteCu o+CvjeCuo+CuqeCvjSDgrprgrqTgrr7grprgrr/grrXgrq7gr40KCi0tIArgrq7grqPgrr/grrXg rqPgr43grqPgrqngr40g4K6a4K6k4K6+4K6a4K6/4K614K6u4K+NCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==