From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C890DC46CD2 for ; Tue, 9 Jan 2024 03:50:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m94SWrY4Mc//4Y5YFltA7RjIsmsJn4G7sGrzTPF8A1s=; b=4aG/lVkrzwOUsV bKHbxR+g805s87UJF7RJeepw9ggqsZ431QHVwtyCi/U8CeIwi9fVvae7V9eH1jenHKy3PHBJbqlCT CnOQynMAhWfpSofMpEJHZxflHoWm2KAzZMl9Sw3FBDZtpEBSQjwamb5inzyrq1To4Ew86Rei+LaZS br6/zLOWCMLUgrcPTi57zE1lSLQDDnPCw/ZS3NLcbmJaGKXYiC296pqcqWTWFylW3lDKKp6CF2UXB 0ygLihSfLrZw9tHl9NLRFMjFbCWQJhVobogGS6yj0LOcUvxPaKfVkjdUT3sRP9iSyzKEnB2qgB57O TGQZLpAhoVbL3/RYjyFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rN37W-006pZp-01; Tue, 09 Jan 2024 03:49:42 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rN37S-006pXv-33 for linux-arm-kernel@lists.infradead.org; Tue, 09 Jan 2024 03:49:40 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 5B99FB8187A; Tue, 9 Jan 2024 03:49:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E683C433C7; Tue, 9 Jan 2024 03:49:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704772176; bh=E7n3TsSbDbPjksIo7Blfyj5PMO2YbKS3wrQ5fGz2R58=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p5oQ67HLaZNAn2pkjhJthcuHCjkORdRQi6bEPqRrA1Qcq2RAIj57r33jmI6jQZSDW exuoE4K/MQxFN+ICDKaMa8DkSQWHfbaDIXio7RvHToQy53SFbDOhBQ16bBA/Hg43Hj lkr6+xAh8ws7o4/N7h2yUodZsQRcjdknnNJDVB1SdDgelKp9sGi2MesaiFn/dOFO6g lnQ1uzFrLiwIlPOT8MEeVZWTWG9QZX/XJknxrvgXdd3nZm6b0eblDTYmRu2HSXl0ZJ ZBgxvVgg65tnpc2j0F3k6JZ8/kFvZhKulGuGNZk1gz2uCURttiTJc2aCEttkKpSl6N AxQbY3dGHGtjg== Received: (nullmailer pid 2606875 invoked by uid 1000); Tue, 09 Jan 2024 03:49:34 -0000 Date: Mon, 8 Jan 2024 20:49:34 -0700 From: Rob Herring To: Manivannan Sadhasivam Cc: Frank Li , krzysztof.kozlowski@linaro.org, bhelgaas@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com, helgaas@kernel.org, hongxing.zhu@nxp.com, imx@lists.linux.dev, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, kw@linux.com, l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org Subject: Re: [PATCH v7 04/16] dt-bindings: imx6q-pcie: Add linux,pci-domain as required for iMX8MQ Message-ID: <20240109034934.GA2602612-robh@kernel.org> References: <20231227182727.1747435-1-Frank.Li@nxp.com> <20231227182727.1747435-5-Frank.Li@nxp.com> <20240107031506.GC3416@thinkpad> <20240107051917.GG3416@thinkpad> <20240107062911.GP3416@thinkpad> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240107062911.GP3416@thinkpad> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240108_194939_266472_C94DE270 X-CRM114-Status: GOOD ( 31.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jan 07, 2024 at 11:59:11AM +0530, Manivannan Sadhasivam wrote: > On Sun, Jan 07, 2024 at 12:38:10AM -0500, Frank Li wrote: > > On Sun, Jan 07, 2024 at 10:49:17AM +0530, Manivannan Sadhasivam wrote: > > > On Sat, Jan 06, 2024 at 11:47:36PM -0500, Frank Li wrote: > > > > On Sun, Jan 07, 2024 at 08:45:06AM +0530, Manivannan Sadhasivam wrote: > > > > > On Wed, Dec 27, 2023 at 01:27:15PM -0500, Frank Li wrote: > > > > > > iMX8MQ have two pci controllers. Adds "linux,pci-domain" as required > > > > > > proptery for iMX8MQ to indicate pci controller index. > > > > > > > > > > > > > > > > property > > > > > > > > > > > This adjustment paves the way for eliminating the hardcoded check on the > > > > > > base register for acquiring the controller_id. > > > > > > > > > > > > ... > > > > > > if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR) > > > > > > imx6_pcie->controller_id = 1; > > > > > > ... > > > > > > > > > > > > The controller_id is crucial and utilized for certain register bit > > > > > > positions. It must align precisely with the controller index in the SoC. > > > > > > An auto-incremented ID don't fit this case. The DTS or fuse configurations > > > > > > may deactivate specific PCI controllers. > > > > > > > > > > > > > > > > You cannot change the binding for the sake of driver. But you can make this > > > > > change in other way. See below... > > > > > > > > > > > Signed-off-by: Frank Li > > > > > > --- > > > > > > > > > > > > Notes: > > > > > > Change from v5 to v6 > > > > > > - rework commit message to explain why need required and why auto increase > > > > > > id not work > > > > > > > > > > > > Change from v4 to v5 > > > > > > - new patch at v5 > > > > > > > > > > > > .../bindings/pci/fsl,imx6q-pcie-common.yaml | 11 +++++++++++ > > > > > > 1 file changed, 11 insertions(+) > > > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml > > > > > > index d91b639ae7ae7..8f39b4e6e8491 100644 > > > > > > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml > > > > > > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml > > > > > > @@ -265,6 +265,17 @@ allOf: > > > > > > - const: apps > > > > > > - const: turnoff > > > > > > > > > > > > + - if: > > > > > > + properties: > > > > > > + compatible: > > > > > > + contains: > > > > > > + enum: > > > > > > + - fsl,imx8mq-pcie > > > > > > + - fsl,imx8mq-pcie-ep > > > > > > > > > > "linux,pci-domain" is a generic property. So you cannot make it required only > > > > > for certain SoCs. > > > > > > > > Sorry, why not? there are many generic property. > > > > > > > > > > It doesn't make sense to make it required only for specific SoCs since it is not > > > specific to any SoC. You can make it required for all. > > > > More than 2 controller need require "linux,pci-domain". > > > > But this property is applicable to single controller also. Not really. I don't understand the issue. Some SoCs have a dependency on the numbering and need the property. Others don't. They just want (but don't need) consistent numbering. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel