From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08C76C46CD2 for ; Tue, 9 Jan 2024 04:08:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zFv6I2g4GfNlnhEmTwI23CiAyNBoiqirSTpXYY56u8Q=; b=4ZX/zl3td3JyGY Z0CF0QCHc7DTldVpGRaaa2IRC5064T7xPJCXdbnHiZBw5Xq4LY0uHruq/GFg1MqLdVOhq9QWgbXru +SPVDEFE0lLIUqlTjoAKjfSb4aw5O5+bhUP2//GNfBdhnGWn4n56aui+8Tt/0wwhPzddD6A3ZP8dW xpvIJ7MiwunaIvnI37c1NqXgVdsNI8AU2OUIUWtjtawkPIcPRoOU0afYdEc9d/WOqOvF+g/E6hXYE 25J08JRNvBiZwrG0EtXM+c/XmRTmenr1U9OGp6TwO5kfDGgoRL2nhP4Yg6U9qaVBdZ0F5atVSJRXe yCnkv45UGcHdpf6b+qrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rN3Ph-006sWw-39; Tue, 09 Jan 2024 04:08:29 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rN3Pf-006sWY-04 for linux-arm-kernel@lists.infradead.org; Tue, 09 Jan 2024 04:08:28 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id E3EFEB802C5; Tue, 9 Jan 2024 04:08:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7E27C433C7; Tue, 9 Jan 2024 04:08:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704773304; bh=vxop1P25YkHwxNMZhEWdRl+DWP4xO/rIKADXrQ5Hngo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WX+OQrBQS/WTPVQ3qaPUBruOwgpd5pTj3QZw4+gnvxMJk/4UsT8fs/A4wmq36KwhF Odo7nBB7DDouyGwDMXNzgB8HFk/f6dC4od4zdqQLnjjVy4HzCOz4C2Led8B0/2zp4v 8sB3Twr4VGKfnVPTce5JRDSyH2rJjwYPm5Zt3+AA5OZWR4xJfcLa9CDnX57EaP8CUv kNoxgteqMU3krWxw2vTRCAZaES5adyTLGAWFym5YU6dXC5WnAvRMUrTI4d7tVr+DE8 0VzUPLINE6wSA5Y8suH/TbIRah9IpGJTOH5ekd5Fz8CXRHX4BpmDbtFwhfgtoy8ui8 62pRsMrhFNufg== Received: (nullmailer pid 2627564 invoked by uid 1000); Tue, 09 Jan 2024 04:08:22 -0000 Date: Mon, 8 Jan 2024 21:08:22 -0700 From: Rob Herring To: Peter Griffin Cc: Tudor Ambarus , krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, conor+dt@kernel.org, andi.shyti@kernel.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, arnd@arndb.de, semen.protsenko@linaro.org, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v2 01/12] dt-bindings: clock: google,gs101-clock: add PERIC0 clock management unit Message-ID: <20240109040822.GB2619804-robh@kernel.org> References: <20231228125805.661725-1-tudor.ambarus@linaro.org> <20231228125805.661725-2-tudor.ambarus@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240108_200827_198942_FC8E102F X-CRM114-Status: GOOD ( 25.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 08, 2024 at 02:18:21PM +0000, Peter Griffin wrote: > Hi Tudor, > > On Thu, 28 Dec 2023 at 12:58, Tudor Ambarus wrote: > > > > Add dt-schema documentation for the Connectivity Peripheral 0 (PERIC0) > > clock management unit. > > > > Reviewed-by: Sam Protsenko > > Signed-off-by: Tudor Ambarus > > --- > > v2: > > - fix comments as per Sam's suggestion and collect his R-b tag > > - Rob's suggestion of renaming the clock-names to just "bus" and "ip" > > was not implemented as I felt it affects readability in the driver > > and consistency with other exynos clock drivers. I will happily update > > the names in the -rc phase if someone else has a stronger opinion than > > mine. > > > > It would be good to get Krzysztof and Robs view on whether they agree > with the above rationale or whether they would still like to see the > names updated. > > Personally I like the consistency, grepability and the fact the > current name encodes whether it is a gate, divider into the name. > Seeing 'sss' or 'ip' as a clock name in the driver code doesn't tell > you a lot without having to then cross reference with the dts. > > Is there some rationale and/or benefit behind having the shorter > names? The only thing I could think of is trying to partially re-use > this file on future SoCs like gs201 which might be clocked > differently, but then these exynos clock drivers seem to be SoC > specific anyway. The point of -names is to identify one entry from another in the list. Having the name of the block is just redundant. I like consistency, but not when it's a pattern we don't want. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel