From: Will Deacon <will@kernel.org>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: linux-arm-kernel@lists.infradead.org,
Catalin Marinas <catalin.marinas@arm.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Arnd Bergmann <arnd@arndb.de>,
"peterz@infradead.org" <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
Nhat Pham <nphamcs@gmail.com>, Palmer Dabbelt <palmer@sifive.com>,
Sohil Mehta <sohil.mehta@intel.com>,
Miklos Szeredi <mszeredi@redhat.com>,
Christian Brauner <brauner@kernel.org>,
Ian Kent <raven@themaw.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM64: Update __NR_compat_syscalls for statmount/listmount
Date: Tue, 9 Jan 2024 09:50:51 +0000 [thread overview]
Message-ID: <20240109095050.GA12915@willie-the-truck> (raw)
In-Reply-To: <20240109010906.429652-1-florian.fainelli@broadcom.com>
On Mon, Jan 08, 2024 at 05:09:04PM -0800, Florian Fainelli wrote:
> Commit d8b0f5465012 ("wire up syscalls for statmount/listmount") added
> two new system calls to arch/arm64/include/asm/unistd32.h but forgot to
> update the __NR_compat_syscalls number, thus causing the following build
> failures:
>
> ./arch/arm64/include/asm/unistd32.h:922:24: error: array index in initializer exceeds array bounds
> 922 | #define __NR_statmount 457
> | ^~~
> arch/arm64/kernel/sys32.c:130:34: note: in definition of macro '__SYSCALL'
> 130 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
> | ^~
>
> Bump up the number by two to accomodate for the new system calls added.
>
> Fixes: d8b0f5465012 ("wire up syscalls for statmount/listmount")
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---
> arch/arm64/include/asm/unistd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/include/asm/unistd.h b/arch/arm64/include/asm/unistd.h
> index 531effca5f1f..b63f870debaf 100644
> --- a/arch/arm64/include/asm/unistd.h
> +++ b/arch/arm64/include/asm/unistd.h
> @@ -39,7 +39,7 @@
> #define __ARM_NR_compat_set_tls (__ARM_NR_COMPAT_BASE + 5)
> #define __ARM_NR_COMPAT_END (__ARM_NR_COMPAT_BASE + 0x800)
>
> -#define __NR_compat_syscalls 457
> +#define __NR_compat_syscalls 459
> #endif
>
> #define __ARCH_WANT_SYS_CLONE
> --
> 2.34.1
Acked-by: Will Deacon <will@kernel.org>
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-09 9:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 1:09 [PATCH] ARM64: Update __NR_compat_syscalls for statmount/listmount Florian Fainelli
2024-01-09 9:50 ` Will Deacon [this message]
2024-01-09 17:05 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240109095050.GA12915@willie-the-truck \
--to=will@kernel.org \
--cc=arnd@arndb.de \
--cc=brauner@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=florian.fainelli@broadcom.com \
--cc=geert@linux-m68k.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mszeredi@redhat.com \
--cc=nphamcs@gmail.com \
--cc=palmer@sifive.com \
--cc=peterz@infradead.org \
--cc=raven@themaw.net \
--cc=rick.p.edgecombe@intel.com \
--cc=sohil.mehta@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox