From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FB85C46CD2 for ; Tue, 9 Jan 2024 18:24:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1VxeO7NMYK+m1UdKZ6XXk7iS5WeraOgxMvx6AcqRkBg=; b=qJ9kJcaZGHpYwc 943Ygh/jiASGPbhIIM4bxAywCljXvleiAt/OlEWbMAUmttlUMefFaT8t31HT8tKmR32hwki0kZ4Cj fczjlPxXgV6FsWljgPFZDpeoAPbKJTnQ0m/U/1XNrx86W89/wenyYQ7kab8ZacTlXj87Z5yUcebVm D536hwgxDQA9fZmyDR5zCTovqPIIjLQ188qC+IzQucLqQGKcvCgsA1pYUlIN2c96pwWVtRBx9BE0c CJgnjrKYtzZpgofz7nZSzUehYqBkBIZxLet+s/cuDpLHba+CkYCa8Y3ZI5R7xozw6x6m6tQYd6mPr eGkt8aZ+DNIXKapXQBng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNGm8-0099Ba-06; Tue, 09 Jan 2024 18:24:32 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNGm4-0099Ab-2R for linux-arm-kernel@lists.infradead.org; Tue, 09 Jan 2024 18:24:30 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D3839CE19BF; Tue, 9 Jan 2024 18:24:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8EACC43390; Tue, 9 Jan 2024 18:24:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704824666; bh=ORDcydzdI4WqaEgEC+N/AtgYAWYt9TwVHCyZQqFzwkk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FqfcIAoytbaSHClCub3k0jxMaJaWgOI2FQwjtJxIXh7UOH/yf0c7CdjZhcio43w8y SesPyKyuELEZu5lUvXZklbsirfkcCwTXGK/7Em8UUraHtVQvdplLUU7GmEAEVk+uBr rndLi8n+vAFCO3qvf9msB4n87DUT/S8pZdlnlMkgb0BMmte9VDshXW++Na/DC4io8H /ABNg6zrJonmMswfLb92UHFPVuKY2qwTHcd/z7qcoN4x3G4N+ZAPRDQ+EW+Eym9qSE DpIcz+KvZzUWyOkdsSIT/C3/uOHcGfGa4Dfgof0hebZMpLpFnQUviGPidOmuPJqH0/ b23KHxffuk75g== Received: (nullmailer pid 2900974 invoked by uid 1000); Tue, 09 Jan 2024 18:24:20 -0000 Date: Tue, 9 Jan 2024 12:24:20 -0600 From: Rob Herring To: Frank Li Cc: krzysztof.kozlowski@linaro.org, bhelgaas@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com, helgaas@kernel.org, hongxing.zhu@nxp.com, imx@lists.linux.dev, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, kw@linux.com, l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, manivannan.sadhasivam@linaro.org, s.hauer@pengutronix.de, shawnguo@kernel.org Subject: Re: [PATCH v8 04/16] dt-bindings: imx6q-pcie: Add linux,pci-domain as required for iMX8MQ Message-ID: <20240109182420.GA2896319-robh@kernel.org> References: <20240108232145.2116455-1-Frank.Li@nxp.com> <20240108232145.2116455-5-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240108232145.2116455-5-Frank.Li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240109_102428_991835_7D465862 X-CRM114-Status: GOOD ( 13.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 08, 2024 at 06:21:33PM -0500, Frank Li wrote: > iMX8MQ have two pci controllers. Adds "linux,pci-domain" as required > property for iMX8MQ to indicate pci controller index. > > This adjustment paves the way for eliminating the hardcoded check on the > base register for acquiring the controller_id. > > ... > if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR) > imx6_pcie->controller_id = 1; > ... > > The controller_id is crucial and utilized for certain register bit > positions. It must align precisely with the controller index in the SoC. > An auto-incremented ID don't fit this case. The DTS or fuse configurations > may deactivate specific PCI controllers. > > Signed-off-by: Frank Li > --- > > Notes: > Keep current to avoid DTB_CHECK warning. After these patch merged. Will add > linux,pci-domain in all dts file. So dt-binding can remove condition check > by soc. Please don't. No need to make required everywhere. Besides not needed, it is an ABI break. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel