From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12907C3DA6E for ; Wed, 10 Jan 2024 08:54:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=4pL98kv+/be1OuToXxlJpHopovX26SFpBZccuBwBxeE=; b=3YNxHSOJlWEI0N FDY9cqnv3s0MKUb8S8lHs1kCfxB3sa/2Ygjn510lAvKBY6zph7vlF6QXYFjjVJsczq7hRQeycx5X+ ebf0gAVdrEqCvfzFk8imKI7+rU+or5brHXMocREjFijIUkNnx8oRuw5ODvSYWGn8q5GjxO0gHZoJt pyN57FIWS6LecWzgaDGob/gQfOdNPinUoYhwhoNz5lRpuQ1zIJpT4IDO0dOlqfqiy3Ve0pwKrvz4j WsHsznYTzArDxuKLjkNat1oU++WAIMy7KUG9nnAJ0+k9pRwsAHQLPOtjOIEbNoc0CgNDVN5VRsYvu Vl7FnS0xtpHJ4UsEk4Cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNULj-00Anb9-2v; Wed, 10 Jan 2024 08:54:11 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNULh-00Anag-0M for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2024 08:54:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1704876849; x=1736412849; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=vRqfUgQM2sdsBN1AvA0sRgBKLLZlTpAYMa60phHuMfk=; b=hRdZ7AG5ewc2r3lDFmTUJ/3eBi8uJYnn2KYXY4BGXpGXvF3uMV02v7I4 p8t7L/CYHGjiW5MkLW4lWG8+UTRjYyalpbWd7xO/A4l3MTPLIX9RFqDbv AQ7j+CnjtWzayiSO+idYCwRgvKzNOI7a0Qxp775UQLuc3XCexGZgYfrb+ OG7Q6EGvXaEtjDhMy03Y10d0sxmB7dpN1ThQdb48vzzvAnvRktkewaABi JckwRIy99AEubaxZjWUkMXcuBCgrxorgN15UE67MepfRkcXM/7pBBQfhd LZh8FqoStSlpduc/bA93xkZvYE7U51tszjZftQKv/q5YMbZjtdwNsSUxw A==; X-IronPort-AV: E=Sophos;i="6.04,184,1695679200"; d="scan'208";a="34822720" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 10 Jan 2024 09:54:06 +0100 Received: from steina-w.tq-net.de (steina-w.tq-net.de [10.123.53.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 1345A280075; Wed, 10 Jan 2024 09:54:06 +0100 (CET) From: Alexander Stein To: Mark Brown , Shawn Guo , Sascha Hauer , Fabio Estevam Cc: Alexander Stein , Pengutronix Kernel Team , NXP Linux Team , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 1/1] spi: spi-imx: Use dev_err_probe for failed DMA channel requests Date: Wed, 10 Jan 2024 09:54:03 +0100 Message-Id: <20240110085403.457089-1-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_005409_535665_77717DBB X-CRM114-Status: GOOD ( 13.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org If dma_request_chan() fails, no error is shown nor any information is shown in /sys/kernel/debug/devices_deferred if -EPROBE_DEFER is returned. Use dev_err_probe to fix both problems. Signed-off-by: Alexander Stein --- Sorry, I lost sight of the replies from v1 series. I'll address Fabio's concern here instead. It's true that running spi-imx with SDMA is valid. But if provided DMA channels are not available, aka -EPROBE_DEFER, there is no information why so. This can simply be seen by disabling the sdma1 node on imx8mp: $ cat /sys/kernel/debug/devices_deferred 30820000.spi 30830000.spi 30840000.spi There is no indication what is wrong/missing here. There is also no fallback to pio mode. This patch addresses this by setting the defer probe reason. Changes in v2: * Rebase to next-20240110 [1] https://lore.kernel.org/all/CAOMZO5CcD5iDkaempdxnQHx1fAgnXAmMq_0MdEq5wNgOLHcMuw@mail.gmail.com/ drivers/spi/spi-imx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index 272bc871a848b..546cdce525fc5 100644 --- a/drivers/spi/spi-imx.c +++ b/drivers/spi/spi-imx.c @@ -1344,7 +1344,7 @@ static int spi_imx_sdma_init(struct device *dev, struct spi_imx_data *spi_imx, controller->dma_tx = dma_request_chan(dev, "tx"); if (IS_ERR(controller->dma_tx)) { ret = PTR_ERR(controller->dma_tx); - dev_dbg(dev, "can't get the TX DMA channel, error %d!\n", ret); + dev_err_probe(dev, ret, "can't get the TX DMA channel!\n"); controller->dma_tx = NULL; goto err; } @@ -1353,7 +1353,7 @@ static int spi_imx_sdma_init(struct device *dev, struct spi_imx_data *spi_imx, controller->dma_rx = dma_request_chan(dev, "rx"); if (IS_ERR(controller->dma_rx)) { ret = PTR_ERR(controller->dma_rx); - dev_dbg(dev, "can't get the RX DMA channel, error %d\n", ret); + dev_err_probe(dev, ret, "can't get the RX DMA channel!\n"); controller->dma_rx = NULL; goto err; } -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel