Re: [PATCH 14/18] tty: serial: samsung: return bool for s3c24xx_serial_console_txrdy()

Sam Protsenko
2024-01-16T18:55:28Z

On Wed, Jan 10, 2024 at 4:25 AM Tudor Ambarus <tudor.ambarus@linaro.org> wrote:
>
> s3c24xx_serial_console_txrdy() returned just 0 or 1 to indicate whether
> the TX is empty or not. Change its return type to bool.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> drivers/tty/serial/samsung_tty.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> index 63e993bed296..37c0ba2a122c 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> @@ -2183,7 +2183,7 @@ static const struct dev_pm_ops s3c24xx_serial_pm_ops = {
>
> static struct uart_port *cons_uart;
>
> -static int
> +static bool
> s3c24xx_serial_console_txrdy(struct uart_port *port, u32 ufcon)
> {
> const struct s3c24xx_uart_info *info = s3c24xx_port_to_info(port);
> @@ -2193,13 +2193,13 @@ s3c24xx_serial_console_txrdy(struct uart_port *port, u32 ufcon)
> /* fifo mode - check amount of data in fifo registers... */
>
> ufstat = rd_regl(port, S3C2410_UFSTAT);
> - return (ufstat & info->tx_fifofull) ? 0 : 1;
> + return !(ufstat & info->tx_fifofull);
> }
>
> /* in non-fifo mode, we go and use the tx buffer empty */
>
> utrstat = rd_regl(port, S3C2410_UTRSTAT);
> - return (utrstat & S3C2410_UTRSTAT_TXE) ? 1 : 0;
> + return !!(utrstat & S3C2410_UTRSTAT_TXE);

Again, personally I think !! is just clutters the code here, as the
function already returns bool. Other than that:

Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>

> }
>
> static bool
> --
> 2.43.0.472.g3155946c3a-goog