[PATCH 11/18] tty: serial: samsung: don't compare with zero an if (bitwise expression)

Tudor Ambarus
2024-01-10T10:22:16Z

Since an if tests the numeric value of an expression, certain coding
shortcuts can be used. The most obvious one is writing
if (expression)
instead of
if (expression != 0)

Since our case is a bitwise expression, it's more natural and clear to
use the ``if (expression)`` shortcut.

Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
---
drivers/tty/serial/samsung_tty.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
index dbbe6b8e3ceb..f2413da14b1d 100644
--- a/drivers/tty/serial/samsung_tty.c
+++ b/drivers/tty/serial/samsung_tty.c
@@ -988,8 +988,7 @@ static unsigned int s3c24xx_serial_tx_empty(struct uart_port *port)
u32 ufcon = rd_regl(port, S3C2410_UFCON);

if (ufcon & S3C2410_UFCON_FIFOMODE) {
- if ((ufstat & info->tx_fifomask) != 0 ||
- (ufstat & info->tx_fifofull))
+ if ((ufstat & info->tx_fifomask) || (ufstat & info->tx_fifofull))
return 0;

return 1;
--
2.43.0.472.g3155946c3a-goog