Re: [PATCH 17/18] tty: serial: samsung: shrink port feature flags to u8

Sam Protsenko
2024-01-16T19:04:12Z

On Wed, Jan 10, 2024 at 4:25 AM Tudor Ambarus <tudor.ambarus@linaro.org> wrote:
>
> There's a single flag defined as of now. Shrink the feature flags to u8
> and aim for a better memory footprint for ``struct s3c24xx_uart_info``.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> drivers/tty/serial/samsung_tty.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> index 5df2bcebf9fb..598d9fe7a492 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> @@ -90,7 +90,7 @@ struct s3c24xx_uart_info {
>
> /* uart port features */
>
> - unsigned int has_divslot:1;
> + u8 has_divslot:1;

But that's already a bit field. Why does it matter which type it is?

> };
>
> struct s3c24xx_serial_drv_data {
> --
> 2.43.0.472.g3155946c3a-goog