From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E97B0C47077 for ; Thu, 11 Jan 2024 17:31:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=R7lQL4e3rIrY+amk/RS5v8GNARxi2Ogj7DdPXTjQwck=; b=pLBZX5J3OzaeqY8W+yEUbjv7I9 P0n2Bw4C62t9R9U+pTLtF6FjMEcJW/heC7SqB1kSUWQMLokz2Ke96Ur2QErfh1GC7Azl5byGrrS2+ 5lfa5erdC+LP8rixHKIWk8dRHCe3A/IfVZiDYsXC0IKtLeO21MrXLNG3EhU79j7CuqRozphHRtjuU nRRpS2aTkeXIbhtsLTn0qd/zSKlG3Il31I9gDyfvpN2CvH829K4FUtkBS2DqTeNH4+eaIQa3CBQdc RB6LHFE764/3fWEzBEmJbtc88bs9GNXoecb/PLvCYQgPwXfDiFZbNwJktGPcu1zyok5M/yud0O8fJ 2hVLNQ0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNytl-000jad-1h; Thu, 11 Jan 2024 17:31:21 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNyth-000jZ2-1i; Thu, 11 Jan 2024 17:31:19 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 070B461B5A; Thu, 11 Jan 2024 17:31:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1373BC433F1; Thu, 11 Jan 2024 17:31:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704994276; bh=z3f/odDTmvi8sV0yAYFsEU4ayXJE1gJP66VKYOAb/+c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D/0K89YNryWipcKZQDcwm9mKjge8TqgqpVv+2H6jUVz0wQRfOYFQWeCfVVpuE8yUF 20I3mPDisNUeI7MfwGczoWH7GLwfkdJtfi3y06pY8N1h3SHdLIm+Dbp+ndfUEHymjB ovC+S4CC6RCr99fH8EN1PIufe4wzNWYV0Cyts0d8oTQuo5hr6ilDd8dtEMnqcdXnQV asgYIR3RAy2JRuC7bLILDzeduqSaol+0G7Nx8pD8li6RP7r8CNCN/+BnvkDPEyfPiL wU7G6kH6pbkd3P13CYy30aZfvzVUyCC84/sWB9iYjoqAKAktWmBkmTQN8jVwybuRQK p29hu3lf6/kvg== Date: Thu, 11 Jan 2024 17:31:10 +0000 From: Conor Dooley To: Jason-JH Lin =?utf-8?B?KOael+edv+elpSk=?= Cc: "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , Singo Chang =?utf-8?B?KOW8teiIiOWciyk=?= , "linux-mediatek@lists.infradead.org" , Johnson Wang =?utf-8?B?KOeOi+iBlumRqyk=?= , "linux-media@vger.kernel.org" , "chunkuang.hu@kernel.org" , "devicetree@vger.kernel.org" , Jason-ch Chen =?utf-8?B?KOmZs+W7uuixqik=?= , Shawn Sung =?utf-8?B?KOWui+WtneismSk=?= , Nancy Lin =?utf-8?B?KOael+aso+ieoik=?= , "conor+dt@kernel.org" , Project_Global_Chrome_Upstream_Group , "linux-arm-kernel@lists.infradead.org" , "krzysztof.kozlowski+dt@linaro.org" , "matthias.bgg@gmail.com" , "jassisinghbrar@gmail.com" , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH v2 2/4] dt-bindings: mailbox: mediatek: gce-mailbox: Add reference to gce-props.yaml Message-ID: <20240111-anthology-dock-c60d28ac7f1c@spud> References: <20240110063532.14124-1-jason-jh.lin@mediatek.com> <20240110063532.14124-3-jason-jh.lin@mediatek.com> <20240110-grumbling-tattling-0202fc5e21f2@spud> <8c4004d5b6f68dc096aaf2a537e429c310b60c08.camel@mediatek.com> MIME-Version: 1.0 In-Reply-To: <8c4004d5b6f68dc096aaf2a537e429c310b60c08.camel@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240111_093117_656873_CE5EB4E5 X-CRM114-Status: GOOD ( 33.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4956230024639914626==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4956230024639914626== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QW5q1ZGC+crOHGMg" Content-Disposition: inline --QW5q1ZGC+crOHGMg Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 10, 2024 at 04:36:20PM +0000, Jason-JH Lin (=E6=9E=97=E7=9D=BF= =E7=A5=A5) wrote: > Hi Conor, >=20 > Thanks for the reviews. >=20 > On Wed, 2024-01-10 at 10:36 +0000, Conor Dooley wrote: > > On Wed, Jan 10, 2024 at 02:35:30PM +0800, Jason-JH.Lin wrote: > > > 1. Add "Provider" to the title to make it clearer. > > > 2. Add reference to gce-props.yaml for adding mediatek,gce-events > > > property. > >=20 > > I can see this from the diff. There's still no explanation here as to > > why the mailbox provider needs to have a gce-event id. NAK until you > > can > > explain that. > >=20 > Sorry for missing the reason in commit message, I'll add it in the next > version. >=20 > There are 2 reasons why the mailbox provider needs gce-events: > 1. The mailbox provider here is CMDQ mailbox driver. It configures GCE > hardware register by CPU directly. If we want to set the default value > from 0 to 1 for specific gce-events during the initialization of CMDQ > driver. We need to tell CMDQ driver what gce-events need to be set and > I think such GCE hardware setting can get from its device node. Why would someone want to set it to 1 or 0? At what level will that vary? Per SoC? Per board? Something else? > 2. We'll have the secure CMDQ mailbox driver in the future patch [1]. > It will request or reserve a mailbox channel, which is a dedicate GCE > thread, as a secure IRQ handler. This GCE thread executes a looping > instruction set that keeps waiting for the gce-event set from another > GCE thread in the secure world. So we also need to tell the CMDQ driver > what gce-event need to be waited. Ditto here, what level does this vary at? Do different SoCs or different boards/platforms dictate the value? Could this channel be determined from the soc-specific compatible? In other words, please explain in your commit message why this requires a property and is not detectable from any existing mechanism. From reading this I don't know what is preventing the secure mailbox channel =66rom picking a "random" unused channel. Thanks, Conor. > [1] cmdq_sec_irq_notify_start() is where the GCE thread is requested to > prepare a looping instruction set to wait for the gce-event. > -=20 > https://patchwork.kernel.org/project/linux-mediatek/patch/20231222045228.= 27826-9-jason-jh.lin@mediatek.com/ >=20 > Regards, > Jason-JH.Lin >=20 > > Cheers, > > Conor. > >=20 > > >=20 > > > Signed-off-by: Jason-JH.Lin > > > --- > > > .../devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml | 6 > > > ++++-- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > >=20 > > > diff --git > > > a/Documentation/devicetree/bindings/mailbox/mediatek,gce- > > > mailbox.yaml > > > b/Documentation/devicetree/bindings/mailbox/mediatek,gce- > > > mailbox.yaml > > > index cef9d7601398..728dc93117a6 100644 > > > --- a/Documentation/devicetree/bindings/mailbox/mediatek,gce- > > > mailbox.yaml > > > +++ b/Documentation/devicetree/bindings/mailbox/mediatek,gce- > > > mailbox.yaml > > > @@ -4,7 +4,7 @@ > > > $id:=20 > > > http://devicetree.org/schemas/mailbox/mediatek,gce-mailbox.yaml# > > > $schema: http://devicetree.org/meta-schemas/core.yaml# > > > =20 > > > -title: Mediatek Global Command Engine Mailbox > > > +title: MediaTek Global Command Engine Mailbox Provider > > > =20 > > > maintainers: > > > - Houlong Wei > > > @@ -57,6 +57,8 @@ required: > > > - clocks > > > =20 > > > allOf: > > > + - $ref: mediatek,gce-props.yaml > > > + > > > - if: > > > not: > > > properties: > > > @@ -67,7 +69,7 @@ allOf: > > > required: > > > - clock-names > > > =20 > > > -additionalProperties: false > > > +unevaluatedProperties: false > > > =20 > > > examples: > > > - | > > > --=20 > > > 2.18.0 > > >=20 --QW5q1ZGC+crOHGMg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZaAl3gAKCRB4tDGHoIJi 0t/LAQCI0RfsupQbS0ZgyeRCcDU8ETflHOhbgCzGZesvWIxDzwEAmfV2pBcTpwM2 4/y9NkmnC5ZZaHe6S2NooLECB1DA9AA= =Z03v -----END PGP SIGNATURE----- --QW5q1ZGC+crOHGMg-- --===============4956230024639914626== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4956230024639914626==--