From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1D16C4707B for ; Thu, 11 Jan 2024 11:57:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZzhdfJnbl7hcHvQTVK/9iKj8nFjWx/hd1fDgGPLFw2w=; b=q3ytk68ae3IqgE 2BmTEmuKKlo4wnDyVyYLlA7ZPPNFA/mqZ59lwI3N2P9oNPkZb0Jx2WgUnf//BbMYIp005tuWRq79s bxJuuM6unxATGOpu08s2PkMS28XR4XnXKlEnd6Bv1zOJzi4xymyCRW3wZHwABCJ9ItTdG2E8J3hhP dZbXOW4wyl/DQraczrkU2ILAtIbSTjaA7G8yMsEwZL+zffjj0WgYtGSU384SkNk2AFpg08gaBcPb9 HBGYLWG0fDBx4lG7XHloQ0QiyAsR+zvNkZcADUmOObLrQgpS3e8316epwZ7UMpNBJ+tIiHrw/Z/jZ goQDn6G2qQGGE77w9QlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNtg5-00HWbK-29; Thu, 11 Jan 2024 11:56:53 +0000 Received: from mail-oi1-f172.google.com ([209.85.167.172]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNtg2-00HWZ5-2c; Thu, 11 Jan 2024 11:56:52 +0000 Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3bbbe583e04so3243132b6e.3; Thu, 11 Jan 2024 03:56:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704974209; x=1705579009; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aRRot3fSPqM/q7yv55Kx8nQqL7oWPBUmdwcMoAjnDzI=; b=V4H6yKzTLeddGQ/N+3pefh2iZeUvCbG+3umZqfAqd7qd98yomJ2pALO6tTxdLfqW+4 2DkcJAoqc8snrxoQDEv+8yXuk4l3Tkmh/3BSulR6e91VV7RYVSifkqZ/xJtu1/ZN0q6P qH/Hruua9nWeSEFybj0sHGUsCErNQpsLP9kOirPvxfY/KoYIn/yA9nf46+PGK3CcBwmv 1rV9V5tsl9S1yOJhKakEN8SYYPTQyhJn9g8DAiq6pln/cJq5VLAdCrbMT6i7ixNHVpp5 NY5nLwSi0JkFtud0ThZSlBgtdbZ+j9YNu27F5h4uYOpoto480cSjc0ACCPbMjr2fgGTd GS/g== X-Gm-Message-State: AOJu0YzkpaN7Y7Nij3iuq5TdS2kDlxHmKwFERSlaC6Qrfkys93ctgtRL Q5loP8SeLPhnwz3W0FkxZyc= X-Google-Smtp-Source: AGHT+IH6QIRblUbO7LPVLGc5KQtSUtO/9V3RZZMWBTBUf/ouMAQIu3s88JmEiW1PahzxYrrxcTHaSg== X-Received: by 2002:a05:6808:3987:b0:3bb:c56e:7f6b with SMTP id gq7-20020a056808398700b003bbc56e7f6bmr1267990oib.56.1704974209024; Thu, 11 Jan 2024 03:56:49 -0800 (PST) Received: from localhost (fpd11144dd.ap.nuro.jp. [209.17.68.221]) by smtp.gmail.com with ESMTPSA id le5-20020a056a004fc500b006db00cb78a8sm997489pfb.179.2024.01.11.03.56.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 03:56:48 -0800 (PST) Date: Thu, 11 Jan 2024 20:56:46 +0900 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, Conor Dooley , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Florian Fainelli , Jim Quinlan , Krzysztof Kozlowski , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Lorenzo Pieralisi , Rob Herring Subject: Re: [PATCH v8 0/2] PCI: brcmstb: Configure appropriate HW CLKREQ# mode Message-ID: <20240111115646.GA1443933@rocinante> References: <20231113185607.1756-1-james.quinlan@broadcom.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231113185607.1756-1-james.quinlan@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240111_035650_849688_625F7A53 X-CRM114-Status: GOOD ( 22.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, > V8 -- Un-advertise L1SS capability when in "no-l1ss" mode (Bjorn) > -- Squashed last two commits of v7 (Bjorn) > -- Fix DT binding description text wrapping (Bjorn) > -- Fix incorrect Spec reference (Bjorn) > s/PCIe Spec/PCIe Express Mini CEM 2.1 specification/ > -- Text substitutions (Bjorn) > s/WRT/With respect to/ > s/Tclron/T_CLRon/ > > v7 -- Manivannan Sadhasivam suggested (a) making the property look like a > network phy-mode and (b) keeping the code simple (not counting clkreq > signal appearances, un-advertising capabilites, etc). This is > what I have done. The property is now "brcm,clkreq-mode" and > the values may be one of "safe", "default", and "no-l1ss". The > default setting is to employ the most capable power savings mode. > > v6 -- No code has been changed. > -- Changed commit subject and comment in "#PERST" commit (Bjorn, Cyril) > -- Changed sign-off and author email address for all commits. > This was due to a change in Broadcom's upstreaming policy. > > v5 -- Remove DT property "brcm,completion-timeout-us" from > "DT bindings" commit. Although this error may be reported > as a completion timeout, its cause was traced to an > internal bus timeout which may occur even when there is > no PCIe access being processed. We set a timeout of four > seconds only if we are operating in "L1SS CLKREQ#" mode. > -- Correct CEM 2.0 reference provided by HW engineer, > s/3.2.5.2.5/3.2.5.2.2/ (Bjorn) > -- Add newline to dev_info() string (Stefan) > -- Change variable rval to unsigned (Stefan) > -- s/implementaion/implementation/ (Bjorn) > -- s/superpowersave/powersupersave/ (Bjorn) > -- Slightly modify message on "PERST#" commit. > -- Rebase to torvalds master > > v4 -- New commit that asserts PERST# for 2711/RPi SOCs at PCIe RC > driver probe() time. This is done in Raspian Linux and its > absence may be the cause of a failing test case. > -- New commit that removes stale comment. > > v3 -- Rewrote commit msgs and comments refering panics if L1SS > is enabled/disabled; the code snippet that unadvertises L1SS > eliminates the panic scenario. (Bjorn) > -- Add reference for "400ns of CLKREQ# assertion" blurb (Bjorn) > -- Put binding names in DT commit Subject (Bjorn) > -- Add a verb to a commit's subject line (Bjorn) > -- s/accomodat(\w+)/accommodat$1/g (Bjorn) > -- Rewrote commit msgs and comments refering panics if L1SS > is enabled/disabled; the code snippet that unadvertises L1SS > eliminates the panic scenario. (Bjorn) > > v2 -- Changed binding property 'brcm,completion-timeout-msec' to > 'brcm,completion-timeout-us'. (StefanW for standard suffix). > -- Warn when clamping timeout value, and include clamped > region in message. Also add min and max in YAML. (StefanW) > -- Qualify description of "brcm,completion-timeout-us" so that > it refers to PCIe transactions. (StefanW) > -- Remvove mention of Linux specifics in binding description. (StefanW) > -- s/clkreq#/CLKREQ#/g (Bjorn) > -- Refactor completion-timeout-us code to compare max and min to > value given by the property (as opposed to the computed value). > > v1 -- The current driver assumes the downstream devices can > provide CLKREQ# for ASPM. These commits accomodate devices > w/ or w/o clkreq# and also handle L1SS-capable devices. > > -- The Raspian Linux folks have already been using a PCIe RC > property "brcm,enable-l1ss". These commits use the same > property, in a backward-compatible manner, and the implementaion > adds more detail and also automatically identifies devices w/o > a clkreq# signal, i.e. most devices plugged into an RPi CM4 > IO board. Applied to controller/broadcom, thank you! [01/02] dt-bindings: PCI: brcmstb: Add property "brcm,clkreq-mode" https://git.kernel.org/pci/pci/c/14b15aeb3628 [02/02] PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream device https://git.kernel.org/pci/pci/c/e2596dcf1e9d Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel