From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D365FC3DA79 for ; Mon, 15 Jan 2024 18:38:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bRbrSNaofE+ZD+4ioPjdxWQ4G/NuMkyXODMdortlvUQ=; b=X0FwU9dpc2hIdk 12oXosWS584v3KH56vSPtzTJKTfe7bDU6nxkkqGHF3BmUm1HdrHnUxGe7YjoHQPMBzmjtS+UViqK9 FNNnWtRXaDdpWmkNgCadj8rWXEwPav61cfxzJtUSiyYqJ3cqZ2u26a38vO/tJroomLsII/5T5roLc vr8GBcl3atj56cI3XooMataRoTrawPizIsqPecUcUu5MxvonKLAmWxCTl/NSdneB7B/3fE9JHQHJL +HWe+v6Hc5EFN4QglnZSn2i+L35+eQ2K18wtItnyvIxa8dQYI314dv5uaUscrG0jPnVXCBPAyrUfk GF6plPv39FtPFc4Sy+Rw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rPRqn-009xjU-1x; Mon, 15 Jan 2024 18:38:21 +0000 Received: from mail-co1nam11hn2206.outbound.protection.outlook.com ([52.100.173.206] helo=NAM11-CO1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rPRql-009xha-0C; Mon, 15 Jan 2024 18:38:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O+4zaUfVIK6Ar3Do/Uk67tPAJ7MT4k/IIgpeojlwdApfv2dMqhjegkjkKbB3M8wh4m/DHmz5yoJydEanb6doy29I/9gd7zY5zAEwltlfSWiPCRnx+YZFqdaVepDDU/nsKTmEB5W6c4Guz1Huzf1zFcBi6lV/VZRskjZaNXobpfeugClV4pvYdpjQIEwHl2zhs+lRcrEFUiWHUHVPhqyC/TjwJoJY+afPiPVT3PRdvnOmSSk+TaUSF6mjFIEPe7VGrp/aYT3RpYOvMgL1O2ZjC1X+80rRdsYsuwrl/Ami69x5/tgsyZB6GIsIK6SueSP7tL2Zf1iGvWWQfLj7XrKhqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H7/hbPBVHC9OGfhPtyanthvgnWbt0Jf8HvmEKTnAQJQ=; b=kRy3PjegrX0FZKSMUvCqwjKH6uZo5oQkVWJY37zNhPVppNe4X1qRtwA9vKQpjViJFKw911PdiZeXIynFXt/mRCZ8smonL31v6fW3HktdaNbzErW4Yd2NbD4RiUkLxNYJH1PHKm2mcgGpUAnZT3w4a6LaZh8RjyyuQ3EW2lO+CWF3I/hhi6RTiwkxTmafE7dOUcOy60MUIm9Q+RUJ8BLAAEIlU8zxHij9fV2vUOZm5lMfGw7eDURnmbNtxkqlY259x4Y3tt68Knb6oN+d1CJZfO2RJiYhJkq9cozhXPyvIF10lOpd6EjoEwRkgEx8rY6FZE9qt2y65bkNV2HqOUeFng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H7/hbPBVHC9OGfhPtyanthvgnWbt0Jf8HvmEKTnAQJQ=; b=Rl2YebhDyg3S06E6re0szhPo7p/q+mueOpge9Lh3h3vXqwlEYJ/6KTVnPFvU+dpbNseK3gmh7+gw6cgcyeirowQKhXy+HtkBvj+n1Up3x058jY4SPasKhAovltcWBJ+uKVkWOPzR0UlkqfKFnnhF8KhkUiNCHPzl08i12dUrZBp5j6IJcH5DSLYzcyt4uYmya164u1ahUgywvk4wsOEev5FbHMlhlpmepDmKvmUrasMMbrup1pbW1xaJazR7UUOL576uK0sR2lIVI082Da3mvEQv0ZNaYflIKZIytjKa24GKIQRF/HhQM4CvcREmgEAGGNyjASkG+Uzghe7jll0PJA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) by PH0PR12MB7792.namprd12.prod.outlook.com (2603:10b6:510:281::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Mon, 15 Jan 2024 18:38:15 +0000 Received: from LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::96dd:1160:6472:9873]) by LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::96dd:1160:6472:9873%6]) with mapi id 15.20.7181.020; Mon, 15 Jan 2024 18:38:15 +0000 Date: Mon, 15 Jan 2024 14:38:14 -0400 From: Jason Gunthorpe To: peterx@redhat.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, James Houghton , David Hildenbrand , "Kirill A . Shutemov" , Yang Shi , linux-riscv@lists.infradead.org, Andrew Morton , "Aneesh Kumar K . V" , Rik van Riel , Andrea Arcangeli , Axel Rasmussen , Mike Rapoport , John Hubbard , Vlastimil Babka , Michael Ellerman , Christophe Leroy , Andrew Jones , linuxppc-dev@lists.ozlabs.org, Mike Kravetz , Muchun Song , linux-arm-kernel@lists.infradead.org, Christoph Hellwig , Lorenzo Stoakes , Matthew Wilcox Subject: Re: [PATCH v2 07/13] mm/gup: Refactor record_subpages() to find 1st small page Message-ID: <20240115183814.GS734935@nvidia.com> References: <20240103091423.400294-1-peterx@redhat.com> <20240103091423.400294-8-peterx@redhat.com> Content-Disposition: inline In-Reply-To: <20240103091423.400294-8-peterx@redhat.com> X-ClientProxiedBy: BL1PR13CA0389.namprd13.prod.outlook.com (2603:10b6:208:2c0::34) To LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5869:EE_|PH0PR12MB7792:EE_ X-MS-Office365-Filtering-Correlation-Id: 99683257-a1d7-44c5-21a1-08dc15f92287 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?mYcREuzdCZfjB13vIWeG1cYTT0NGWavEP+OfAYw2+KsilukVwEKlWI0OeQKL?= =?us-ascii?Q?uJBAKz6yjCI+vdjLbenl80dDgbfufkAgbYoFPwBvj6Rrij1v10ZzcxcX8lc2?= =?us-ascii?Q?UphcE/87eja6ARIadnTGTePWh05q7fekho27DS3pTc5H8jz2TX042WWH9+Zr?= =?us-ascii?Q?bM2oNvNO72GtKIsSQlhfL6m9G++L8uyzErKxF4wrgSiGwBMg02fRVB3TcUQa?= =?us-ascii?Q?+nXTaBFC14tG5UdAP3dnRmXxtwOh4kcLI3ZbqsMMsxa8cahoFPH6bclqtg9X?= =?us-ascii?Q?tIinUnu0mLTy/yNhH6JWC4I4+1fLOe2kcTyd7ICExScfd1iQ9Ls3kqHR/USE?= =?us-ascii?Q?F130nmJYc5J9gNl1v40tfqqaxtrmIR8k/s8W+elCuWqvTR0RAATyk3J3I2kH?= =?us-ascii?Q?ucdEN41blG/ZxijKsSjN7NzKJnr4FzPofCFO4WogwUCzI1Yp7y0RGmjQH0GT?= =?us-ascii?Q?LE5q2cokdk+Sj0EBJ+pq7QBmo8JiQrQCphgguBgdDIUZA1PoonNfXoQ7oOm3?= =?us-ascii?Q?U/1VqJRC+L4CuZ7sDTDy0elQOpagFKjPJ9IbSKdpSyd9p2T8NLLoroLbqUWb?= =?us-ascii?Q?RPvveoSPnWFTHQdtTBXwJd4QxdQEiwJ+ohrnmD3GeEJy+KzCHKbQJsT0SgfU?= =?us-ascii?Q?5+F6fS7SbAwwr7rPV2IJQ0WgSzNx7jF4MmfKPz6Ai0LB6aXC/sK4R1plVy7T?= =?us-ascii?Q?oZn5/RLBFTgpFGf9WP77fHUjs7VKw/4Y2ZuP9rJ3Fhzb9vKxly5qMLfnhQY+?= =?us-ascii?Q?cfVDcPVs1KkcuinKb1A92LBD6FZHjpar9yXKHUFzqWmxB7h2J/UGZLEXx33g?= =?us-ascii?Q?/9JU1WvlS4VeueHKZq/dHtvoauMeDjGyOxvGK+Cfd83pQBN+Iwgj/jp8Yegt?= =?us-ascii?Q?nkLj1lC8cco5wLBycI2aiZyNc2gGkZZKEOdIv8uqNCVNXrnaig1gx6qLvKJn?= =?us-ascii?Q?Rm88sNXBVA1ASYuhQjl9ZXbSUYmVwJvNAQAsYTk10Jz1hFNNCYt0YWAh7nJ2?= =?us-ascii?Q?hfsStKfdEds/s7oOdN/wXrbenQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:5;SRV:;IPV:NLI;SFV:SPM;H:LV2PR12MB5869.namprd12.prod.outlook.com;PTR:;CAT:OSPM;SFS:(13230031)(39860400002)(366004)(346002)(136003)(376002)(396003)(230922051799003)(64100799003)(451199024)(1800799012)(186009)(66946007)(83380400001)(6506007)(66556008)(6512007)(26005)(478600001)(1076003)(38100700002)(4326008)(2616005)(5660300002)(8936002)(7416002)(4744005)(6916009)(54906003)(8676002)(66476007)(6486002)(2906002)(316002)(33656002)(36756003)(86362001)(41300700001)(27376004)(37363002);DIR:OUT;SFP:1501; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qG9dqY9op9CmAUH/TIN9XB5pjS2yrYSTq6yqzafXqZa2fKZZYUU9rH75GlM0?= =?us-ascii?Q?lOqZYyNH4XUJlF+dYcZdQ/9WgyGvjR1s46Bb5fcAqSMNDXHri6Z5J8dEXgTo?= =?us-ascii?Q?ADa0xmNAAQFkZH3ceOE6Ebj2NkMV+R3dXlyATNloYDmaTjYX+XWuPdEXvE76?= =?us-ascii?Q?5xawQeQ1ymGDRQbQzNpc0YtMIZXh/0BM/nEnroGiAXlCXkyO8nEsSA/ZrJXN?= =?us-ascii?Q?ShBeVAPKO84TpfebXpgvW8oAuU+az6mYBdpvDc++CuHLf1gu4bi7trDzHgMa?= =?us-ascii?Q?ths/8zCeUdUs+RfF5qr/H91ZY4jTyrAPbJe8s1W1EvMSF5jtJ7x16V9yCnqW?= =?us-ascii?Q?bGNamYankbuyB6yPCuNQSOyncgSYeRETImr3TRjD01B4q7meIkJJAFUfxOSb?= =?us-ascii?Q?TSiPVkDbyWUM5ISZgErYaBXqVCD4H2kOIJNeF6ULJW0yIu7inpEqPAEGaqIm?= =?us-ascii?Q?JLQRTeQA/ra0qLNQ0YHo/7hRJnqa0AeOzhwDeEuq21DxGb28CwZ5SOdd0pS5?= =?us-ascii?Q?fWobKCirg3gH0ihTPGvhQBnqYLDubLZAd+wl8GGlnMGeMQs7OZXqEr8Obe3T?= =?us-ascii?Q?lAp4j3VIzMLORaTMPUn8WAHO3ucFZHDqUr0guiQaar1MbhZ2NUR6hkxihZ+k?= =?us-ascii?Q?DQPii/NtnM62G3ze7/2a3DTYWXDbco96sZRB7dk1wdfzRD3d56zIf9ziZz0I?= =?us-ascii?Q?4LReQsTXaTchlex3EMQbWhAmw6CCaFpEJWEV4pKDpV3kqEQ2+a9h+vTpkfR6?= =?us-ascii?Q?P0HvnNYPw89uPGy+wLOMtyZjh51Pk/mmtIZii7xQvWZDlaCsivcu4PQe6pF3?= =?us-ascii?Q?t3mVDF6XZZBpfrvJqoII3D4k8ZLpNeZYYv0SR/Tt97YRUjc2XHKXhkmYjw0g?= =?us-ascii?Q?Mfees3OWvVxzqpRlnxXFmv21FUGSn3pG4rDAHkzp8oYG9WkZUSFK/w9cPXQ2?= =?us-ascii?Q?A+TAGNwmBGqGvDSp6JFlcY4dtjkN7p5Fd6Q6iOyufPCs/o8AbQs7hvk83P5P?= =?us-ascii?Q?VA430ewijonmZVh9FSSW2QORjdnoV/J54cgSP60qBCmU6pONzTgvGiKxzp/n?= =?us-ascii?Q?WoE7CAsx3SmZ9jZdzuTGUaKNbD+W51I/Xl+Ao1GZZnKciOsMOsO5mOOisF7H?= =?us-ascii?Q?WR7eNxvIKuPgGj/H3L1/YJb8CiQS8u9Pmn9QoJO5tRFsOqaJHZEiPk30i86E?= =?us-ascii?Q?NK5Srq6oUmUzBVgWEoPOmFu9fX0lMmfVSI7LWVx1K5J9w4RxVcw149aleqs2?= =?us-ascii?Q?2TbUdjYVTP3MvQvqH/ld6r3xdaMQzTC+nvq2vRqEF1DBd0h6EunvWJLsRqAj?= =?us-ascii?Q?YwAKwNQBVcBf6dnIHN143u8WhsImqXkCnbRq9qAF4OxUP3dMLj0ZZyc36QE/?= =?us-ascii?Q?1rKQA5ei6b0vmpxGzfHFGo0tkZDnhi133xlho4yLGiYSgER35B0aaXu5V+/y?= =?us-ascii?Q?Lp4aF6BfMez47ok2iktJ+xAnhIA5ErlAornp/UAadwjPKc+AsBPLglHYV+Gj?= =?us-ascii?Q?iMJZ75R4qWCiOK5YrdDtQYCUUY9g4omy8bcze7H6Np6MjS1k/ZWp1kxJfKob?= =?us-ascii?Q?jxcleCuYXbAFK4F1kjWznb71bEw29WaOcpkkz6Il?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99683257-a1d7-44c5-21a1-08dc15f92287 X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2024 18:38:15.1323 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: S3Pa0nJB7662OhoKvuC0NcS0efX/TSnv1rJdKUDcm+0wbVmUXCX92rmqnSVwdeE3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7792 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240115_103819_101335_F9679B10 X-CRM114-Status: GOOD ( 10.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 03, 2024 at 05:14:17PM +0800, peterx@redhat.com wrote: > From: Peter Xu > > All the fast-gup functions take a tail page to operate, always need to do > page mask calculations before feeding that into record_subpages(). > > Merge that logic into record_subpages(), so that it will do the nth_page() > calculation. > > Signed-off-by: Peter Xu > --- > mm/gup.c | 25 ++++++++++++++----------- > 1 file changed, 14 insertions(+), 11 deletions(-) Reviewed-by: Jason Gunthorpe Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel