From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB665C47DA2 for ; Tue, 16 Jan 2024 18:37:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OkGW59VTpWyi+CbpO4kwQakODjnbb/CT6LFZxb1L5dE=; b=gHXxjqGkrSwaYY ZXMJqcEk8BzfjYWS14YrXbpTnN71t7lo+3aNBT6N7lU7HDIujjr8vtBMpcLaKYWNsdYQ9qWeERE9K yji1G2haNBtIMFUj/ZPMrW5yya0kNNAdvkFdPiISAda0ADIW+HMGDH/2/XUh246KH0QghFGmrcFhj mVDx8u4PG/2InRuSWmXYz+83WKz+TkEfpS0+gJBs+YKnAqhlKhKFGkHO+UBObEWgDPnQxEcziGSXg FePwIOgrg/mZSI+FYpge1bDKb50ZPgyzrv+jvCmraOQDnHAfmHr6ndUMjKhMcNgLSNZQmS/7MXGFp j/yV1PsYcTimnkLaec+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rPoIn-00D0kT-1C; Tue, 16 Jan 2024 18:36:45 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rPoIk-00D0jx-0O for linux-arm-kernel@lists.infradead.org; Tue, 16 Jan 2024 18:36:43 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 14698CE1919; Tue, 16 Jan 2024 18:36:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57C84C433C7; Tue, 16 Jan 2024 18:36:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705430199; bh=I2G0ZiEcqMEXhbfeorisjs31sXqvnsEWf2BYWizY+SI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=goRIDPSIwbL/zs316N/BZQYhs5sVT//+8hgnCuelHawmR8qYlsS2SInXbrd48MgNs cjrcHQtJWIj4G3ccbeHo0Kgu7FhB8ko45BPPt9Dsa11HQhaNmFEZ99hcRYFecSO75G fU2tTSqcAhrI3eT1sphnEHqRmYuD6odsyo66GY5qsF97Fb1rjDkHTdIap+EvceJh45 dzJXD1spdNmVxuTzBONGcxpPibsWv870ceQAwOAvYp8PCT1SQRvF2jzWOLksV4mRMX oZPbHyy2+xLvRBqiwAIMIKqOn+hcz4eB1xyP2MWh5Lro0nZe0ywlmmm2auU0OE/qkN 6crfKl5Hystug== Date: Tue, 16 Jan 2024 10:36:37 -0800 From: Jakub Kicinski To: Romain Gantois Cc: Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , Miquel Raynal , Maxime Chevallier , Sylvain Girard , Pascal EBERHARD , Richard Tresidder , Linus Walleij , Vladimir Oltean , Andrew Lunn , Thomas Petazzoni , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, Vladimir Oltean Subject: Re: [PATCH net v5] net: stmmac: Prevent DSA tags from breaking COE Message-ID: <20240116103637.794811a6@kernel.org> In-Reply-To: References: <20240111-prevent_dsa_tags-v5-1-63e795a4d129@bootlin.com> <20240112181327.505b424e@kernel.org> <20240116072300.3a6e0dbe@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240116_103642_334773_A3D2472D X-CRM114-Status: GOOD ( 13.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 16 Jan 2024 17:18:30 +0100 (CET) Romain Gantois wrote: > > which makes it sound like bit 5 will not be set for a Ethernet II frame > > with unsupported IP payload, or not an IP frame. Does the bit mean other > > things in different descriptor formats? > > The description of this bit in my datasheet is: > > ``` > b5 FT Frame Type > When set, this bit indicates that the Receive Frame is an Ethernet-type frame > (the Length/Type field is greater than or equal to 1,536). When this bit is > reset, it indicates that the received frame is an IEEE 802.3 frame. This bit is > not valid for Runt frames less than 14 bytes > ``` > > There is no mention of a more subtle check to detect non-IP Ethernet II frames. > I ran some tests on my hardware and EDSA-tagged packets consistently come in > with status 0b100, so the MAC sets the frame type bit even for frames that don't > have an IP ethertype. Boo, who designed this thing :( v6 is good to go in then, thank you for investigating and testing! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel