From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6829AC47077 for ; Wed, 17 Jan 2024 01:54:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wYvPvKEwn4UNnBsaOAZHpqHSkBDVflzDgFYxvEprrrY=; b=RERcZKq55zykOk KwIIPOhxp2727+TixhqscCu422m9VIDu6m8wTmQIrtkMe9xYFgT6LQQbetXcV/Mk49XRYiiwmItbr buczN7cNsnyDapGbqc3iWggGJOdTpuxYyzI5dpjvmqtMMVL8JMdb3w3uSyow3s/5JGxYm8cu5fxm/ QKsQ8VM42V4T+L3uTH4DeYhaDEf441mL7s8rgowMmvoYluT0T4KWsku7EV0ZNa2khyFasuNaW9YT6 zovWeWl5Dq+YQVCyQD6gABe8xJj6Y3pXEG0eVyQm+qNmKM0q4HKqPILEyVAzSpYa6dVeZEtz64y5B Vaa1RsZwWUosr0jvlKyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rPv7b-00EBd8-2h; Wed, 17 Jan 2024 01:53:39 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rPv7Z-00EBcF-17 for linux-arm-kernel@lists.infradead.org; Wed, 17 Jan 2024 01:53:38 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 1B89CB8107E; Wed, 17 Jan 2024 01:53:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7C93C433F1; Wed, 17 Jan 2024 01:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705456410; bh=BElXs104GGWyneznFWlmSje+zAUEH5lxUrbFygcCijY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ozMk7K8Ian3IYofgxo4tGXyMnrSkXFAM0Imbj3BzW102RHMvznMN3OoGL9urFPbTs fZWU2v3OA3eUT5TSM7vzZVILJZrZNfjxYpJje0gpCADB1q2wiu1cP3lc33S7s9cjIm 2dswo+u1SK2l91N+SOFwcVpLiqEHh081QcyvOJ8EpaN56VR9qFOjtI0F/BgWG79cUW j5VSTUlSvyr+1gweW5woWRp0NK8pS6vMl6RajE8ulfQ3fgDb6KrBxMPuxJVk6xXnX1 ldKYmZerAWcZaODBLPW2tj9PoZE3S2qL4yeOeBBXue5Dqrs7PBTzxPOlS/2ZFDnAA3 /vr7+NePMR5eg== Date: Tue, 16 Jan 2024 17:53:28 -0800 From: Jakub Kicinski To: Colin Ian King Cc: "David S . Miller" , Eric Dumazet , Paolo Abeni , Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] net: microchip: sparx5: remove redundant store to variable clk_hz Message-ID: <20240116175328.2d6902af@kernel.org> In-Reply-To: <20240116161847.2317011-1-colin.i.king@gmail.com> References: <20240116161847.2317011-1-colin.i.king@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240116_175337_559737_1CDD1D8D X-CRM114-Status: UNSURE ( 9.42 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 16 Jan 2024 16:18:47 +0000 Colin Ian King wrote: > The store to clk_hz is redundant since clk_hz goes out of scope on the > return. Fix this by replacing the *= operator with just * to remove > the store back to clk_hz. > > Cleans up clang scan build warning: > warning: Although the value stored to 'clk_hz' is used in the enclosing > expression, the value is never actually read from 'clk_hz' > [deadcode.DeadStores] > > Signed-off-by: Colin Ian King For consistency - same story as: https://lore.kernel.org/all/20240116193152.GD588419@kernel.org/ -- pw-bot: defer _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel