From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A47A9C47077 for ; Tue, 16 Jan 2024 19:50:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m5PfNuSSjF1NPaNICthfLJrSr2ygFVqM2juTsvzYHM0=; b=p6AZetM4WfK8Eb TXNM+aYSIx7fbGNIwWWdedTF+4nCciVAh1RfuAZR1PsLbAPeQ/5YQHqKJqLnFrLd4Hz+cclfQvgZ4 cGjlkVbCMjqNl5G6BvEGCZby0H8UiElY30SEINXQfoV6skL4r7wDfCpBP2fFWTHsYHThI31zarPtR t1dy6ks1UP2YS/1mgbUNKmWTibE16dSosymaX59IJvqcnqmmmR11FcrFDlhwhIB54CJ7If+xqFTsU P7fJ9fhG2HuKqvPD73hptO0it/7O04Pz1LAkf5T7i1lhdJ4ppz9vEMpkseXZBLIt1N2uYvTjvxV6R vC+8gsmt1YpBYmpVx3sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rPpRY-00DE51-1c; Tue, 16 Jan 2024 19:49:52 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rPpRU-00DE3L-1K for linux-arm-kernel@lists.infradead.org; Tue, 16 Jan 2024 19:49:50 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 80712B80FAC; Tue, 16 Jan 2024 19:49:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B14B4C43390; Tue, 16 Jan 2024 19:49:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705434586; bh=nDrC9wTsCV4ph2iLOi/kjmUrKVaAS25bEBAFssh/F98=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rt2FDwLkrEvke5xX3NG2XsTzU/1v1AFMfYT3gFwaDjFtMNSx6SOqH1XIkRtJBOoyh mwsMlpc8GweBANnXi89yX+fAIpoxT6EWsyWKMKpLs4FIKElC12KDINnLVfxEo3AMdY XEhkRRLSfe4V14sKLBqM7RP+DW8+GxDVF9O5iIf8FRYDiDm++l96OruiFu1UqmINk4 cnmmpOfsCcqOr4VCcRnE9QcR8OwpiDKoGUdCPU0yRunpacKpAhO5bUH5bNgi3DTtO8 4n2bT1APCSEQmT7Q0G011OkJoWArrWMb0WDzQ0TdzNVYmfRNshybGniknqm8+EhrkF AQy2aI8+dwU2w== Date: Tue, 16 Jan 2024 13:49:43 -0600 From: Rob Herring To: Dharma Balasubiramani Subject: Re: [PATCH v2 1/3] dt-bindings: display: convert Atmel's HLCDC to DT schema Message-ID: <20240116194943.GA301272-robh@kernel.org> References: <20240116113800.82529-1-dharma.b@microchip.com> <20240116113800.82529-2-dharma.b@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240116113800.82529-2-dharma.b@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240116_114948_749306_8C76034F X-CRM114-Status: GOOD ( 20.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux4microchip@microchip.com, linux-pwm@vger.kernel.org, alexandre.belloni@bootlin.com, dri-devel@lists.freedesktop.org, conor.dooley@microchip.com, thierry.reding@gmail.com, krzysztof.kozlowski+dt@linaro.org, claudiu.beznea@tuxon.dev, airlied@gmail.com, sam@ravnborg.org, lee@kernel.org, u.kleine-koenig@pengutronix.de, devicetree@vger.kernel.org, conor+dt@kernel.org, tzimmermann@suse.de, maarten.lankhorst@linux.intel.com, mripard@kernel.org, linux-arm-kernel@lists.infradead.org, bbrezillon@kernel.org, linux-kernel@vger.kernel.org, daniel@ffwll.ch Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 16, 2024 at 05:07:58PM +0530, Dharma Balasubiramani wrote: > Convert the existing DT binding to DT schema of the Atmel's HLCDC display > controller. > > Signed-off-by: Dharma Balasubiramani > --- > changelog > v1 -> v2 > - Remove the explicit copyrights. > - Modify filename like compatible. > - Modify title (drop words like binding/driver). > - Modify description actually describing the hardware and not the driver. > - Remove pinctrl properties which aren't required. > - Ref endpoint and not endpoint-base. > - Drop redundant info about bus-width description and add ref to video-interfaces. > - Move 'additionalProperties' after 'Required'. > - Drop parent node and it's other sub-device node which are not related here. > - Add compatible to example 2 and add comments that bus-width is the diff between two examples. > --- > .../atmel/atmel,hlcdc-display-controller.yaml | 110 ++++++++++++++++++ > .../bindings/display/atmel/hlcdc-dc.txt | 75 ------------ > 2 files changed, 110 insertions(+), 75 deletions(-) > create mode 100644 Documentation/devicetree/bindings/display/atmel/atmel,hlcdc-display-controller.yaml > delete mode 100644 Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt > > diff --git a/Documentation/devicetree/bindings/display/atmel/atmel,hlcdc-display-controller.yaml b/Documentation/devicetree/bindings/display/atmel/atmel,hlcdc-display-controller.yaml > new file mode 100644 > index 000000000000..f022c294cfbc > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/atmel/atmel,hlcdc-display-controller.yaml > @@ -0,0 +1,110 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/atmel/atmel,hlcdc-display-controller.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Atmel's High LCD Controller (HLCDC) > + > +maintainers: > + - Nicolas Ferre > + - Alexandre Belloni > + - Claudiu Beznea > + > +description: | > + The LCD Controller (LCDC) consists of logic for transferring LCD image > + data from an external display buffer to a TFT LCD panel. The LCDC has one > + display input buffer per layer that fetches pixels through the single bus > + host interface and a look-up table to allow palletized display > + configurations. > + > +properties: > + compatible: > + const: atmel,hlcdc-display-controller > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: > + Output endpoint of the controller, connecting the LCD panel signals. > + > + properties: > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > + reg: > + maxItems: 1 > + > + endpoint: > + $ref: /schemas/graph.yaml#/$defs/endpoint > + unevaluatedProperties: false > + description: > + Endpoint connecting the LCD panel signals. > + > + properties: > + bus-width: > + description: Endpoint bus width. > + $ref: /schemas/media/video-interfaces.yaml# > + enum: [ 12, 16, 18, 24 ] > + > +required: > + - '#address-cells' > + - '#size-cells' > + - compatible > + - port@0 > + > +additionalProperties: false > + > +examples: > + - | > + //Example 1 > + > + display-controller { > + compatible = "atmel,hlcdc-display-controller"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_lcd_base &pinctrl_lcd_rgb888>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0>; > + > + hlcdc_panel_output: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&panel_input>; > + }; > + }; > + }; > + > + - | > + //Example 2 With a video interface override to force rgb565, bus-width=16 > + > + display-controller { > + compatible = "atmel,hlcdc-display-controller"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_lcd_base &pinctrl_lcd_rgb565>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0>; > + hlcdc_panel_output2: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&panel_input>; > + bus-width = <16>; > + }; > + }; > + }; Just 1 extra property doesn't justify 2 examples. In any case, drop the partial examples and just have 1 complete example in the MFD binding schema. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel