From: Trevor Woerner <twoerner@gmail.com>
To: linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>, Chen-Yu Tsai <wens@csie.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: [PATCH 2/2] arm64: dts: rockchip: rock-pi-e: fix location of snps properties
Date: Tue, 16 Jan 2024 15:41:02 -0500 [thread overview]
Message-ID: <20240116204103.29318-2-twoerner@gmail.com> (raw)
In-Reply-To: <20240116204103.29318-1-twoerner@gmail.com>
A number of snps (Synopsys) properties are not in their correct location.
Fixes: b918e81f2145 ("arm64: dts: rockchip: rk3328: Add Radxa ROCK Pi E")
Signed-off-by: Trevor Woerner <twoerner@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts
index 096cfa19036e..0739b8fec86e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts
@@ -150,8 +150,11 @@ &gmac2io {
phy-mode = "rgmii";
phy-supply = <&vcc_io>;
pinctrl-names = "default";
- pinctrl-0 = <&rgmiim1_pins>;
+ pinctrl-0 = <&rgmiim1_pins>, <ð_phy_reset_pin>;
snps,aal;
+ snps,reset-gpio = <&gpio1 RK_PC2 GPIO_ACTIVE_LOW>;
+ snps,reset-active-low;
+ snps,reset-delays-us = <0 10000 50000>;
snps,rxpbl = <0x4>;
snps,txpbl = <0x4>;
tx_delay = <0x26>;
@@ -165,13 +168,10 @@ mdio {
rtl8211: ethernet-phy@1 {
reg = <1>;
- pinctrl-0 = <ð_phy_int_pin>, <ð_phy_reset_pin>;
+ pinctrl-0 = <ð_phy_int_pin>;
pinctrl-names = "default";
interrupt-parent = <&gpio1>;
interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
- reset-assert-us = <10000>;
- reset-deassert-us = <50000>;
- reset-gpios = <&gpio1 RK_PC2 GPIO_ACTIVE_LOW>;
};
};
};
--
2.43.0.76.g1a87c842ece3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-16 20:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 20:41 [PATCH 1/2] arm64: dts: rockchip: rock-pi-e: adjust phy-handle name Trevor Woerner
2024-01-16 20:41 ` Trevor Woerner [this message]
2024-01-17 4:38 ` [PATCH 2/2] arm64: dts: rockchip: rock-pi-e: fix location of snps properties Chen-Yu Tsai
2024-01-17 5:47 ` Trevor Woerner
2024-01-17 8:15 ` Jonas Karlman
2024-01-18 7:31 ` Jonas Karlman
2024-01-18 23:03 ` Trevor Woerner
2024-01-25 20:12 ` Heiko Stuebner
2024-01-27 1:56 ` Trevor Woerner
2024-02-13 19:37 ` (subset) [PATCH 1/2] arm64: dts: rockchip: rock-pi-e: adjust phy-handle name Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240116204103.29318-2-twoerner@gmail.com \
--to=twoerner@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).