From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4260C4707B for ; Thu, 18 Jan 2024 15:01:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Mime-Version:References: In-Reply-To:Message-Id:Cc:To:From:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=k+PGsSTqUHzEEFgXq5Bcu1Yndcok0Z7nTVorSfHjVX0=; b=ehuOyoyGuZ6ylgAQ10snWocYEr FP40Q5bvlyefNIrMdYhgdWV8GmTWbpezLteTN+I9rbxcdeZNp4RyibK6gg/w4BxPowuo9M94KUsop Oil5YAkZGVzh43zBU0hEDIHuVEpwF9PD70+6v3RWT5yYsmRLbkzc/PcPf+PlWL5SZALISMvG7tT/O YZhMdT2XgFx6K4uOn7VD9IQvxgFvwcWCBFktTEqx2Fp13taMW9nmlnL+YcIrRr7gxWwQSRA5KGn9S 6j2/yBbI7HEoReJZE4g/0QbYxgqFP6sSDxWnK6ur30JgnuFYZywG8jRKLRRD4UZBEpX2W546JD6Gt xLbu1b5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rQTtJ-0031oA-0M; Thu, 18 Jan 2024 15:01:13 +0000 Received: from mail.hugovil.com ([162.243.120.170]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rQTtD-0031n0-33 for linux-arm-kernel@lists.infradead.org; Thu, 18 Jan 2024 15:01:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:Mime-Version:Message-Id:Cc:To:From :Date:subject:date:message-id:reply-to; bh=oIasUBN4lV6VWChw5fNJuOaqs+4Z5ywxZ211LhMgxjc=; b=ymtBj7H7Qk1H51yZvIey9JETXk XGeRho/P3j153eBT8kBJazV/aVM90F9ehtSyHNdWjXABAADOjnrtkrtbaIMwwYwXcy3XfQehTL8RN FVb43naqqierwoSS850uhyqcR8LArY0F4/XUNIq1l/i2FApaq/hmhme8H9PcFphHGSeA=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:57218 helo=pettiford) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1rQTsw-0002Ts-BV; Thu, 18 Jan 2024 10:00:51 -0500 Date: Thu, 18 Jan 2024 10:00:49 -0500 From: Hugo Villeneuve To: Christoph Niedermaier Cc: , , Greg Kroah-Hartman , Crescent CY Hsieh , Jiri Slaby , Lukas Wunner , Lino Sanfilippo Message-Id: <20240118100049.0e17d2d8808df7905ff45d71@hugovil.com> In-Reply-To: <20240118124350.3772-1-cniedermaier@dh-electronics.com> References: <20240118124350.3772-1-cniedermaier@dh-electronics.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com Subject: Re: [PATCH] tty: serial: Fix bit order in RS485 flag definitions X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240118_070108_063500_C96033F1 X-CRM114-Status: GOOD ( 18.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 18 Jan 2024 13:43:50 +0100 Christoph Niedermaier wrote: > Since the commit 93f3350c46fa ("RS485: fix inconsistencies in the > meaning of some variables"), the definition for bit 3 has been removed. > But with the switch to bit shift marcos in commit 76ac8e29855b ("tty: marcos -> macros Hugo Villeneuve > serial: Cleanup the bit shift with macro"), this gap wasn't preserved. > To avoid a break in user/kernel api of the system skip bit 3 again and > add a placeholder comment. > > Signed-off-by: Christoph Niedermaier > --- > Cc: Greg Kroah-Hartman > Cc: Crescent CY Hsieh > Cc: Jiri Slaby > Cc: Lukas Wunner > Cc: Lino Sanfilippo > To: linux-serial@vger.kernel.org > To: linux-arm-kernel@lists.infradead.org > --- > include/uapi/linux/serial.h | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/include/uapi/linux/serial.h b/include/uapi/linux/serial.h > index 9086367db043..de9b4733607e 100644 > --- a/include/uapi/linux/serial.h > +++ b/include/uapi/linux/serial.h > @@ -145,12 +145,13 @@ struct serial_rs485 { > #define SER_RS485_ENABLED _BITUL(0) > #define SER_RS485_RTS_ON_SEND _BITUL(1) > #define SER_RS485_RTS_AFTER_SEND _BITUL(2) > -#define SER_RS485_RX_DURING_TX _BITUL(3) > -#define SER_RS485_TERMINATE_BUS _BITUL(4) > -#define SER_RS485_ADDRB _BITUL(5) > -#define SER_RS485_ADDR_RECV _BITUL(6) > -#define SER_RS485_ADDR_DEST _BITUL(7) > -#define SER_RS485_MODE_RS422 _BITUL(8) > +/* Placeholder for bit 3: SER_RS485_RTS_BEFORE_SEND, which isn't used anymore */ > +#define SER_RS485_RX_DURING_TX _BITUL(4) > +#define SER_RS485_TERMINATE_BUS _BITUL(5) > +#define SER_RS485_ADDRB _BITUL(6) > +#define SER_RS485_ADDR_RECV _BITUL(7) > +#define SER_RS485_ADDR_DEST _BITUL(8) > +#define SER_RS485_MODE_RS422 _BITUL(9) > > __u32 delay_rts_before_send; > __u32 delay_rts_after_send; > -- > 2.11.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel