From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80666C4707B for ; Thu, 18 Jan 2024 14:51:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h/hS3RpsLrNUE2yPUC7EMQS/gcqnz8OeJZqmOT75Ufo=; b=dsKIGEeRDHIe+M 4cWmN8ZygHaN1/RhyAvYRd6H1FI8IAKP5mzWSN9GwgZje+LfHJVTQVvyiRK5QeDZRoNm5nkKuC+PL JkqUDPpkmkv+NOjffRhdTdJtRbV1fdz0/86dh7bNsoNP2uFwDTvZGCOiw/stxb7yp0Gf/POYNxLAj rvBLjYhNeaIQYDrS4sq+IWBEy7Lbh/QmS4A/CmCKqHupD6NrYBm+jVvh7u96KJwnveGqbp/u48WKY QfZp7MVhO7jz1Sm25sO8uNBNdiS0kbrG6AXkP8bT5TGNYNbEfSfnuyWNRoxAEMSs4+jZGjxJ6sZFc Szmz9qyTYaz1QH42obEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rQTjY-0030gl-07; Thu, 18 Jan 2024 14:51:08 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rQTjT-0030fP-1O for linux-arm-kernel@lists.infradead.org; Thu, 18 Jan 2024 14:51:05 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B2E7461070; Thu, 18 Jan 2024 14:51:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4498C433C7; Thu, 18 Jan 2024 14:51:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1705589462; bh=dU0vTGtSjy0owwgueKY5DvJdRB4i0XsI3LTxRMVgXpE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cf3SI2nyc1QrLdhL2wtu5KvpDfRl7HoJbrAAJm6FH/ruTGMFGJLQRPiMxM8roXq+S nf9ekDQyNf5jy1JyDNRTAaaJ6KcyzjjMe/jSLEHrCtbEmcqaqGUUmFcNHl+rrkixUO z7w895DXf//JKm50jyX7Bdk+Zud9Erhtr57PhsjY= Date: Thu, 18 Jan 2024 15:18:43 +0100 From: Greg Kroah-Hartman To: Christoph Niedermaier Cc: linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Crescent CY Hsieh , Jiri Slaby , Lukas Wunner , Lino Sanfilippo Subject: Re: [PATCH] tty: serial: Fix bit order in RS485 flag definitions Message-ID: <2024011827-bagful-connector-9b36@gregkh> References: <20240118124350.3772-1-cniedermaier@dh-electronics.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240118124350.3772-1-cniedermaier@dh-electronics.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240118_065103_514770_FE782350 X-CRM114-Status: GOOD ( 12.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 18, 2024 at 01:43:50PM +0100, Christoph Niedermaier wrote: > Since the commit 93f3350c46fa ("RS485: fix inconsistencies in the > meaning of some variables"), the definition for bit 3 has been removed. > But with the switch to bit shift marcos in commit 76ac8e29855b ("tty: > serial: Cleanup the bit shift with macro"), this gap wasn't preserved. > To avoid a break in user/kernel api of the system skip bit 3 again and > add a placeholder comment. > > Signed-off-by: Christoph Niedermaier > --- > Cc: Greg Kroah-Hartman > Cc: Crescent CY Hsieh > Cc: Jiri Slaby > Cc: Lukas Wunner > Cc: Lino Sanfilippo > To: linux-serial@vger.kernel.org > To: linux-arm-kernel@lists.infradead.org > --- Shouldn't this have a Fixes: tag in it? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel