From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AA8CC4725D for ; Fri, 19 Jan 2024 12:05:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=q93d61uRsxeXNz2nchUJ9OfSaf3sYqkyMpkUgsKXP34=; b=2gBeLRzrjGprDnzY+Lt3yFVKGu yqWB1ib/d4hAGgwwZP0WcZxzrCdgH3rz4BeHYheh4Ywc5g1w4vYXc5veLtJmpOWuf4ndRcolDbok+ XfV3lXZKIYbga1Bjq/UJ8Mx7/Y2hAXQ22Li5v/lDlcxCHS/0kNkJIorrKkRBWrFtqPKvrSlLNkmj0 HmQd9FHUT0mtfHBuiJV2RsRbcjERbLu0BqMQ7LhmdBkhEldUgDv8XCMN563ufb4pIqt3R2AslR6Zl HAbeliWk3k/IjYc756lDOGwCl2krfxYqixFiGK2A0TQ+EmLEZ4vOqriutJdt1/CC4rtflAxuHopkU ogavrq9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rQncM-005R6L-2x; Fri, 19 Jan 2024 12:05:02 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rQncJ-005R1D-0z for linux-arm-kernel@lists.infradead.org; Fri, 19 Jan 2024 12:05:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1705665899; x=1737201899; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=j6iDGS0RH2zPYPqLFo5vTY1M1nOg2boEqT3Tjpt4eYs=; b=TpT0/S98KvEQzAqwG5bez36EMX1DNcmMOONN8kU+k1+Uo1cNvlhty/xh kzQOAZog8Qtrg6r4lo85ar+qj/+gJZMx56TtRVHzSpuwGliNwwuU+wU2C weSiqZQM1Uc2FLz6YwHw+RXbRRsaTEMkRVUFgzJcnp3BHhZXRzvcahc7Q oZay/v3VA2WEnk2RIAVo57r2ManlmuSX0fReWe+BWJs2/mBskdNoz+P7Z BFSv0Rohb/buEB/4G1FO4Nm1m3gQA4Ww6PtIM49r7kNE25czRC0xcDbP7 a4YGaqk9VXTDiAOiP9mhnQnQZ2bLd/F/l5z83q+eoEjS4IY56I95OpbV0 g==; X-CSE-ConnectionGUID: A5LlJf7nQL6xcXZAQ6I1bw== X-CSE-MsgGUID: tkta2MrESBqXD4cPHCDwpQ== X-IronPort-AV: E=Sophos;i="6.05,204,1701154800"; d="asc'?scan'208";a="14994207" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa4.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 19 Jan 2024 05:04:52 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 19 Jan 2024 05:04:24 -0700 Received: from wendy (10.10.85.11) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 19 Jan 2024 05:04:20 -0700 Date: Fri, 19 Jan 2024 12:03:43 +0000 From: Conor Dooley To: Subject: Re: [PATCH v3 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format Message-ID: <20240119-character-mardi-43571d7fe7d5@wendy> References: <20240118092612.117491-1-dharma.b@microchip.com> <20240118092612.117491-4-dharma.b@microchip.com> <20240118-recent-glorified-fd35d72e006e@spud> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240119_040459_546543_09D08622 X-CRM114-Status: GOOD ( 32.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, linux-pwm@vger.kernel.org, Linux4Microchip@microchip.com, dri-devel@lists.freedesktop.org, thierry.reding@gmail.com, krzysztof.kozlowski+dt@linaro.org, claudiu.beznea@tuxon.dev, airlied@gmail.com, sam@ravnborg.org, lee@kernel.org, u.kleine-koenig@pengutronix.de, devicetree@vger.kernel.org, conor+dt@kernel.org, tzimmermann@suse.de, maarten.lankhorst@linux.intel.com, mripard@kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, bbrezillon@kernel.org, linux-kernel@vger.kernel.org, conor@kernel.org, daniel@ffwll.ch Content-Type: multipart/mixed; boundary="===============4433632581817802485==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4433632581817802485== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="a0WqJfirCmr9EVhF" Content-Disposition: inline --a0WqJfirCmr9EVhF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 19, 2024 at 03:32:49AM +0000, Dharma.B@microchip.com wrote: > On 18/01/24 9:10 pm, Conor Dooley wrote: > > On Thu, Jan 18, 2024 at 02:56:12PM +0530, Dharma Balasubiramani wrote: > >> Convert the atmel,hlcdc binding to DT schema format. > >> > >> Adjust the clock-names property to clarify that the LCD controller exp= ects > >> one of these clocks (either sys_clk or lvds_pll_clk to be present but = not > >> both) along with the slow_clk and periph_clk. This alignment with the = actual > >> hardware requirements will enable accurate device tree configuration f= or > >> systems using the HLCDC IP. > >> > >> Signed-off-by: Dharma Balasubiramani > >> --- > >> changelog > >> v2 -> v3 > >> - Rename hlcdc-display-controller and hlcdc-pwm to generic names. > >> - Modify the description by removing the unwanted comments and '|'. > >> - Modify clock-names simpler. > >> v1 -> v2 > >> - Remove the explicit copyrights. > >> - Modify title (not include words like binding/driver). > >> - Modify description actually describing the hardware and not the driv= er. > >> - Add details of lvds_pll addition in commit message. > >> - Ref endpoint and not endpoint-base. > >> - Fix coding style. > >> ... > >> .../devicetree/bindings/mfd/atmel,hlcdc.yaml | 97 +++++++++++++++++= ++ > >> .../devicetree/bindings/mfd/atmel-hlcdc.txt | 56 ----------- > >> 2 files changed, 97 insertions(+), 56 deletions(-) > >> create mode 100644 Documentation/devicetree/bindings/mfd/atmel,hlcdc= =2Eyaml > >> delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-hlcdc= =2Etxt > >> > >> diff --git a/Documentation/devicetree/bindings/mfd/atmel,hlcdc.yaml b/= Documentation/devicetree/bindings/mfd/atmel,hlcdc.yaml > >> new file mode 100644 > >> index 000000000000..eccc998ac42c > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/mfd/atmel,hlcdc.yaml > >> @@ -0,0 +1,97 @@ > >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > >> +%YAML 1.2 > >> +--- > >> +$id:http://devicetree.org/schemas/mfd/atmel,hlcdc.yaml# > >> +$schema:http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: Atmel's HLCD Controller > >> + > >> +maintainers: > >> + - Nicolas Ferre > >> + - Alexandre Belloni > >> + - Claudiu Beznea > >> + > >> +description: > >> + The Atmel HLCDC (HLCD Controller) IP available on Atmel SoCs expose= s two > >> + subdevices, a PWM chip and a Display Controller. > >> + > >> +properties: > >> + compatible: > >> + enum: > >> + - atmel,at91sam9n12-hlcdc > >> + - atmel,at91sam9x5-hlcdc > >> + - atmel,sama5d2-hlcdc > >> + - atmel,sama5d3-hlcdc > >> + - atmel,sama5d4-hlcdc > >> + - microchip,sam9x60-hlcdc > >> + - microchip,sam9x75-xlcdc > >> + > >> + reg: > >> + maxItems: 1 > >> + > >> + interrupts: > >> + maxItems: 1 > >> + > >> + clocks: > >> + maxItems: 3 > > Hmm, one thing I probably should have said on the previous version, but > > I missed somehow: It would be good to add an items list to the clocks > > property here to explain what the 3 clocks are/are used for - especially > > since there is additional complexity being added here to use either the > > sys or lvds clocks. > May I inquire if this approach is likely to be effective? >=20 > clocks: > items: > - description: peripheral clock > - description: generic clock or lvds pll clock > Once the LVDS PLL is enabled, the pixel clock is used as the > clock for LCDC, so its GCLK is no longer needed. > - description: slow clock > maxItems: 3 Hmm that sounds very suspect to me. "Once the lvdspll is enabled the generic clock is no longer needed" sounds like both clocks can be provided to the IP on different pins and their provision is not mutually exclusive, just that the IP will only actually use one at a time. If that is the case, then this patch is nott correct and the binding should allow for 4 clocks, with both the generic clock and the lvds pll being present in the DT at the same time. I vaguely recall internal discussion about this problem some time back but the details all escape me. Thanks, Conor. --a0WqJfirCmr9EVhF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZaplHwAKCRB4tDGHoIJi 0lj2AP9K84iq37Rz1ulvFhMipsNqhqMxklWv5GvyAq1ZD/lqSwEAq0vY9saiWwW2 ah0UOybo+9cGrmPqOmpiVe3FFc6voAU= =dla+ -----END PGP SIGNATURE----- --a0WqJfirCmr9EVhF-- --===============4433632581817802485== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4433632581817802485==--