From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 644BDC47DAF for ; Fri, 19 Jan 2024 13:20:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z9DZNWzNPJ9QZloMSq1z9Sk6DTLhgfT2saCynEE/DAU=; b=uo0YXDUMSWKnp5 iNf+jeaUbdau8KCTUEKXUzguEih2h6/aPtI0hatKIJF0aIbsM2ni8TK0zRMNfhXmdKyohm9+iLWSS PncrwYzarITGH29+LCUVn+rI9mdMSTC4haJgH2xT4xPj1clGiCdapo9c3XVelRF+LBAUtNEU26t4e PfzFTYJu2TWBQq9rpyfn8ZVYybQht49ezgNql+3NF325W5C+ZZ236BMGdajMYBi3n8oUrM7eoOKMO FTV4r42oGji8ZrQi8fdEJkS48G2wkg0qwFsYhGhZ93kuaSmahHSuR0qhHU/fzqTt/TLkxS6z2OLsG skDJmKOlHlHZsfj7krTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rQomc-005gQW-2g; Fri, 19 Jan 2024 13:19:42 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rQomY-005gP9-2s for linux-arm-kernel@lists.infradead.org; Fri, 19 Jan 2024 13:19:41 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 40JDJXjs130594; Fri, 19 Jan 2024 07:19:33 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1705670373; bh=OrSnCm6YBe7QCbBAO+laLJ5oHXHnkGr4ZsBxFZ4MU0M=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=PZnJIJGt0VKAK9AVSh6xflgjo79zKD1emDuYaTOw3g1D/brtzyCVQYcWc/CyJIb6J 6hghM+r2o6581TEVIdAyCZ5NsDK2ULjSJlgu4LLbSAQ16dk02hNbchrNEd7f0GMqlO rDjAy7nGpgyMwHFVszdu6qPx17EqIv9qAIEXwCxA= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 40JDJXGF087733 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 19 Jan 2024 07:19:33 -0600 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 19 Jan 2024 07:19:33 -0600 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 19 Jan 2024 07:19:33 -0600 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 40JDJXsY019795; Fri, 19 Jan 2024 07:19:33 -0600 Date: Fri, 19 Jan 2024 07:19:33 -0600 From: Nishanth Menon To: Chintan Vankar CC: Conor Dooley , Krzysztof Kozlowski , Rob Herring , Tero Kristo , Vignesh Raghavendra , , , , , , , , , Subject: Re: [PATCH v2 3/5] arm64: dts: ti: k3-j784s4-main: Add CPSW9G nodes Message-ID: <20240119131933.zr3pkehssn4yr64f@cosponsor> References: <20240118094454.2656734-1-c-vankar@ti.com> <20240118094454.2656734-4-c-vankar@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240118094454.2656734-4-c-vankar@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240119_051939_014980_53EB0567 X-CRM114-Status: GOOD ( 17.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15:14-20240118, Chintan Vankar wrote: > From: Siddharth Vadapalli > > J784S4 SoC has a 9 port Ethernet Switch instance with 8 external > ports and 1 host port, referred to as CPSW9G. > > Add device-tree nodes for CPSW9G and disable it by default. > Device-tree overlays will be used to enable it. > > Signed-off-by: Siddharth Vadapalli > Signed-off-by: Chintan Vankar > --- > arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 114 +++++++++++++++++++++ > 1 file changed, 114 insertions(+) Any reason why we cant squash this to previous patch with something like "Add main cpsw nodes" ? > > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi > index 191fdbe02877..9aebce8a51ab 100644 > --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi > @@ -54,6 +54,13 @@ cpsw1_phy_gmii_sel: phy@4034 { > #phy-cells = <1>; > }; > > + cpsw0_phy_gmii_sel: phy@4044 { > + compatible = "ti,j784s4-cpsw9g-phy-gmii-sel"; > + ti,qsgmii-main-ports = <7>, <7>; > + reg = <0x4044 0x20>; > + #phy-cells = <1>; > + }; > + > serdes_ln_ctrl: mux-controller@4080 { > compatible = "reg-mux"; > reg = <0x00004080 0x30>; > @@ -1248,6 +1255,113 @@ cpts@310d0000 { > }; > }; > > + main_cpsw0: ethernet@c000000 { > + compatible = "ti,j784s4-cpswxg-nuss"; > + reg = <0x00 0xc000000 0x00 0x200000>; > + reg-names = "cpsw_nuss"; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges = <0x00 0x00 0x00 0xc000000 0x00 0x200000>; > + dma-coherent; > + clocks = <&k3_clks 64 0>; > + clock-names = "fck"; > + power-domains = <&k3_pds 64 TI_SCI_PD_EXCLUSIVE>; > + > + dmas = <&main_udmap 0xca00>, > + <&main_udmap 0xca01>, > + <&main_udmap 0xca02>, > + <&main_udmap 0xca03>, > + <&main_udmap 0xca04>, > + <&main_udmap 0xca05>, > + <&main_udmap 0xca06>, > + <&main_udmap 0xca07>, > + <&main_udmap 0x4a00>; > + dma-names = "tx0", "tx1", "tx2", "tx3", > + "tx4", "tx5", "tx6", "tx7", > + "rx"; > + > + status = "disabled"; > + > + ethernet-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + main_cpsw0_port1: port@1 { > + reg = <1>; > + label = "port1"; > + ti,mac-only; > + status = "disabled"; > + }; > + > + main_cpsw0_port2: port@2 { > + reg = <2>; > + label = "port2"; > + ti,mac-only; > + status = "disabled"; > + }; > + > + main_cpsw0_port3: port@3 { > + reg = <3>; > + label = "port3"; > + ti,mac-only; > + status = "disabled"; > + }; > + > + main_cpsw0_port4: port@4 { > + reg = <4>; > + label = "port4"; > + ti,mac-only; > + status = "disabled"; > + }; > + > + main_cpsw0_port5: port@5 { > + reg = <5>; > + label = "port5"; > + status = "disabled"; > + }; > + > + main_cpsw0_port6: port@6 { > + reg = <6>; > + label = "port6"; > + status = "disabled"; > + }; > + > + main_cpsw0_port7: port@7 { > + reg = <7>; > + label = "port7"; > + status = "disabled"; > + }; > + > + main_cpsw0_port8: port@8 { > + reg = <8>; > + label = "port8"; > + status = "disabled"; > + }; > + }; > + > + main_cpsw0_mdio: mdio@f00 { > + compatible = "ti,cpsw-mdio","ti,davinci_mdio"; > + reg = <0x00 0xf00 0x00 0x100>; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&k3_clks 64 0>; > + clock-names = "fck"; > + bus_freq = <1000000>; > + status = "disabled"; > + }; > + > + cpts@3d000 { > + compatible = "ti,am65-cpts"; > + reg = <0x00 0x3d000 0x00 0x400>; > + clocks = <&k3_clks 64 3>; > + clock-names = "cpts"; > + interrupts-extended = <&gic500 GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "cpts"; > + ti,cpts-ext-ts-inputs = <4>; > + ti,cpts-periodic-outputs = <2>; > + }; > + }; > + > main_cpsw1: ethernet@c200000 { > compatible = "ti,j721e-cpsw-nuss"; > #address-cells = <2>; > -- > 2.34.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel