From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9463C46CD2 for ; Tue, 23 Jan 2024 00:40:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hreNJ0FbRyhDHKA6k3D6kUNoN/f2OZ767S7GyTuh7q0=; b=KOw5Ut1OZabrwO UyCwK3+mCmnhr3vXauXxZUSCP3TFZdFd8061zamAbFobXH/0oNLuEDeLtqywztTYuxWuVhE8tRf0Z YQQ8dJ7ZsKumwik+6Od2nJ2oIcZ2TTRGRl6RK/dMxwVYtvu3asQKOsMbbmcFOiN4B0Zm1IktOhbmP nu9uwhdfBW+1PrCXoxo+hKXgAPOjuM5PWdAPsfYoOq90jGPA+uRu9ehNjYTHHPQRL1wJBYl35w59O fuNX6AJp7wdzTS58dH59fj3p/Qa/a/D2DnfPSyhv/6qQ1F0/+uv47X3T/S+zxGDNkk/0uETuOEeJg dvh4gqn73vvOpwZyqsEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rS4pd-00EdAE-0Q; Tue, 23 Jan 2024 00:40:01 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rS4pZ-00Ed7n-1u for linux-arm-kernel@lists.infradead.org; Tue, 23 Jan 2024 00:39:59 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C93DE1FB; Mon, 22 Jan 2024 16:40:34 -0800 (PST) Received: from minigeek.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C62203F73F; Mon, 22 Jan 2024 16:39:46 -0800 (PST) Date: Tue, 23 Jan 2024 00:38:53 +0000 From: Andre Przywara To: Chen-Yu Tsai Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jernej Skrabec , Samuel Holland , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Vinod Koul , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-sound@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/7] ASoC: sunxi: sun4i-spdif: Add support for Allwinner H616 Message-ID: <20240123003853.3da2ff57@minigeek.lan> In-Reply-To: <20240122170518.3090814-4-wens@kernel.org> References: <20240122170518.3090814-1-wens@kernel.org> <20240122170518.3090814-4-wens@kernel.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.2.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240122_163957_675206_C31FCE42 X-CRM114-Status: GOOD ( 21.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 23 Jan 2024 01:05:14 +0800 Chen-Yu Tsai wrote: Hi Chen-Yu, thanks for posting this! > From: Chen-Yu Tsai > > The SPDIF hardware block found in the H616 SoC has the same layout as > the one found in the H6 SoC, except that it is missing the receiver > side. > > Since the driver currently only supports the transmit function, support > for the H616 is identical to what is currently done for the H6. I compared the OWA manual sections of the H6 and the H616 manuals, and can confirm that indeed the H616 is the same as the H6, minus the RX part: > Signed-off-by: Chen-Yu Tsai Reviewed-by: Andre Przywara Cheers, Andre > --- > sound/soc/sunxi/sun4i-spdif.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c > index 702386823d17..f41c30955857 100644 > --- a/sound/soc/sunxi/sun4i-spdif.c > +++ b/sound/soc/sunxi/sun4i-spdif.c > @@ -577,6 +577,11 @@ static const struct of_device_id sun4i_spdif_of_match[] = { > .compatible = "allwinner,sun50i-h6-spdif", > .data = &sun50i_h6_spdif_quirks, > }, > + { > + .compatible = "allwinner,sun50i-h616-spdif", > + /* Essentially the same as the H6, but without RX */ > + .data = &sun50i_h6_spdif_quirks, > + }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, sun4i_spdif_of_match); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel