From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3F45C46CD2 for ; Tue, 23 Jan 2024 00:44:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YoiYQS+NEo/H4InT/YSnxClujsw6c+biI2B2wEGi+hk=; b=cHUNqg4cuSeDSt jXt+jXdTKsufh8rXSczxdmKodj+7IqiEj36MugyTR9pFeH1QIGa7BToSyIsqGX3MgJeJ+bNvx4fhS uGfsuR+1ndMm6egGn/XAS1TkxVTk+6LWANlEKp5RIiYN+qQV5SzyI9jVbgp11FHAejGW7578Iuggm sFbe0+UfFZqwDJFXt3zK9rugRUj8dvmc+k74p5Uljv/HHn13S1dBMLgV0L7S7ADluBMPm4OG19WBt 0z1S9EsE1U913D1hR/NyncbUPaJPB8ASWtTvlUeGoFWYjSl8MvzhDtUgcEI3EFHEUwXMdPQ9CHpT0 1WegMvt4NkY6lf5Xsfvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rS4th-00Ee6u-0R; Tue, 23 Jan 2024 00:44:13 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rS4td-00Ee5l-30 for linux-arm-kernel@lists.infradead.org; Tue, 23 Jan 2024 00:44:11 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 91A0E1FB; Mon, 22 Jan 2024 16:44:52 -0800 (PST) Received: from minigeek.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A275B3F73F; Mon, 22 Jan 2024 16:44:04 -0800 (PST) Date: Tue, 23 Jan 2024 00:43:15 +0000 From: Andre Przywara To: Chen-Yu Tsai Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jernej Skrabec , Samuel Holland , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Vinod Koul , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-sound@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] arm64: dts: allwinner: h616: Add SPDIF device node Message-ID: <20240123004315.068adcba@minigeek.lan> In-Reply-To: <20240122170518.3090814-8-wens@kernel.org> References: <20240122170518.3090814-1-wens@kernel.org> <20240122170518.3090814-8-wens@kernel.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.2.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240122_164410_012007_4A8B2517 X-CRM114-Status: GOOD ( 15.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 23 Jan 2024 01:05:18 +0800 Chen-Yu Tsai wrote: Hi, > From: Chen-Yu Tsai > > The H616 SoC has an SPDIF transmitter hardware block, which has the same > layout as the one in the H6, minus the receiver side. > > Add a device node for it, and a default pinmux. > > Signed-off-by: Chen-Yu Tsai Compared the details against the manual, the clock driver, and the binding, they match: Reviewed-by: Andre Przywara Cheers, Andre > --- > .../arm64/boot/dts/allwinner/sun50i-h616.dtsi | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi > index a0268439f3be..fd4c080b8e62 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi > @@ -253,6 +253,11 @@ spi1_cs0_pin: spi1-cs0-pin { > function = "spi1"; > }; > > + spdif_tx_pin: spdif-tx-pin { > + pins = "PH4"; > + function = "spdif"; > + }; > + > uart0_ph_pins: uart0-ph-pins { > pins = "PH0", "PH1"; > function = "uart0"; > @@ -550,6 +555,21 @@ mdio0: mdio { > }; > }; > > + spdif: spdif@5093000 { > + compatible = "allwinner,sun50i-h616-spdif"; > + reg = <0x05093000 0x400>; > + interrupts = ; > + clocks = <&ccu CLK_BUS_SPDIF>, <&ccu CLK_SPDIF>; > + clock-names = "apb", "spdif"; > + resets = <&ccu RST_BUS_SPDIF>; > + dmas = <&dma 2>; > + dma-names = "tx"; > + pinctrl-names = "default"; > + pinctrl-0 = <&spdif_tx_pin>; > + #sound-dai-cells = <0>; > + status = "disabled"; > + }; > + > usbotg: usb@5100000 { > compatible = "allwinner,sun50i-h616-musb", > "allwinner,sun8i-h3-musb"; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel