From: Kees Cook <keescook@chromium.org>
To: Ard Biesheuvel <ardb+git@google.com>
Cc: linux-arm-kernel@lists.infradead.org, will@kernel.org,
catalin.marinas@arm.com, mark.rutland@arm.com,
Ard Biesheuvel <ardb@kernel.org>,
Sami Tolvanen <samitolvanen@google.com>
Subject: Re: [PATCH 0/2] arm64: Fix for dynamic SCS under full LTO take #2
Date: Tue, 23 Jan 2024 14:27:55 -0800 [thread overview]
Message-ID: <202401231427.3243ECF@keescook> (raw)
In-Reply-To: <20240123133052.1417449-4-ardb+git@google.com>
On Tue, Jan 23, 2024 at 02:30:53PM +0100, Ard Biesheuvel wrote:
> From: Ard Biesheuvel <ardb@kernel.org>
>
> Disabling unwind table generation turns out not to fix the issue with
> full LTO and dynamic shadow call stack, as reported by Sami. So instead,
> disable LTO for the compilation unit in question.
>
> Implemented as a revert + new patch so that only the real fix needs to
> go to -stable.
>
> Cc: Sami Tolvanen <samitolvanen@google.com>
> Cc: Kees Cook <keescook@chromium.org>
>
> Ard Biesheuvel (2):
> arm64: Revert "scs: Work around full LTO issue with dynamic SCS"
> arm64: scs: Disable LTO for SCS patching code
>
> arch/arm64/kernel/Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Thanks for figuring this out!
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-23 22:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 13:30 [PATCH 0/2] arm64: Fix for dynamic SCS under full LTO take #2 Ard Biesheuvel
2024-01-23 13:30 ` [PATCH 1/2] arm64: Revert "scs: Work around full LTO issue with dynamic SCS" Ard Biesheuvel
2024-01-23 13:30 ` [PATCH 2/2] arm64: scs: Disable LTO for SCS patching code Ard Biesheuvel
2024-01-23 17:06 ` [PATCH 0/2] arm64: Fix for dynamic SCS under full LTO take #2 Sami Tolvanen
2024-01-23 22:27 ` Kees Cook [this message]
2024-01-30 13:14 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202401231427.3243ECF@keescook \
--to=keescook@chromium.org \
--cc=ardb+git@google.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=samitolvanen@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox