From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D0D2C47DDB for ; Tue, 23 Jan 2024 22:28:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GwbltpsEiZaePE99UyP0uZNpg+3/sPn9+TiFwLQWiM0=; b=enndNIhwOd2cmV dCdQau/q6Z4IuAbS4dFssi6pOd3MpYmgxR3NG8wTGwnYR5VMTP8NgP6i8+g3600DUXaxB2tkEy+8Z advyvgE/hSq/EEAM1gTECfQdLtPeQcNx/1EyfIXW++yeOj5+SBx9bs3Jn8TTOoOXtgdkjW/jBUA3Z QVcCywznWzI6+M7O91SCax44mDgUO4gpj0K44DS4JWm0EVg/wyFpGsDAQIlZ0eLXrTqfvfwU9B2ww mJ9lrTnSASCavZ9x5oSSP6kK22heILxsIKlkNubg0YcnNWewyzz25gKjsXJx0lIuHDlv1eZMOHhUf NB3RHNLmOMXaMOAc2i7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSPFR-000gGg-2p; Tue, 23 Jan 2024 22:28:01 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSPFP-000gE2-2k for linux-arm-kernel@lists.infradead.org; Tue, 23 Jan 2024 22:28:01 +0000 Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1d74045c463so19262805ad.3 for ; Tue, 23 Jan 2024 14:27:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1706048876; x=1706653676; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YMQ/TWSkeYElpUXZRI4ycciMc9TiqGfWBjlCLnroBug=; b=MRnITdRGN+DskKhJtNH6SiR3ko2lrd0pU2LC3hgOLy0EIGmggK/3V6t6NUIdN2dmCQ 8bticfQk5XS+nVPsY02ma3HjBP3jFwKY/9FT7QttMFYdw4hQNLRHCdNWN2bSg8u/vGlT 0yJ6bpPuf0XoiZpFiLLecE04tsuDc2/AEaCoU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706048876; x=1706653676; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YMQ/TWSkeYElpUXZRI4ycciMc9TiqGfWBjlCLnroBug=; b=J3XbHQHi429SGRRUsBPgWN3I4lrGNljKzYrGsUHpIu9zWWz5ctDyUDnh7JNF58X3Ow m9MnKY4jsh7O6phuTXRGu2gxN9XP5zN9WnMb5V9H4m+9oBw4yU433ZKy2fNUG2GyWBGi b4RFQx0aQZftK0KHKB/6eIXBl88TKpDLPcqDgBEXGZMgcZ4bM3TK4uQ7FG6JleQsXGVJ OmCdFEBRbIi/f1tc6LBBj/VfFZgn+/Z1b5e3m09mSFWp8pSgJuBzo07u43rGP2v67f2q FT7vKdHggNCV8GRMhn4rfkA8LrIcLZTRek0nYgiqjIECZJ5gCtC/6l/aJTy/Jzslw/YH IFkg== X-Gm-Message-State: AOJu0YyLtGygrASbdBOUuoX83Mrl+UZMm6vdKwufGnYWdydVzsW9PC+t 6OPdGp6P+RVmePkzv3SjBdytaigRxC2B/knTL9rHQfy1eIMAVQ29Lkd7l5YYsQ== X-Google-Smtp-Source: AGHT+IHFeQf9aQs4rmwthbpiEbqe72L60ZCsEQe5Akn770ZOrVCwLy2Co8Tnz1sJLIE8MD+LVWkRTw== X-Received: by 2002:a17:903:41c1:b0:1d7:2d5e:5850 with SMTP id u1-20020a17090341c100b001d72d5e5850mr5237927ple.100.1706048876666; Tue, 23 Jan 2024 14:27:56 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id k13-20020a170902f28d00b001d70602f550sm9256907plc.27.2024.01.23.14.27.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 14:27:55 -0800 (PST) Date: Tue, 23 Jan 2024 14:27:55 -0800 From: Kees Cook To: Ard Biesheuvel Cc: linux-arm-kernel@lists.infradead.org, will@kernel.org, catalin.marinas@arm.com, mark.rutland@arm.com, Ard Biesheuvel , Sami Tolvanen Subject: Re: [PATCH 0/2] arm64: Fix for dynamic SCS under full LTO take #2 Message-ID: <202401231427.3243ECF@keescook> References: <20240123133052.1417449-4-ardb+git@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240123133052.1417449-4-ardb+git@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_142759_904373_A2307CEB X-CRM114-Status: GOOD ( 14.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 23, 2024 at 02:30:53PM +0100, Ard Biesheuvel wrote: > From: Ard Biesheuvel > > Disabling unwind table generation turns out not to fix the issue with > full LTO and dynamic shadow call stack, as reported by Sami. So instead, > disable LTO for the compilation unit in question. > > Implemented as a revert + new patch so that only the real fix needs to > go to -stable. > > Cc: Sami Tolvanen > Cc: Kees Cook > > Ard Biesheuvel (2): > arm64: Revert "scs: Work around full LTO issue with dynamic SCS" > arm64: scs: Disable LTO for SCS patching code > > arch/arm64/kernel/Makefile | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Thanks for figuring this out! Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel