From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F25F4C47258 for ; Tue, 23 Jan 2024 19:49:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P4SL8pNl6iyCBoU2DI35EnFr+8Ap83bvufVKhGS9+BQ=; b=W7uC5rXinDKQLv j7UE48+bWxsmdrqz5FtLyQI/5Q1qsDPVks+Oxze85Ha9EcDyNhSr1qNljLnG/eL+9oV2X8CbWAtj9 CKd41D5RturaohfzSbt+c5K/mCBybUMi61T0ISu5gwv4ayg0lkFh2E0pWb36P+2hWMOCftBSZNob7 t3CPxnO56GWbmqfGDHo6aivNw/louWSI9izB8OTVdYLWSktOmN4IYh/HEx1jT8hVCPuM1ySQcEc4X iRKSP4QU/RCLONOL9PA/HPbdbskZYtMxrj510oneBtYjM9r7DqrnO4st2ECPY/Q+qRJjA7oczJKjc m9JPbWt9ODabecsagURg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSMm1-000JXi-0U; Tue, 23 Jan 2024 19:49:29 +0000 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSMly-000JXA-1Q for linux-arm-kernel@lists.infradead.org; Tue, 23 Jan 2024 19:49:27 +0000 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-337cc8e72f5so4319844f8f.1 for ; Tue, 23 Jan 2024 11:49:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706039362; x=1706644162; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4qE28dlWF6DGyTTPmng9ihaceKW+IRRh93UPoev7s84=; b=n4ZJV71NdaP182jVlmfAvEZR8kCUo4OcS/NJ54lOMvwMJAXWJb7UQwHd3iGWbLQdon GrW26fHTzcf8mcBRId4IX/oe9KWlkzTgoAv+3O49dcmvaojWq+igAaB1b6a81WtYeLan SqG3huFNz0Db5UJhSRONrNg0BbK9C07byPlAsLBFLRu1BgFU1tbmJzQoD1ytNaWU+URU LpBqNyYymTkr7ehsd5z+WaWB6MO06uuKg2TXoHGxERF4saKULObnmb1D3pMfDP9WMulf TMM7XmmUEihYtWA/SEgzX0dCLF3+HGB89GY9yhQSCMiXeScmn9NUoL5vG2TZ0nc7ey6q bUdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706039362; x=1706644162; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4qE28dlWF6DGyTTPmng9ihaceKW+IRRh93UPoev7s84=; b=Dk4va9pieLgewHp4n55C0hbJGLgZdmLd2bqt3swPN+W6r1b8l4l+ziCy8rWFbUFlIg uawcOe7/lTNenbeYVZhFnBRUw5e9OJ48ql7anHV4JcnGioT+DFe9DG0QwAb2fc95bKY2 4SQjffzwZWRPVbulvPGb61OSPVwf0kVlGHi5yIDnIPdgPy5iO5KGIvYH96ArOHxGezWp 1SwAT3Q9LRbZjSTYEp3RUb9Mk7NJHBzkihvDJPXizIAdLb1LVxpge4UxQIYxWeGBvsjk Az5lzhfeSkS0JLF38lUAwN94gGdgXN/K28YR21hxiNepWiM6AKZkNsehCwLEpK62nXAT 4o7Q== X-Gm-Message-State: AOJu0YwF1yVnkkejWhJqRhsejKnrig3AtfJQQLJNmWpGqEyRkeESBQMH wgJXV7H2k54Hu0G0VVvgpjR1cBhZ+7umlPGjFTQtK1UiPaB8o7Zrjn5By8orpN4= X-Google-Smtp-Source: AGHT+IFumTc9KtJ/kCVLcF8NzAKi14YhOjo/H7kRpM6sr9VqFP25QaURtKyQ3GiPFue0ZdupifoJrg== X-Received: by 2002:adf:f70f:0:b0:337:c93d:fe44 with SMTP id r15-20020adff70f000000b00337c93dfe44mr2726111wrp.58.1706039362497; Tue, 23 Jan 2024 11:49:22 -0800 (PST) Received: from myrica ([2.221.137.100]) by smtp.gmail.com with ESMTPSA id e30-20020a5d595e000000b00339237a2752sm10844430wri.33.2024.01.23.11.49.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 11:49:22 -0800 (PST) Date: Tue, 23 Jan 2024 19:49:31 +0000 From: Jean-Philippe Brucker To: Sebastian Ene Cc: maz@kernel.org, catalin.marinas@arm.com, will@kernel.org, joro@8bytes.org, robin.murphy@arm.com, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, smostafa@google.com, dbrazdil@google.com, ryan.roberts@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev Subject: Re: [RFC PATCH 12/45] KVM: arm64: pkvm: Unify pkvm_pkvm_teardown_donated_memory() Message-ID: <20240123194931.GB40099@myrica> References: <20230201125328.2186498-1-jean-philippe@linaro.org> <20230201125328.2186498-13-jean-philippe@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_114926_490310_C1CA2B8B X-CRM114-Status: GOOD ( 14.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Seb, On Mon, Jan 15, 2024 at 02:33:50PM +0000, Sebastian Ene wrote: > > int __pkvm_teardown_vm(pkvm_handle_t handle) > > { > > size_t vm_size, last_ran_size; > > @@ -813,19 +802,18 @@ int __pkvm_teardown_vm(pkvm_handle_t handle) > > vcpu_mc = &hyp_vcpu->vcpu.arch.pkvm_memcache; > > while (vcpu_mc->nr_pages) { > > addr = pop_hyp_memcache(vcpu_mc, hyp_phys_to_virt); > > - push_hyp_memcache(mc, addr, hyp_virt_to_phys); > > - unmap_donated_memory_noclear(addr, PAGE_SIZE); > > + pkvm_teardown_donated_memory(mc, addr, 0); > > Here we probably need to pass PAGE_SIZE as an argument instead of "0" > to make sure that we clear out the content of the page before tearing it > down. But since it's replacing unmap_donated_memory_noclear(), would that be a change of behavior? That would be a separate patch because this one is just trying to refactor things. Thanks, Jean > > > } > > > > - teardown_donated_memory(mc, hyp_vcpu, sizeof(*hyp_vcpu)); > > + pkvm_teardown_donated_memory(mc, hyp_vcpu, sizeof(*hyp_vcpu)); > > } > > > > last_ran_size = pkvm_get_last_ran_size(); > > - teardown_donated_memory(mc, hyp_vm->kvm.arch.mmu.last_vcpu_ran, > > - last_ran_size); > > + pkvm_teardown_donated_memory(mc, hyp_vm->kvm.arch.mmu.last_vcpu_ran, > > + last_ran_size); > > > > vm_size = pkvm_get_hyp_vm_size(hyp_vm->kvm.created_vcpus); > > - teardown_donated_memory(mc, hyp_vm, vm_size); > > + pkvm_teardown_donated_memory(mc, hyp_vm, vm_size); > > hyp_unpin_shared_mem(host_kvm, host_kvm + 1); > > return 0; > > > > -- > > 2.39.0 > > > > Thanks, > Seb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel