From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15471C47258 for ; Tue, 23 Jan 2024 19:51:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i8o1KOlZYvcVQ8YST4lGopzjmX/8rgS+3FBz8RfFux0=; b=DBiabkxZy/rBQ+ 6e89A/juC6PCUi1s4+3MCBrYfOxuYWneM+f42Oo6fnDzx7cDogcYVlM9p5A8LiXNsFTIBj3/ReKEJ +YaXrO6zldf/6K/5gtovF4uFCklM6JHCF6lg6US/d70Vg91Zqd7TZ6il7R2spgTtJMyaxgGyF9FBV IQ9YcynMpcZ0d1smCwRMz1jcRGYN6RxocbsvKJ0J++Esp43HWPJVEPo5bhWYOQ3WhXrRzeHlr98iZ JG2Q4BeQvYIZ+XBK0smCvAi57RfcqEvL/a2RUfSVAqTTLoQzbzbgIFXo0in+R6vYke/RYdEnElAC5 6tkx44XMtLwXGGRNn+/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSMnT-000JjB-2G; Tue, 23 Jan 2024 19:50:59 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSMnO-000Jhh-2x for linux-arm-kernel@lists.infradead.org; Tue, 23 Jan 2024 19:50:56 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 9F9E0CE2FAE; Tue, 23 Jan 2024 19:50:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDEEDC433C7; Tue, 23 Jan 2024 19:50:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706039451; bh=JdM9TTZCWN64d8b7V18qvRomhjSHitoxtF6sWalz8RI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bwKr99PE3PLFylNmMkGyJg3i1edGMRoBYyQsyR4msDUYiyaKA+xo0PT+Ml39I6VCz 5KJzNMIGRbczBN3pyGyY4f2HijZ2uB9vOV0Elu/ityI2QNcsEeQGkNevri9zsn9HSS gORdqLmBQa58bsMPQMyiR2kCiZfserJZUXtRJFgvzXFKQ3X/dMnxzD7iKS7O1edEpW 52h+gTd7u/ldFMhdOpaGqpdravlexlwdaNkLrCZIbThxPgdgATJ4S2FfA6viLqqaOr ogvZG+zNWX8wyKhfsUI8v3yjgWBNgESlASo9SAoJIqviMl/MhG+oH/bBFBWaJwGDqA Vt5yFiXXnLoCw== Date: Tue, 23 Jan 2024 19:50:46 +0000 From: Simon Horman To: Furong Xu <0x1207@gmail.com> Cc: "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com, rock.xu@nio.com Subject: Re: [PATCH net] net: stmmac: xgmac: fix safety error descriptions Message-ID: <20240123195046.GQ254773@kernel.org> References: <20240123085037.939471-1-0x1207@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240123085037.939471-1-0x1207@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_115055_155719_58317107 X-CRM114-Status: GOOD ( 11.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 23, 2024 at 04:50:37PM +0800, Furong Xu wrote: > Commit 56e58d6c8a56 ("net: stmmac: Implement Safety Features in > XGMAC core") prints safety error descriptions when safety error assert, > but missed some special errors, and mixed correctable errors and > uncorrectable errors together. > This patch complete the error code list and print the type of errors. > > Fixes: 56e58d6c8a56 ("net: stmmac: Implement Safety Features in XGMAC core") > Signed-off-by: Furong Xu <0x1207@gmail.com> I'm not entirely sure this is a fix rather than an enhancement. But the code change itself looks good to me. Reviewed-by: Simon Horman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel