From: Nishanth Menon <nm@ti.com>
To: Jayesh Choudhary <j-choudhary@ti.com>
Cc: Vaishnav Achath <vaishnav.a@ti.com>, <vigneshr@ti.com>,
<kristo@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<bb@ti.com>, <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<u-kumar1@ti.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-am62p-mcu/wakeup: Disable MCU and wakeup R5FSS nodes
Date: Wed, 24 Jan 2024 11:21:51 -0600 [thread overview]
Message-ID: <20240124172151.ngxaq6k5tnvsx4jr@proud> (raw)
In-Reply-To: <0fcec921-0220-4251-afa4-44db5e80d2ef@ti.com>
On 11:26-20240124, Jayesh Choudhary wrote:
> Hello Vaishnav,
>
> On 21/01/24 19:10, Vaishnav Achath wrote:
> > K3 Remoteproc R5 driver requires reserved memory carveouts and
> > mailbox configuration to instantiate the cores successfully.
> > Since this is a board level dependency, keep the R5 subsytem
> > disabled at SoC dtsi, otherwise it results in probe errors like
> > below during AM62P SK boot:
> >
> > r5fss@79000000: reserved memory init failed, ret = -22
> > r5fss@79000000: k3_r5_cluster_rproc_init failed, ret = -22
> > r5fss@78000000: reserved memory init failed, ret = -22
> > r5fss@78000000: k3_r5_cluster_rproc_init failed, ret = -22
> >
> > Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs")
> >
> > Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
>
> Reviewed-by: Jayesh Choudhary <j-choudhary@ti.com>
>
> > ---
> > arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi | 2 ++
> > arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi | 1 +
> > 2 files changed, 3 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
> > index c4b0b91d70cf..14eb9ba836d3 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
> > @@ -187,6 +187,8 @@ mcu_r5fss0: r5fss@79000000 {
> > ranges = <0x79000000 0x00 0x79000000 0x8000>,
> > <0x79020000 0x00 0x79020000 0x8000>;
> > power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>;
> > + status = "disabled";
> > +
> > mcu_r5fss0_core0: r5f@79000000 {
> > compatible = "ti,am62-r5f";
> > reg = <0x79000000 0x00008000>,
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> > index 19f42b39394e..10a7059b2d9b 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> > @@ -78,6 +78,7 @@ wkup_r5fss0: r5fss@78000000 {
> > ranges = <0x78000000 0x00 0x78000000 0x8000>,
> > <0x78100000 0x00 0x78100000 0x8000>;
> > power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>;
> > + status = "disabled";
Is there a reason for difference in white space addition?
> > wkup_r5fss0_core0: r5f@78000000 {
> > compatible = "ti,am62-r5f";
>
> Thanks.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-24 17:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-21 13:40 [PATCH] arm64: dts: ti: k3-am62p-mcu/wakeup: Disable MCU and wakeup R5FSS nodes Vaishnav Achath
2024-01-24 5:56 ` Jayesh Choudhary
2024-01-24 17:21 ` Nishanth Menon [this message]
2024-01-25 5:47 ` Vaishnav Achath
2024-01-25 13:43 ` Nishanth Menon
2024-01-25 14:04 ` Nishanth Menon
2024-01-26 7:56 ` Wadim Egorov
2024-02-06 8:40 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240124172151.ngxaq6k5tnvsx4jr@proud \
--to=nm@ti.com \
--cc=bb@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j-choudhary@ti.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=u-kumar1@ti.com \
--cc=vaishnav.a@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox