From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3F52C47E49 for ; Wed, 24 Jan 2024 17:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4YZ6XbllAUMy9bsCIcbwNiq4uxIqVEU+miqK4zN1d/c=; b=SNZDWljnTCVorX LccYHqVi4PuJISgEpot/fyQ9Moo69NN6j+TbL1OTvLEUOu9gAlXVEEyddrJK/edL3aR4y7C7UgrB0 2fJSwznMXo2Xl3vCDb5TCym7VCUHRhgSGIYRFkUg7cWQ3jXXUKB3W7+u8QL1njy+FXY1Gw03MGR7K 41qA73MYvZqt64Iz6vkoskP85hsBzwWqBDRCTkMzRECXStK47lhHBcu2t3S2aQjjHMu75h3V/0TAh n54F08HETHHxiDEc/BYUh3csEpF9W3qpGr5298lbzlionIg9oU8lB/IqiOq5kFZtbPstj6tiefsk8 D/15oRQdZ9QN0SO9gKeQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSgzL-004S6M-1B; Wed, 24 Jan 2024 17:24:35 +0000 Received: from mail-dm6nam11on20610.outbound.protection.outlook.com ([2a01:111:f400:7eaa::610] helo=NAM11-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSgzG-004S1a-0d for linux-arm-kernel@lists.infradead.org; Wed, 24 Jan 2024 17:24:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e0TVtVdyv+mnhiR+O5RnNHaYLqlzUbaHcxYCxiQY1X9djXuh9ssn6aP2I7aZxV+I5+UTbXkfqGLi5/V1JWxwJSwzd22z+8UmyuSEF+UCN49jMfQSbCe/wPFcpEvIHFLmrgK2BC2UCT42vV622Zo0Lx7scshbViD/f1qA+yOwi0Qf6YBpCrP/Rdpjbpz0kPpq1SPUvU7RvjzUbVrkiYFz58cgnT32vBy3Hk+nkTHUWxuG+Xuc+ljLT7s6IhD+o4YMuay+e6XZ+HRA38pjl96yarLhZzgTUGb16Y3xOnL8LqqY5yu3P5a2ub2LRW54Pjr+lgVmB9d3+ZMK6yuLL8qWJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z9rSVxZMSDageEJ0RpjFuzT8MR1tdcJOmTiJ+8GBmmk=; b=W3UfS4QQb2w4nuUjnt42qnzx4TxY4vWX8TAlkPtxMX1JXluxTgXDVKxzzXgY4yJ6CR8Y16pvWpg38cnaurZYXJKQ1S8JZZ2hpTqRtb7k/VN3RhBnb0b5HH3xU54v9kCfeJgtM9/Ab2h6xboueIESt/hvPJg3X0lRQXHuMaXVMdHQbsUjgZTiBOSCBLtswU9EMZ5lzQSBPGjBW3LK/EFIJYUcxbxh8HhqtLl2w6fPHVPU+roCek5M680s3YXJoNCaic09F9vmY4ppR2Tw0GGrfriAf53jftD/ZCOVvrQzI0VKAp3tRNLsgVzKugzgVq3nkqA0sI6p58zeD1LUasoJnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z9rSVxZMSDageEJ0RpjFuzT8MR1tdcJOmTiJ+8GBmmk=; b=ELtrUt+dserzw/Ri6tDRENQbhC6uTR01D6ZENsXFYRxUdtSl+VDXW8ufFSMHsDhq6B3H2SMbyeFnFSxsqUQAsU9woZaIff4wii1tojsVt6lVfGKVTnijkAoyCgYPX+CpDFkQ7PhdGBLhC+58u5aLJ+ierExKIl3fJ7FT73L+ZkeZP4bsGjcXPa0LCe0pbUYzW6ypF/f+sRAaJPGADoqKLndwrPzG6Gb3K2LgamsSjNWcoK61fFXMrH03pKw5acZ4Vu3F6Vja1ivb5h5/SYqtsbZiZG6lQtXzO2gwU4hCqdjs7ZG2afbYkTreDUre8U6pjpyDcssfphOj1w4accXXkw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) by PH8PR12MB6745.namprd12.prod.outlook.com (2603:10b6:510:1c0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.34; Wed, 24 Jan 2024 17:24:20 +0000 Received: from LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::96dd:1160:6472:9873]) by LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::96dd:1160:6472:9873%6]) with mapi id 15.20.7228.022; Wed, 24 Jan 2024 17:24:20 +0000 Date: Wed, 24 Jan 2024 13:24:18 -0400 From: Jason Gunthorpe To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, maz@kernel.org, will@kernel.org Subject: Re: [PATCH] arm64: io: permit offset addressing Message-ID: <20240124172418.GI1455070@nvidia.com> References: <20240124111259.874975-1-mark.rutland@arm.com> Content-Disposition: inline In-Reply-To: <20240124111259.874975-1-mark.rutland@arm.com> X-ClientProxiedBy: DS7PR06CA0036.namprd06.prod.outlook.com (2603:10b6:8:54::14) To LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5869:EE_|PH8PR12MB6745:EE_ X-MS-Office365-Filtering-Correlation-Id: ea7697d3-4190-4f26-d83e-08dc1d014cd6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o92lBT4WS+9BzJpBmrsiKpR+15cdhv+i1TkwHRNhhl4mxKrsfDyT6NyMYPNuW1CeJR8SilU9E8C/lk0CfgHDbuo/ifC6Ih2v2omD7lTfFJoeneOdCENHvMIQ+nQzi5fRquUq6L8TPUujXJqYx0tmmRKC3YF9yUGKJ4IGSbNwb8WEgKO/abkuvs/5rubOyKgQkFIXL+0QtbPqokJ4H1i/9Ca6eMIepORTiZFtJhOtTH5yad7CuGdEVFSdlfciqfpQsQfNFjYMwbA7wjh7Yukkj5J0REi3x1e6Jw8tSyIMYTbssO4NgZHDBqdD0rrfeLV1d2hOQsx/Gwq6xMgLiYgU5nbXkXWwxSZzIpPJc5P3DxJahU2djQRyybVx1iHZGd3Of6rae1Lw71cw07j4NkTO5Qk46olX1FL4N22YFCQ9olIU5cchQxD7ShVdKITBMaBaa/i2klGJNF/JiTznkL8VRPwiQiQaGFYt6ujuHWO5XF7vjxvxolbX84lpCsT3akSWkkVLG0HoLR46nSIiiipzomIlKXh4TamrJjGXHI+WJyVmdjuKruhpqrd7pRgLZByS X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5869.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(346002)(376002)(39860400002)(396003)(366004)(230922051799003)(64100799003)(186009)(451199024)(1800799012)(4326008)(26005)(83380400001)(478600001)(6486002)(6512007)(41300700001)(316002)(2616005)(6506007)(1076003)(38100700002)(33656002)(36756003)(86362001)(2906002)(66556008)(8676002)(66476007)(8936002)(66946007)(5660300002)(6916009)(4744005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?634sc2N1uelvnNoAiF5XN9yRPf4rwVwZ4/Kb6uWHaFVEuaVsOJyxhSxIrUz0?= =?us-ascii?Q?EhGiROMvrocurlOd64xZeepeIaMegNk83GQs4UIHiB5UMB9FkcxkuDKGdZEl?= =?us-ascii?Q?s+yDu9SLbg060YZCilRbLOjqfV8h13bdBfF5SY5yo4KXGAiLgVCkrfoewKgC?= =?us-ascii?Q?tvGivcHr3XNol00pxOVnM8t0PjPfRwfaHCtHAoJuNwVp/AbzHWsYpsvrMG0c?= =?us-ascii?Q?KeQDBpbscFOhnkzRBcsjs9fN0iu0Cs29SYjQFiEFnQzYhlljd5y12fB6YOOW?= =?us-ascii?Q?p3XoT2l4y3qcDdPg4AZA//ZgeHya2RHIqRud65dCHcZZ8HTbckzYJH11EX8K?= =?us-ascii?Q?2fAlRMkYwUlXuEuCOMGzrjeLHsypzuMsQTks+S+q3KnXqyFZFgRZ5MmmiALs?= =?us-ascii?Q?e+RK/gKIj2wL5HXQSyglncxDpOdnQCbMVp1+WkxgH6gi9o+lU2yIcAxbOR7f?= =?us-ascii?Q?wgR8iMJziewPXJ4Y312lY3NlKtW+3cb8uLyWfjV5XFclwOKlKjtVdhxmWE+I?= =?us-ascii?Q?alI8ithhn5F7L+vPPFg7Kpp6gPfcp3IMYF8oRR7gh1WxUhUzOzNPjdvyU98B?= =?us-ascii?Q?Wc+dx4PmYmDbHUcVNjZuB17NvGSeAmJD/iKxOvXE2+yOt4CMpfjYIjAo1LrO?= =?us-ascii?Q?XkuQQXDmpvz4bPGT1R9lJ6Cl0RQTQD0wQAYwKFrisg3jRlkuj8yGrLOv/G4m?= =?us-ascii?Q?0KgneSkZYLJ9af4RfUO3v87RVqj3ePwRsRqtpF4YCNmZHRdnVQnhYIS7+6oh?= =?us-ascii?Q?OMXv8OSZSj/u+IhtOjfdGRftR5EGzVbh41DiR3BYLALAMXf1A4Ee+GLkIPcb?= =?us-ascii?Q?u0JnjE78bQ4v+slsKhh+pQTbsEELkyaZ6aMAFVNrBOtLlj13H9Tj0kUeT7cm?= =?us-ascii?Q?LyNoPSCFOv/GhpGPFHWEQI7LodrxGZViMc8z8SLIOubuA2LthErRYdTTCOpA?= =?us-ascii?Q?M4ciW9dwnnpUlGK56t5O0twU6rD9OhZ3XL9qu25MwrZyemU7IJ1Y93JULcd3?= =?us-ascii?Q?KZKYKUxUFupMXn/FKBG16F0Xcf8H9oWGcIFN6ZrESPQtV4kLdgWRbftOrn5t?= =?us-ascii?Q?VjrLJI3hT7E1Mr6r9gdEi/0B9ilAJB9lb5bUJ2eRKk1PTerpxhyAbu0freHP?= =?us-ascii?Q?ygUr3gCCmiQX7MLVOCAAmBnzsCY46T8qJTOgKqv1Z15vpkx5tGehRfQEpdSe?= =?us-ascii?Q?K9Lo1jEDvuEGOd9vm0LnKVCQa1NlBEZGQLTHSE9cRAUKdowFRn46LqYBHXPw?= =?us-ascii?Q?L7lOJC8qPEJTETz635JoYOdVYAkmBJ8N57VLVBR4jsOFpWNlp276vOCq0Rdb?= =?us-ascii?Q?irjE5lZBGawERqwxzpqC/33wWIhJURsOY2k4XEWl/t81tauftFIyQ0IFu15D?= =?us-ascii?Q?YNRu68X38ZTQFg8PdQCmvsErCvuMYxp5ny4ZuPNK00izF4RNeVvNzZ260EGo?= =?us-ascii?Q?bFW+Ui+aYLsYaqGft8k73PnJZZeLyNlCpgXmC6EVzLjol+ZL19elSpwxGSkd?= =?us-ascii?Q?Rf/usDWHnkxijOlz6XOp/okr5QX//T4ZJ6ntc75wHg/ayrGGO94SqMZuu7rZ?= =?us-ascii?Q?+zSdKPtURmHBa3+YSLYfPFsT0YXV/VayUMCdT9yK?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea7697d3-4190-4f26-d83e-08dc1d014cd6 X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2024 17:24:20.2453 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g2FXpTvfb+dw3KwfdeUFkk7wKyW2P81Dnd9Z1vD55FaUftBeTHyi+pRF+Q2rn26q X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6745 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240124_092430_266169_A9E121F4 X-CRM114-Status: GOOD ( 11.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 24, 2024 at 11:12:59AM +0000, Mark Rutland wrote: > Currently our IO accessors all use register addressing without offsets, > but we could safely use offset addressing (without writeback) to > simplify and optimize the generated code. > Aside from the better code generation, there should be no functional > change as a result of this patch. I have lightly tested this patch, > including booting under KVM (where some devices such as PL011 are > emulated). Reviewed-by: Jason Gunthorpe FWIW I have had 0-day compile test a very similar patch with no compilation problems. I also got similar code savings results. However, I noticed that clang 17.0.6 at least does not have any benifit, I suppose it is a missing compiler feature. Finally, in my experiments with the WC issue it wasn't entirely helpful, I could not get both gcc and clang always generate load-free store sequences for 64 bytes even with this. Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel