Re: [PATCH v3 09/10] mtd: rawnand: brcmnand: update log level messages

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: David Regan <dregan@broadcom.com>
Cc: dregan@mail.com, richard@nod.at, vigneshr@ti.com,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, computersforpeace@gmail.com,
	kdasu.kdev@gmail.com, linux-mtd@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	joel.peshkin@broadcom.com, tomer.yacoby@broadcom.com,
	dan.beygelman@broadcom.com, william.zhang@broadcom.com,
	anand.gore@broadcom.com, kursad.oney@broadcom.com,
	florian.fainelli@broadcom.com, rafal@milecki.pl,
	bcm-kernel-feedback-list@broadcom.com, andre.przywara@arm.com,
	baruch@tkos.co.il, linux-arm-kernel@lists.infradead.org,
	dan.carpenter@linaro.org
Subject: Re: [PATCH v3 09/10] mtd: rawnand: brcmnand: update log level messages
Date: Wed, 24 Jan 2024 18:37:06 +0100	[thread overview]
Message-ID: <20240124183706.0af8fb90@xps-13> (raw)
In-Reply-To: <20240124030458.98408-10-dregan@broadcom.com>

Hi David,

dregan@broadcom.com wrote on Tue, 23 Jan 2024 19:04:57 -0800:

> Update log level messages so that more critical messages
> can be seen.
> 
> Signed-off-by: David Regan <dregan@broadcom.com>
> Reviewed-by: William Zhang <william.zhang@broadcom.com>
> ---
> Changes in v3: None
> ---
> Changes in v2:
> - Added to patch series
> ---
>  drivers/mtd/nand/raw/brcmnand/brcmnand.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> index 6b5d76eff0ec..a4e311b6798c 100644
> --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> @@ -1143,7 +1143,7 @@ static int bcmnand_ctrl_poll_status(struct brcmnand_host *host,
>  	if ((val & mask) == expected_val)
>  		return 0;
>  
> -	dev_warn(ctrl->dev, "timeout on status poll (expected %x got %x)\n",
> +	dev_err(ctrl->dev, "timeout on status poll (expected %x got %x)\n",

I don't see the point but if you want.

>  		 expected_val, val & mask);
>  
>  	return -ETIMEDOUT;
> @@ -2196,7 +2196,7 @@ static int brcmnand_read(struct mtd_info *mtd, struct nand_chip *chip,
>  				return err;
>  		}
>  
> -		dev_dbg(ctrl->dev, "uncorrectable error at 0x%llx\n",
> +		dev_err(ctrl->dev, "uncorrectable error at 0x%llx\n",

Upper layer will complain, you can keep this at the debug level.

>  			(unsigned long long)err_addr);
>  		mtd->ecc_stats.failed++;
>  		/* NAND layer expects zero on ECC errors */
> @@ -2211,7 +2211,7 @@ static int brcmnand_read(struct mtd_info *mtd, struct nand_chip *chip,
>  			err = brcmnand_read_by_pio(mtd, chip, addr, trans, buf,
>  						   oob, &err_addr);
>  
> -		dev_dbg(ctrl->dev, "corrected error at 0x%llx\n",
> +		dev_info(ctrl->dev, "corrected error at 0x%llx\n",

Definitely not! Way too verbose. Please keep this one as it is.

>  			(unsigned long long)err_addr);
>  		mtd->ecc_stats.corrected += corrected;
>  		/* Always exceed the software-imposed threshold */

Thanks,
Miquèl

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel