From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5002AC47258 for ; Thu, 25 Jan 2024 08:23:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sxQ/G+zEnoqmmXohRuzpytZvwztavD5GjGLbv4ITux8=; b=emjVefNz26iUP9 Zx34iD3K2wMWIi8vHEumy4zuYZjIFnXxab4wJsrdwSWzQmWMPSkFThPZ/8z5KwxMB1w1ujjn26yQ7 S86EBqX67L/9iGL6w6hkIbRXqpktZTQzJWuEKDx38k0Q9rVtxXOUhFCWu+dnDjknLEgF3wVcURA2P CdDHEhDev5VNuJ9fK5TScn8khavCVDMWv1SQ4QWo7CUu57tnFpeGqp0vCfpf+sYA5ezY5GdD1x05D VLi+rY4Idrp2p47Gh0FtaA4ranFLIVwQW/SOIV+Z0pEEGHxJzdldZ+xiEciWZ1ZaRDmr1pfgI79ao purIugeGVQDZZAuueZQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSv0W-007J5s-0g; Thu, 25 Jan 2024 08:22:44 +0000 Received: from relay8-d.mail.gandi.net ([2001:4b98:dc4:8::228]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSv0S-007J4S-1p for linux-arm-kernel@lists.infradead.org; Thu, 25 Jan 2024 08:22:42 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 8423C1BF20B; Thu, 25 Jan 2024 08:22:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1706170956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mfTST55I42VzaDvOMmCyzlbKGUX1F47dp8ViDve0Oew=; b=VR9hxFamSIyqRfpdhMXd39umlqM0aoECc+duJd6cJREz0HlQyGlGRtsmdqXr/S2ezWfgy2 Rb4vMC7/Z1BdyaTxxmQZgA0fQyxbRnTIrKA5xDG5ilbNbIBFBPg27lkYT3c8qjySCWG6QA oAaYT8Qh9NO6qFc+/Gc/Eq6sjHVG+cb8nI8b05agZuxtr1dK6sYeEknmLOVxIPqZ28hS0r rkzjDwo7JCfe7YvWUS5Hu9eiciJGL+YBj3edR3MVpgD8qDuAYjWxX/UKZrPR9EMtzlOFy2 /mrkfdCYP5Z0093MTysFglWyp7SEGR2kcQ6bsC8XuTV1/NyGIIGxOv6ZkkHWWg== Date: Thu, 25 Jan 2024 09:22:25 +0100 From: Maxime Chevallier To: Andrew Lunn Cc: Jakub Kicinski , davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Jesse Brandeburg , Jonathan Corbet , Marek =?UTF-8?B?QmVow7pu?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman Subject: Re: [PATCH net-next v5 07/13] net: ethtool: Introduce a command to list PHYs on an interface Message-ID: <20240125092225.45cdaa09@device-28.home> In-Reply-To: <1092441f-c347-4f61-8405-7cc8a07d5850@lunn.ch> References: <20231221180047.1924733-1-maxime.chevallier@bootlin.com> <20231221180047.1924733-8-maxime.chevallier@bootlin.com> <20240104153401.08ff9809@kernel.org> <20240105104311.03a35622@device-28.home> <2c955f94-7c95-4f66-b739-f0967ec9c171@lunn.ch> <20240124145033.1c711fd1@device-28.home> <1092441f-c347-4f61-8405-7cc8a07d5850@lunn.ch> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.39; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: maxime.chevallier@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240125_002241_053710_F00320AC X-CRM114-Status: GOOD ( 19.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 24 Jan 2024 17:54:53 +0100 Andrew Lunn wrote: > > > Another option might be to add PHY support to netdevsim. Add a debugfs > > > interface to allow you to create arbitrary PHY topologies? You can > > > then even add a test script. > > > > Sorry for the delayed answer, I just took a few hours to give it a try, > > and I was able to spin some very basic PHY support for the netdevsim, > > allowing to attach arbitrary instances of fixed_phy devices. I can > > therefore use that as a mean of testing the dump operation, I'll try to > > include that in the next iteration, that should pave the way for some > > testability of more PHY stuff hopefully. > > Great that you looked at this. > > FYI: Jakub would like to see changes to netdevsim accompanied with > self tests making you of the features you add. There is also now a > build bot running the self tests against net-next, so these tests > should get run quite frequently. No problem, I'll include these as well. I do face a problem with fixed_phy though now that I've played around with it. As fixed_phys share the same global MDIO bus, what can happen is that netdevsim-registered PHYs can starve the dummy MDIO bus by exhausting all 32 mdio addresses, preventing real interfaces from getting their own fixed-phy instance. I'll probably register a dedicated mdio bus per netdevsim (or even per-phy, so that we can imagine controling the returned register values), let's see how it goes. Thanks, Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel