From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD94CC47258 for ; Thu, 25 Jan 2024 13:44:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=73AndagicBxYFLlIZdOkcibN/aCvC8swEZhdeuXzFrE=; b=DewtL8IC9UPkov wRGyus9nl0j/b4L6r12qTJb6jYOOkDFjgIr0p7/qUN9D2M7+bmojjSTMJ58BnzkFgVEiS8y/IH9Wr yozYveS8gc+kZDWg4lSulrDcp38jwDqzpUlkgiNM7L01LY3cqkyedN8JMJoxGkxIodf9kPxeRJ/VF 6cZYsIg7mic3trkrqVDqekEzb+78okThs4vZnMoG4Qs5qW/RD28IUlVtDFAWt5SEbHXmDsrDdvnyL m68zwRy4uWGCgZJJIQl3NcgHR23+PQKsUTNyW2W46t98XirKLmA4ztDKZt0OydyAhAGdJ7p0P/vfw bMvxKFkCgq4HSOQoYu3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rT01I-000000005pM-0TY6; Thu, 25 Jan 2024 13:43:52 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rT01F-000000005no-0ecT for linux-arm-kernel@lists.infradead.org; Thu, 25 Jan 2024 13:43:50 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 40PDhdOt116135; Thu, 25 Jan 2024 07:43:39 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1706190219; bh=r2lrXBYSssJ7OnQOBdMOIycQN4ypBfbTdn/rkYN0/SE=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=YbRem9aByDzpoE7pijyaC//GONs4L5Ju2pRLnJtVATYFMhK5NybYRA8ZUIKDMJ3dt FJnhxYAiB51tQxfUxVvqQCyAylEWG+LisFnPsRVY7DeLWO8lZiPL13mBfmaVb6JnPK APEHuNxpeklLkgenmKKg47EY1lXclSyd1Vngu6BI= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 40PDhdeE089103 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 25 Jan 2024 07:43:39 -0600 Received: from DLEE100.ent.ti.com (157.170.170.30) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 25 Jan 2024 07:43:39 -0600 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 25 Jan 2024 07:43:39 -0600 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 40PDhcnh063679; Thu, 25 Jan 2024 07:43:38 -0600 Date: Thu, 25 Jan 2024 07:43:38 -0600 From: Nishanth Menon To: Vaishnav Achath CC: Jayesh Choudhary , , , , , , , , , , Subject: Re: [PATCH] arm64: dts: ti: k3-am62p-mcu/wakeup: Disable MCU and wakeup R5FSS nodes Message-ID: <20240125134338.5rrentfbw5grbrqk@caution> References: <20240121134017.374992-1-vaishnav.a@ti.com> <0fcec921-0220-4251-afa4-44db5e80d2ef@ti.com> <20240124172151.ngxaq6k5tnvsx4jr@proud> <2291204f-97d5-4887-b68f-8789fe85f838@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2291204f-97d5-4887-b68f-8789fe85f838@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240125_054349_306655_0A3E36FB X-CRM114-Status: GOOD ( 21.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11:17-20240125, Vaishnav Achath wrote: > Hi Nishanth, > > On 24/01/24 22:51, Nishanth Menon wrote: > > On 11:26-20240124, Jayesh Choudhary wrote: > > > Hello Vaishnav, > > > > > > On 21/01/24 19:10, Vaishnav Achath wrote: > > > > K3 Remoteproc R5 driver requires reserved memory carveouts and > > > > mailbox configuration to instantiate the cores successfully. > > > > Since this is a board level dependency, keep the R5 subsytem > > > > disabled at SoC dtsi, otherwise it results in probe errors like > > > > below during AM62P SK boot: > > > > > > > > r5fss@79000000: reserved memory init failed, ret = -22 > > > > r5fss@79000000: k3_r5_cluster_rproc_init failed, ret = -22 > > > > r5fss@78000000: reserved memory init failed, ret = -22 > > > > r5fss@78000000: k3_r5_cluster_rproc_init failed, ret = -22 > > > > > > > > Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs") > > > > > > > > Signed-off-by: Vaishnav Achath > > > > > > Reviewed-by: Jayesh Choudhary > > > > > > > --- > > > > arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi | 2 ++ > > > > arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi | 1 + > > > > 2 files changed, 3 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi > > > > index c4b0b91d70cf..14eb9ba836d3 100644 > > > > --- a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi > > > > +++ b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi > > > > @@ -187,6 +187,8 @@ mcu_r5fss0: r5fss@79000000 { > > > > ranges = <0x79000000 0x00 0x79000000 0x8000>, > > > > <0x79020000 0x00 0x79020000 0x8000>; > > > > power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>; > > > > + status = "disabled"; > > > > + ^^ Look here. > > > > mcu_r5fss0_core0: r5f@79000000 { > > > > compatible = "ti,am62-r5f"; > > > > reg = <0x79000000 0x00008000>, > > > > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi > > > > index 19f42b39394e..10a7059b2d9b 100644 > > > > --- a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi > > > > +++ b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi > > > > @@ -78,6 +78,7 @@ wkup_r5fss0: r5fss@78000000 { > > > > ranges = <0x78000000 0x00 0x78000000 0x8000>, > > > > <0x78100000 0x00 0x78100000 0x8000>; > > > > power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>; > > > > + status = "disabled"; > > ^^ no white space here. > > Is there a reason for difference in white space addition? > > > > For mcu_r5fss0_core0 child node there was no blank line as per the > recommended coding style : https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n124 > > So I added a newline there and wkup_r5fss0 already had it correct, since the > change was trivial it was not mentioned in commit message. Sigh, please add a EoL here to keep the look consistent between mcu and wakeup dtsis. there is no need to state in commit message. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel