From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59471C47422 for ; Fri, 26 Jan 2024 20:19:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dFxhX6estiMHlN+Ce3BDTsU9pYwhq0rlkbmro4/n9r4=; b=nd/J0MkN4vjxpz C6Nk0pxWEL2KOx3jd6gMmiaCDEFFOF+R8IgDnfP7WZ262LKycgNkBp6rPV4lUIf04vx/nGanceYR/ NF88daTUp86ktGcw3VpA4CfLhJMXsupCrCDd3q6nrknV/9fsYf1XIcLTUs/gFc+9+RdUZbu4nmrCp 5sy3kGErL+MmEu3fUpFYrGKOTe6QD1vHaQAiwrPqBGH4l3sTIHkfcU2xD6kR8cOEaCO+8P5T2zpqP GCYbh15t2KikDlLLwzJU0a73VmaxvW1fU7oWg30/aUT8SrytYpQCTbRwXYsEItf56qESzQeXffBHf t144Vi6AVihfDDX3fMKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTSfn-00000005M0d-3ExQ; Fri, 26 Jan 2024 20:19:35 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTSfk-00000005LzH-2wPY for linux-arm-kernel@lists.infradead.org; Fri, 26 Jan 2024 20:19:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 98107CE3782; Fri, 26 Jan 2024 20:19:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42C85C433C7; Fri, 26 Jan 2024 20:19:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706300369; bh=awpRcgfVITqJmr4m6h4D7QiLDSW/PQz0VRDDLkPva8Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=itgfnOi4w6ElrBtPlbwuYXt71w4C7FIgEdFIdykJMv2Tu/jW8Ums3HKR64Hl1v48o YxQ0t5yC9Lfg3pfiobJ7IlXjPeLofQVmw8PiR2mqxQQKGaip8sPjNNk+od/1Fe2Lyc yoJZJ33BUdCEV3fwOZCWHuvrUEDXC6c19kPHOFv8WfLBqDHsj6CwxRZwDo7RMY0Y1/ qRIeTFzLCrJD9QBQZ47+XsD2UR1gYLLhhStXkMQ6VRaXcMkXb6L9UR7/LZcQO3xl5w 6MuD9tVdSVx56gTAuwxVJ1h2AeHMLQm2YvlrEMHDnHhv6FAioR2rzf8XeIRqhvgZch YlFCZ4monKulQ== Date: Fri, 26 Jan 2024 12:19:28 -0800 From: Jakub Kicinski To: rohan.g.thomas@intel.com Cc: esben@geanix.com, alexandre.torgue@foss.st.com, conor+dt@kernel.org, davem@davemloft.net, devicetree@vger.kernel.org, edumazet@google.com, fancer.lancer@gmail.com, joabreu@synopsys.com, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, pabeni@redhat.com, peppe.cavallaro@st.com, robh@kernel.org Subject: Re: [PATCH net-next 1/2] dt-bindings: net: snps,dwmac: Time Based Scheduling Message-ID: <20240126121928.48a44327@kernel.org> In-Reply-To: <20240126173634.13162-1-rohan.g.thomas@intel.com> References: <87msss4gtj.fsf@geanix.com> <20240126173634.13162-1-rohan.g.thomas@intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240126_121932_947505_91281B76 X-CRM114-Status: GOOD ( 14.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 27 Jan 2024 01:36:34 +0800 rohan.g.thomas@intel.com wrote: > > The tricky part here is that the whole devicetree bindings story for the > > stmmac driver is filled with such configuration choices. As such, it is > > only natural to add the property you are suggesting here. I completely > > agree. But you can also argue that it is "wrong", because it does not > > just describe the hardware, but also a configuration choice. > > Isn't this requirement of using enhanced tx desc instead of normal tx > desc to support TBS is specific to Synopsys IP? Switching from > normal desc to enhanced desc at the time of tc-etf qdisc offload > cannot be done without traffic disruption, which I don't think is > acceptable. Since this behavior is IP specific, can we consider > this as an OS configuration choice? Why is traffic disruption not acceptable when TBS gets turned on? User has to install the right qdisc to enable TBS, I presume, installing qdiscs destroys the old ones which also leads to packet drops. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel