From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F10F1C47DDB for ; Fri, 26 Jan 2024 16:11:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4dP/Lt5t5FR+qk1cvJZZpcoOe4MRT/hnmOydcwCOphA=; b=3m+TWujUk+IHFX CCR4AzYPlanw5E+hpLZeSI/qcvlqixSxcxXf++cqU/5VuCa3/82mK674+EhnzX5H1mFOgYNagVvna RAHOMVVf8pr0MYUlIHheKf+9D0e1QtFLiS8PTQERD3LJ9QLMlCYZLvp1/CUuulxqJSo7rlpWTjBdy mKpoN/nItStT4SNCi90cvB4mcQ5RW9pTxchlaZFCrtU1gc27KO+pFiy3rGayW1cyM5JRIKNVDfqtM PlpvJf3RJSfzAlduhHuQj9O7+sZPAPUagrt/DeL2osKAaGK2TPh3jONoZ7Vx11zWp9iFsDD6yLqDM vvOmDN4P1Ux7fSydhNqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTOnE-00000004czW-2JkB; Fri, 26 Jan 2024 16:11:00 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTOnC-00000004cyz-1ZAI for linux-arm-kernel@lists.infradead.org; Fri, 26 Jan 2024 16:10:59 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AEB3262517; Fri, 26 Jan 2024 16:10:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD07AC43390; Fri, 26 Jan 2024 16:10:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706285427; bh=dCh3Q7IJrxBpqeaYZ3wZ62jWq+kUi+XKjTJ8+Wu15U4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tb6NbSgIH5Jh9xM0TXplcprBK9xu5xjIlahezLx9JjLaeV3D++84RBlfi1tb0r+B6 ktXLrOiruZrF5P4D+icn+bveWbxq5S9iaVGmCWyDqHYgdYlor6C12TOGUJXC2fwIup JiJdoKB8O18h/S6XqG30/QvhL/xLfKuqHzAzq9xoIu9cq4OZnFIl67icBw+brpRL9j EKs4VLlE39mii6pG12TJ1NjeyCv9vje0I64wtexLpUrozbiZ07z+sDcY8DNuFx0e9H RKPT/DXqqc9f2IHsymkR/kWJq1L9uriLoVILEXVBRw162F/Sm86OMkHbhe+ruZwnFq kDB+ARKOuczmg== Date: Fri, 26 Jan 2024 09:10:25 -0700 From: Nathan Chancellor To: Mark Rutland Cc: akpm@linux-foundation.org, masahiroy@kernel.org, nicolas@fjasle.eu, linux-kbuild@vger.kernel.org, llvm@lists.linux.dev, patches@lists.linux.dev, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 05/11] arm64: Kconfig: Clean up tautological LLVM version checks Message-ID: <20240126161025.GA3265550@dev-arch.thelio-3990X> References: <20240125-bump-min-llvm-ver-to-13-0-1-v1-0-f5ff9bda41c5@kernel.org> <20240125-bump-min-llvm-ver-to-13-0-1-v1-5-f5ff9bda41c5@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240126_081058_526130_123E62A3 X-CRM114-Status: GOOD ( 27.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 26, 2024 at 12:59:55PM +0000, Mark Rutland wrote: > On Thu, Jan 25, 2024 at 03:55:11PM -0700, Nathan Chancellor wrote: > > Now that the minimum supported version of LLVM for building the kernel > > has been bumped to 13.0.1, several conditions become tautologies, as > > they will always be true because the build will fail during the > > configuration stage for older LLVM versions. Drop them, as they are > > unnecessary. > > > > Signed-off-by: Nathan Chancellor > > --- > > Cc: catalin.marinas@arm.com > > Cc: will@kernel.org > > Cc: mark.rutland@arm.com > > Cc: linux-arm-kernel@lists.infradead.org > > --- > > arch/arm64/Kconfig | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index 5a8acca4dbf4..cb34e7d780c0 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -383,7 +383,7 @@ config BUILTIN_RETURN_ADDRESS_STRIPS_PAC > > bool > > # Clang's __builtin_return_adddress() strips the PAC since 12.0.0 > > # https://github.com/llvm/llvm-project/commit/2a96f47c5ffca84cd774ad402cacd137f4bf45e2 > > - default y if CC_IS_CLANG && (CLANG_VERSION >= 120000) > > + default y if CC_IS_CLANG > > # GCC's __builtin_return_address() strips the PAC since 11.1.0, > > # and this was backported to 10.2.0, 9.4.0, 8.5.0, but not earlier > > # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94891 > > @@ -1387,7 +1387,6 @@ choice > > > > config CPU_BIG_ENDIAN > > bool "Build big-endian kernel" > > - depends on !LD_IS_LLD || LLD_VERSION >= 130000 > > # https://github.com/llvm/llvm-project/commit/1379b150991f70a5782e9a143c2ba5308da1161c > > We can delete the URL here, since that was just to describe why this depended > upon LLVM 13+; it's weird for it to sit here on its own. I think this is the URL for the fix for the problem brought up by commit 146a15b87335 ("arm64: Restrict CPU_BIG_ENDIAN to GNU as or LLVM IAS 15.x or newer"), so I think it should stay? It does not look like I ever added a link or context for the LLD line, I definitely should have. > The URL above for __builtin_return_address() can stay or go; it may as well > stay since we have the comment aboout LLvm 12+ above it. That's the conclusion I came to as well. Thanks a lot for taking a look! Cheers, Nathan > With that: > > Acked-by: Mark Rutland > > Mark. > > > depends on AS_IS_GNU || AS_VERSION >= 150000 > > help > > @@ -2018,8 +2017,6 @@ config ARM64_BTI_KERNEL > > depends on !CC_IS_GCC || GCC_VERSION >= 100100 > > # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106671 > > depends on !CC_IS_GCC > > - # https://github.com/llvm/llvm-project/commit/a88c722e687e6780dcd6a58718350dc76fcc4cc9 > > - depends on !CC_IS_CLANG || CLANG_VERSION >= 120000 > > depends on (!FUNCTION_GRAPH_TRACER || DYNAMIC_FTRACE_WITH_ARGS) > > help > > Build the kernel with Branch Target Identification annotations > > > > -- > > 2.43.0 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel