From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48102C46CD2 for ; Sat, 27 Jan 2024 11:07:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=FYUwPvcXMxDWWMuPowznTpvYfsnBLjDQQJ3OthyEo9s=; b=TcIQW+AkrnuolO uaWQG+Ku/G8tE7oWBrI0yPkVGdad89JkYCiGUQxtSJNPJTL12rUlBA3U85UHlR39dDq3rj5OGUdTx trX80jtaOlh+goQ49CCj2IXVGqVE8Oa+kt335aMVIe2Asbsuh2hj4JN7fgcWAV8jKq0J7ooWc64KU 5VauQhNKAhZXhgoGy2TfJAvqrxFv7c63jVaD0tH4dJ8GSmvSIUu/86tSR+pjE/mjWGLjnCSZvWh/z AJj51TTTcZamNKFviDkJiaB0GvWSsbURSg1fxzjHvmf1DBoEeF9KkJg/Q8am+Jpqq4rTTQp1Oyq9R tKbyHc7WNLjVIUYxVORw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTgWx-00000007OT5-1OJm; Sat, 27 Jan 2024 11:07:23 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTgWu-00000007ORT-2ydL for linux-arm-kernel@lists.infradead.org; Sat, 27 Jan 2024 11:07:22 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 0D7ABCE2B6D; Sat, 27 Jan 2024 11:07:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB3DFC433F1; Sat, 27 Jan 2024 11:07:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706353627; bh=qe/aJOd+xQG/BxiEuD+b3seWRLQAsRPSIUxpziPYzZc=; h=From:To:Cc:Subject:Date:From; b=t/FXF07P0bGtTDbRB5QLdPEVF41f60ONKjKTgeTYWc/zs0SpTwH6PGK+oi0pBLJsF ngdVKQgu5fQQNBXMT1Obk3UIlaZaEaxA3WSVmz9V0l94ioJFd4l0P2Ang3D2KRBp8d 1UvxwZNr86s1WNsIP0JFBjl0ImZbZzQG7nZtEvwVqqxS4ioIBR6wuSbtvKRt+Yeu6O VBoKejH/70SvRpfPNqgZjsoYBE/fTSzJ3HVskNXw48gj3anUpN3vFtdx13P7BVf2Ua cxKRsZ3Kg9O2Pktj9PiI7SeaRKzuJRsSwDOiM5ldJ/1vD08Aso5mhRR2laxTBIm2oA UYOEQoa7wd2tw== Received: from sofa.misterjones.org ([185.219.108.64] helo=valley-girl.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rTgWf-00FKUL-4Q; Sat, 27 Jan 2024 11:07:05 +0000 From: Marc Zyngier To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Thomas Gleixner , Lorenzo Pieralisi , yuzenghui@huawei.com, stable@vger.kernel.org Subject: [PATCH] irqchip/gic-v3-its: Restore quirk probing for ACPI-based systems Date: Sat, 27 Jan 2024 11:07:02 +0000 Message-Id: <20240127110702.4068488-1-maz@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de, lpieralisi@kernel.org, yuzenghui@huawei.com, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240127_030720_928854_8B05D2FC X-CRM114-Status: GOOD ( 13.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org While refactoring the way the ITSs are probed, the handling of quirks applicable to ACPI-based platforms was lost. As a result, systems such as HIP07 lose their GICv4 functionnality, and some other may even fail to boot, unless they are configured to boot with DT. Move the enabling of quirks into its_probe_one(), making it common to all firmware implementations. Fixes: 9585a495ac93 ("irqchip/gic-v3-its: Split allocation from initialisation of its_node") Signed-off-by: Marc Zyngier Cc: stable@vger.kernel.org --- drivers/irqchip/irq-gic-v3-its.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index fec1b58470df..250b4562f308 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -5091,6 +5091,8 @@ static int __init its_probe_one(struct its_node *its) u32 ctlr; int err; + its_enable_quirks(its); + if (is_v4(its)) { if (!(its->typer & GITS_TYPER_VMOVP)) { err = its_compute_its_list_map(its); @@ -5442,7 +5444,6 @@ static int __init its_of_probe(struct device_node *node) if (!its) return -ENOMEM; - its_enable_quirks(its); err = its_probe_one(its); if (err) { its_node_destroy(its); -- 2.39.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel