From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D220FC47DB3 for ; Mon, 29 Jan 2024 16:57:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LgLPHSZ+txuypNPhfRuJgdJbKnjoyySuWaYPNywxpFA=; b=vD53QKGiD5ZQxHEDhQ7tXFe6vV XWAkmoGiII9TUKBB8OwdAGY5kGEsPch7LiHLbgf3RImNiYgY9tJ4RmAn8ixERjfZ2Ed0FbEM4hev7 2c1BQBN65+7qbFtt6SK0Lp1bWYlepRwWRJjiKwA8dDX2RKq3Ex6QztE599N1MYP8yo/AmeVt7n+cJ RCpZsZi+inwbnGNQRlu5GhuJ3ufI2WnoV+OXy7BkBK8m5GCogyEM9SuOZdccHqYzYDhblr2mYH89L MSSMnRn/cwOELVZk06p+NdhCIq5EMIVu+Vwe0DcUYBt36SbLyBPRI0tpCqqNLvfqyHSrBgWViz3vB 1EcxNgTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUUx9-0000000DdJW-3zXb; Mon, 29 Jan 2024 16:57:47 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUUx6-0000000DdHU-1Y5a for linux-arm-kernel@lists.infradead.org; Mon, 29 Jan 2024 16:57:46 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 79B91CE14E9; Mon, 29 Jan 2024 16:57:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7EF12C433F1; Mon, 29 Jan 2024 16:57:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706547459; bh=PY5cU+3UW7naDT2PjlI20f6EMZrbPVmbCyvO5POAvBQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i3WIpMrNEurrwyWrWFlIwOAON/JCCzeu2JMaXdahxyUfDn7e+HeDM07Gj/eUZxQj6 IH6iRzCvbQVwEGelrJByDP0aLwyNbSSIytcP3jrR6gnKoqem7pMw9qCT5BHH5YUZ+2 P+tpXLDr2N5lvQ0NKm3H9GHcGbO9gP9PULvOPuPSNH9ohoHgeNUez4UMmSJl73swg9 1eXcAN8WVcJMYmrGV6Ma+g3kFDhoTw4J73hBZleXxcq7IyMYGmu/D7LpfguBeEQQ10 FEKLyz/CIghkRFw99dYtQIcFR5k2Fi2Tqm3zqLbVZdulLkw1oyZNkLciZYXVPR1r7b kTBW9KXOwGn2w== Date: Mon, 29 Jan 2024 16:57:35 +0000 From: Conor Dooley To: Michal Simek Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, michal.simek@xilinx.com, git@xilinx.com, Conor Dooley , Krzysztof Kozlowski , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , kishore Manne , "moderated list:ARM/ZYNQ ARCHITECTURE" Subject: Re: [PATCH] dt-bindings: firmware: xilinx: Describe soc-vvmem subnode Message-ID: <20240129-vastly-hunk-0680e152c03c@spud> References: <3869498c995cbb123127122f429e90de0a3f4014.1706531104.git.michal.simek@amd.com> MIME-Version: 1.0 In-Reply-To: <3869498c995cbb123127122f429e90de0a3f4014.1706531104.git.michal.simek@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240129_085744_793204_B7177510 X-CRM114-Status: GOOD ( 18.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3614837170993442886==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3614837170993442886== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LOozDfvasueM032q" Content-Disposition: inline --LOozDfvasueM032q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 29, 2024 at 01:25:06PM +0100, Michal Simek wrote: > Describe soc-nvmem subnode as the part of firmware node. The name can't be > pure nvmem because dt-schema already defines it as array property that's > why different name should be used. >=20 > Signed-off-by: Michal Simek > --- >=20 > Dt binding for nvmem node has been already merged and it is the part of > linux-next tree. > Here is the reference to it just in case: > https://lore.kernel.org/r/170635581622.41421.8980881999042944764.b4-ty@li= naro.org >=20 > --- > .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqm= p-firmware.yaml b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zy= nqmp-firmware.yaml > index 7586fbff7ad6..108772ef574f 100644 > --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmw= are.yaml > +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmw= are.yaml > @@ -62,6 +62,12 @@ properties: > interface. > type: object > =20 > + soc-nvmem: > + $ref: /schemas/nvmem/xlnx,zynqmp-nvmem.yaml# > + description: The ZynqMP MPSoC provides access to the hardware relate= d data > + like SOC revision, IDCODE and specific purpose efuses. > + type: object > + > pcap: > $ref: /schemas/fpga/xlnx,zynqmp-pcap-fpga.yaml > description: The ZynqMP SoC uses the PCAP (Processor Configuration P= ort) to > @@ -110,6 +116,9 @@ examples: > firmware { > zynqmp_firmware: zynqmp-firmware { > #power-domain-cells =3D <1>; > + soc-nvmem { > + compatible =3D "xlnx,zynqmp-nvmem-fw"; > + }; Would it not be better to have an actual nvmem-layout in here? The ~empty node here looks rather odd. Also, there's a type in $subject of nvmem. Thanks, Conor. > gpio { > compatible =3D "xlnx,zynqmp-gpio-modepin"; > gpio-controller; > --=20 > 2.36.1 >=20 --LOozDfvasueM032q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZbfY/wAKCRB4tDGHoIJi 0rNqAP99TXsDxAY96t3sGZNtC3Vrmw+Zgegwmy/rGInLx2ByGwEAtZQ/EQisxfOm tWkHHbHJ9y+fW5zSNHf2/eVQEco79Q4= =PUQx -----END PGP SIGNATURE----- --LOozDfvasueM032q-- --===============3614837170993442886== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3614837170993442886==--