From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FC1BC47DA9 for ; Mon, 29 Jan 2024 20:24:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LZOg+TsYpjTjuET9vYDS5LsRrxzfLHyZ5wkipZPGCe0=; b=1OcY2AJUn0Uo4G jcux1lJCTytM6LHh4trjBPgrwjxywlkFcubOLrCquQ6FE7YxYea8HDOG+JSMdrmjDQ0imy24ARZ2i dO+kMSqva9miuCfp+x1jCAXu+Txj9YNcSVSrakJnzkmnIac2tJsX04ap/zXT4iSg/Blpr9N4Dtdr3 og8rK4vihq8FnJGtlE4TxT3Up8aYN5Pa90PL4DRkJ/KcL0M0qLksTJn82Gy7VUn8li0Ua1ts58dw4 bJj9is/8yTjj8iAjQqFEkam3Yn6Iz1wUpCQnu8j/oeg8q+jCCK8//1eI1PYrql6akhsFKBUZXvqWt vjHQxFTsQCX0LvnD3U7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUYB6-0000000EEUr-31B6; Mon, 29 Jan 2024 20:24:24 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUYB4-0000000EEUU-16uS for linux-arm-kernel@lists.infradead.org; Mon, 29 Jan 2024 20:24:23 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 6E002CE1386; Mon, 29 Jan 2024 20:24:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEB3DC433C7; Mon, 29 Jan 2024 20:24:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706559859; bh=rAnCgDX130n4Pu5xvGz9+ytgomDscbf8iqQYRZN9m/w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EnQ7uZ34Ob53zG2/8P4qFAZnQWAPouiVzki80qVjA3PDp+Kad4GQq8qJxCOT2sZG7 lfO/tIzu4Xz+mxMVoOR8Cz2oZzLI6m0bWhNjxKoCXayZS1yREWDp8O0Y4De/BX17C0 ybrbHX0tZk5IWnd7jUrgdWVbKLa9SJK5IStnOIh3Fba8Sqab6Sty1L2GQ1xqeKygSL YOinnmVlw9QitytUiQ6Q1MccwF2tPYhUncXmaTLjK8gZ4kfiYucbE32dfJBzX2bT9l 1CsUmVX0nsSXgTZV2rN/uyeJR55C21tHp/yrQ8C6YR0uiPqBJjbkpjNabQ7dpv5GCM sTJn7jatBtHUA== Date: Mon, 29 Jan 2024 12:24:18 -0800 From: Jakub Kicinski To: Cristian Ciocaltea Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , Samin Guo , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Giuseppe Cavallaro , Andrew Lunn , Jacob Keller , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@collabora.com Subject: Re: [RESEND PATCH v4 1/2] dt-bindings: net: starfive,jh7110-dwmac: Add JH7100 SoC compatible Message-ID: <20240129122418.173133d7@kernel.org> In-Reply-To: <20240126192128.1210579-2-cristian.ciocaltea@collabora.com> References: <20240126192128.1210579-1-cristian.ciocaltea@collabora.com> <20240126192128.1210579-2-cristian.ciocaltea@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240129_122422_514812_DDCD5FAB X-CRM114-Status: GOOD ( 11.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 26 Jan 2024 21:21:25 +0200 Cristian Ciocaltea wrote: > The Synopsys DesignWare MAC found on StarFive JH7100 SoC is mostly > similar to the newer JH7110, but it requires only two interrupts and a > single reset line, which is 'ahb' instead of the commonly used > 'stmmaceth'. > > Since the common binding 'snps,dwmac' allows selecting 'ahb' only in > conjunction with 'stmmaceth', extend the logic to also permit exclusive > usage of the 'ahb' reset name. This ensures the following use cases are > supported: > > JH7110: reset-names = "stmmaceth", "ahb"; > JH7100: reset-names = "ahb"; > other: reset-names = "stmmaceth"; > > Also note the need to use a different dwmac fallback, as v5.20 applies > to JH7110 only, while JH7100 relies on v3.7x. > > Additionally, drop the reset description items from top-level binding as > they are already provided by the included snps,dwmac schema. Reposting review tag from: https://lore.kernel.org/all/0a6f6dcb-18b0-48d5-8955-76bce0e1295d@linaro.org/ Reviewed-by: Krzysztof Kozlowski _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel