From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75837C46CD2 for ; Tue, 30 Jan 2024 16:55:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PRCwK89fIE0EMgmlKFG3G3epKq2SnEu7y1hdlvitdTQ=; b=sq7VSisFlYIte7aAqHAdbpQShe audt3DPCuU+n5PD/IMGClxYjcdaVfnmbkdJIuW3Ui2W2TrpQ/JUeNU9ygc/jlUZcWZXyZNiAZtIA8 1RcRD4A4FnC+e9C0XhMdJ5tYMxWAdKLVQl4E1rnhDOOAfI2ck2ELLMOgvwHKu4R/eEHGt3pk8bSzt eBa5+XUAoPhq8IG+7os7dFIv0DJKcLDGJ7yNAGJdA8/LNNdBOErU93tAxpcXG1/Um+SGDbgoi6dr8 yJLT+xSVJXfP100OQCyh3zNxSuIggikAb1Xbcb+WQC66kb8hibivC1Z+apYozOF4Vuhr7xeuQsrgS XTE5q9Lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUrOA-0000000HTTe-0mYz; Tue, 30 Jan 2024 16:55:10 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUrO6-0000000HTSb-1ks3 for linux-arm-kernel@lists.infradead.org; Tue, 30 Jan 2024 16:55:07 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4CE3D60EC7; Tue, 30 Jan 2024 16:55:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACA84C433C7; Tue, 30 Jan 2024 16:55:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706633705; bh=ZN68Z2wa2IkqX2W/7CDghaewC4izhCOODj8is9NucqQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O3OreCJz7R8m9wWmqrNDf02nbR+Q1XuExeLGFBooyAywAbZBmP4JsBozKg2A2ucfg gvAjj81k6Gy7Drs29C7GCeFstNnfFEq9m7piujeEIXVqMzNofzHqWFKEvH/JeCqcyT GPXjtj6E8qLvr407SlWspw6+Iwe4hFsLHYzx7DR0+sCpm8kQN5O/h2kAtB/zvdkj5x 9fofnIqdan+M3l7LNLYBGJ4ACXaAK3KV1bihcBI9+Xwbgv9TdbLZlBQBIxBa5jlQKg ywzP7ouscoF2r9Ysmw0tWfVbYbLpcz3MMhdTEQ1Etx7gZn1jTxCU7xCqYc2S0ezFXc qSmOZ7Tbm42Aw== Date: Tue, 30 Jan 2024 16:55:00 +0000 From: Conor Dooley To: Michal Simek Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, michal.simek@xilinx.com, git@xilinx.com, Conor Dooley , Krzysztof Kozlowski , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , kishore Manne , "moderated list:ARM/ZYNQ ARCHITECTURE" Subject: Re: [PATCH] dt-bindings: firmware: xilinx: Describe soc-vvmem subnode Message-ID: <20240130-synthetic-passerby-44bab0ad9e1a@spud> References: <3869498c995cbb123127122f429e90de0a3f4014.1706531104.git.michal.simek@amd.com> <20240129-vastly-hunk-0680e152c03c@spud> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240130_085506_572632_6399D4C6 X-CRM114-Status: GOOD ( 23.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4438434861577993798==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4438434861577993798== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BU7b17+mVNT7itsx" Content-Disposition: inline --BU7b17+mVNT7itsx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 30, 2024 at 08:13:09AM +0100, Michal Simek wrote: >=20 >=20 > On 1/29/24 17:57, Conor Dooley wrote: > > On Mon, Jan 29, 2024 at 01:25:06PM +0100, Michal Simek wrote: > > > Describe soc-nvmem subnode as the part of firmware node. The name can= 't be > > > pure nvmem because dt-schema already defines it as array property tha= t's > > > why different name should be used. > > >=20 > > > Signed-off-by: Michal Simek > > > --- > > >=20 > > > Dt binding for nvmem node has been already merged and it is the part = of > > > linux-next tree. > > > Here is the reference to it just in case: > > > https://lore.kernel.org/r/170635581622.41421.8980881999042944764.b4-t= y@linaro.org > > >=20 > > > --- > > > .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml | 9 ++++++= +++ > > > 1 file changed, 9 insertions(+) > > >=20 > > > diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,z= ynqmp-firmware.yaml b/Documentation/devicetree/bindings/firmware/xilinx/xln= x,zynqmp-firmware.yaml > > > index 7586fbff7ad6..108772ef574f 100644 > > > --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-f= irmware.yaml > > > +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-f= irmware.yaml > > > @@ -62,6 +62,12 @@ properties: > > > interface. > > > type: object > > > + soc-nvmem: > > > + $ref: /schemas/nvmem/xlnx,zynqmp-nvmem.yaml# > > > + description: The ZynqMP MPSoC provides access to the hardware re= lated data > > > + like SOC revision, IDCODE and specific purpose efuses. > > > + type: object > > > + > > > pcap: > > > $ref: /schemas/fpga/xlnx,zynqmp-pcap-fpga.yaml > > > description: The ZynqMP SoC uses the PCAP (Processor Configurat= ion Port) to > > > @@ -110,6 +116,9 @@ examples: > > > firmware { > > > zynqmp_firmware: zynqmp-firmware { > > > #power-domain-cells =3D <1>; > > > + soc-nvmem { > > > + compatible =3D "xlnx,zynqmp-nvmem-fw"; > > > + }; > >=20 > > Would it not be better to have an actual nvmem-layout in here? The > > ~empty node here looks rather odd. >=20 > No issue. Do you want full or just nvmem-layout with compatible string (w= hich is > required)? What you have below here seems like a much more useful example. I'd go with that. Cheers, Conor. > soc-nvmem { > compatible =3D "xlnx,zynqmp-nvmem-fw"; > nvmem-layout { > compatible =3D "fixed-layout"; > #address-cells =3D <1>; > #size-cells =3D <1>; >=20 > soc_revision: soc-revision@0 { > reg =3D <0x0 0x4>; > }; > }; > }; --BU7b17+mVNT7itsx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZbkp5AAKCRB4tDGHoIJi 0jQLAQCOeib5tcX6tEcKKUiRouIu3/C9GTGk2X/tIfQzaGKcxQD6AkDiq9g327L9 BZRRAwIsfJ0/zkLp6eBqjTbywmmPjgI= =/dwj -----END PGP SIGNATURE----- --BU7b17+mVNT7itsx-- --===============4438434861577993798== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4438434861577993798==--